commit c7e392d65eb927dc0c8a60f4a2f542a9b7a9b885
author nharper <nharper@google.com> Thu Mar 05 08:18:37 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Mar 05 08:19:16 2020 -0800
tree dca813b17bfa7f0a247cc9a97e22458fa3727ccc
parent 7544877c6980a919ad76d0d679b4b86927646cdd

Fix initialization of vectors in tls_connection.cc

This removes a memset(0) between constructing the vector and assigning
values to it.

gfe-relnote: n/a (no behavior change)
PiperOrigin-RevId: 299107062
Change-Id: Id42f29540850d2e96824c076b6d79cf9084a26e3

quic/core/crypto/tls_connection.cc

diff --git a/quic/core/crypto/tls_connection.cc b/quic/core/crypto/tls_connection.cc
index 4a36e3a..b0d2147 100644
--- a/quic/core/crypto/tls_connection.cc
+++ b/quic/core/crypto/tls_connection.cc
@@ -151,8 +151,7 @@
                                          size_t secret_length) {
   // TODO(nharper): replace this vector with a span (which unfortunately doesn't
   // yet exist in quic/platform/api).
-  std::vector<uint8_t> secret_vec(secret_length);
-  secret_vec.assign(secret, secret + secret_length);
+  std::vector<uint8_t> secret_vec(secret, secret + secret_length);
   TlsConnection::Delegate* delegate = ConnectionFromSsl(ssl)->delegate_;
   if (!delegate->SetReadSecret(QuicEncryptionLevel(level), cipher,
                                secret_vec)) {
@@ -169,8 +168,7 @@
                                           size_t secret_length) {
   // TODO(nharper): replace this vector with a span (which unfortunately doesn't
   // yet exist in quic/platform/api).
-  std::vector<uint8_t> secret_vec(secret_length);
-  secret_vec.assign(secret, secret + secret_length);
+  std::vector<uint8_t> secret_vec(secret, secret + secret_length);
   TlsConnection::Delegate* delegate = ConnectionFromSsl(ssl)->delegate_;
   delegate->SetWriteSecret(QuicEncryptionLevel(level), cipher, secret_vec);
   return 1;