Fix initialization of vectors in tls_connection.cc This removes a memset(0) between constructing the vector and assigning values to it. gfe-relnote: n/a (no behavior change) PiperOrigin-RevId: 299107062 Change-Id: Id42f29540850d2e96824c076b6d79cf9084a26e3
diff --git a/quic/core/crypto/tls_connection.cc b/quic/core/crypto/tls_connection.cc index 4a36e3a..b0d2147 100644 --- a/quic/core/crypto/tls_connection.cc +++ b/quic/core/crypto/tls_connection.cc
@@ -151,8 +151,7 @@ size_t secret_length) { // TODO(nharper): replace this vector with a span (which unfortunately doesn't // yet exist in quic/platform/api). - std::vector<uint8_t> secret_vec(secret_length); - secret_vec.assign(secret, secret + secret_length); + std::vector<uint8_t> secret_vec(secret, secret + secret_length); TlsConnection::Delegate* delegate = ConnectionFromSsl(ssl)->delegate_; if (!delegate->SetReadSecret(QuicEncryptionLevel(level), cipher, secret_vec)) { @@ -169,8 +168,7 @@ size_t secret_length) { // TODO(nharper): replace this vector with a span (which unfortunately doesn't // yet exist in quic/platform/api). - std::vector<uint8_t> secret_vec(secret_length); - secret_vec.assign(secret, secret + secret_length); + std::vector<uint8_t> secret_vec(secret, secret + secret_length); TlsConnection::Delegate* delegate = ConnectionFromSsl(ssl)->delegate_; delegate->SetWriteSecret(QuicEncryptionLevel(level), cipher, secret_vec); return 1;