commit c075ffa86fc75b95703ae8972e7c51b428ca74d4
author dschinazi <dschinazi@google.com> Thu Jun 27 16:17:37 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Jun 27 16:53:10 2019 -0700
tree e8b3b4b57f51c91e341f58e1154149c598332c73
parent f309f3eaa981500c93fce265372118db1d723d2f

Add DCHECKs to quic_framer

These DCHECKs helped debug some Chromium test issues.

gfe-relnote: n/a, dcheck-only
PiperOrigin-RevId: 255500147
Change-Id: I123f715b139e8bb374a77445afe54cd11b969166

quic/core/quic_framer.cc

diff --git a/quic/core/quic_framer.cc b/quic/core/quic_framer.cc
index 6a6046c..cdb941f 100644
--- a/quic/core/quic_framer.cc
+++ b/quic/core/quic_framer.cc
@@ -2096,7 +2096,9 @@
   QuicConnectionIdIncluded server_connection_id_included =
       GetServerConnectionIdIncludedAsSender(header, perspective_);
   DCHECK_EQ(CONNECTION_ID_ABSENT,
-            GetClientConnectionIdIncludedAsSender(header, perspective_));
+            GetClientConnectionIdIncludedAsSender(header, perspective_))
+      << ENDPOINT << ParsedQuicVersionToString(version_)
+      << " invalid header: " << header;
 
   switch (server_connection_id_included) {
     case CONNECTION_ID_ABSENT:
@@ -2228,6 +2230,10 @@
   if (QuicVersionHasLongHeaderLengths(transport_version()) &&
       header.version_flag) {
     if (header.long_packet_type == INITIAL) {
+      DCHECK_NE(VARIABLE_LENGTH_INTEGER_LENGTH_0,
+                header.retry_token_length_length)
+          << ENDPOINT << ParsedQuicVersionToString(version_)
+          << " bad retry token length length in header: " << header;
       // Write retry token length.
       if (!writer->WriteVarInt62(header.retry_token.length(),
                                  header.retry_token_length_length)) {