Remove unused QuicSpdyClientBase::MaybeAddQuicDataToResend() and class QuicDataToResend. PiperOrigin-RevId: 573006200
diff --git a/quiche/quic/tools/quic_spdy_client_base.cc b/quiche/quic/tools/quic_spdy_client_base.cc index a4e7ecc..74b03f1 100644 --- a/quiche/quic/tools/quic_spdy_client_base.cc +++ b/quiche/quic/tools/quic_spdy_client_base.cc
@@ -21,12 +21,6 @@ namespace quic { -QuicSpdyClientBase::QuicDataToResend::QuicDataToResend( - std::unique_ptr<Http2HeaderBlock> headers, absl::string_view body, bool fin) - : headers_(std::move(headers)), body_(body), fin_(fin) {} - -QuicSpdyClientBase::QuicDataToResend::~QuicDataToResend() = default; - QuicSpdyClientBase::QuicSpdyClientBase( const QuicServerId& server_id, const ParsedQuicVersionVector& supported_versions, const QuicConfig& config, @@ -192,25 +186,6 @@ return client_session()->GetNumReceivedServerConfigUpdates(); } -void QuicSpdyClientBase::MaybeAddQuicDataToResend( - std::unique_ptr<QuicDataToResend> data_to_resend) { - data_to_resend_on_connect_.push_back(std::move(data_to_resend)); -} - -void QuicSpdyClientBase::ClearDataToResend() { - data_to_resend_on_connect_.clear(); -} - -void QuicSpdyClientBase::ResendSavedData() { - // Calling Resend will re-enqueue the data, so swap out - // data_to_resend_on_connect_ before iterating. - std::vector<std::unique_ptr<QuicDataToResend>> old_data; - old_data.swap(data_to_resend_on_connect_); - for (const auto& data : old_data) { - data->Resend(); - } -} - int QuicSpdyClientBase::latest_response_code() const { QUIC_BUG_IF(quic_bug_10949_3, !store_response_) << "Response not stored!"; return latest_response_code_;
diff --git a/quiche/quic/tools/quic_spdy_client_base.h b/quiche/quic/tools/quic_spdy_client_base.h index 3e52633..717d92a 100644 --- a/quiche/quic/tools/quic_spdy_client_base.h +++ b/quiche/quic/tools/quic_spdy_client_base.h
@@ -38,29 +38,6 @@ absl::string_view response_body) = 0; }; - // A piece of data that can be sent multiple times. For example, it can be a - // HTTP request that is resent after a connect=>version negotiation=>reconnect - // sequence. - class QuicDataToResend { - public: - // |headers| may be null, since it's possible to send data without headers. - QuicDataToResend(std::unique_ptr<spdy::Http2HeaderBlock> headers, - absl::string_view body, bool fin); - QuicDataToResend(const QuicDataToResend&) = delete; - QuicDataToResend& operator=(const QuicDataToResend&) = delete; - - virtual ~QuicDataToResend(); - - // Must be overridden by specific classes with the actual method for - // re-sending data. - virtual void Resend() = 0; - - protected: - std::unique_ptr<spdy::Http2HeaderBlock> headers_; - absl::string_view body_; - bool fin_; - }; - QuicSpdyClientBase(const QuicServerId& server_id, const ParsedQuicVersionVector& supported_versions, const QuicConfig& config, @@ -101,12 +78,6 @@ QuicSpdyClientSession* client_session(); const QuicSpdyClientSession* client_session() const; - // If the crypto handshake has not yet been confirmed, adds the data to the - // queue of data to resend if the client receives a stateless reject. - // Otherwise, deletes the data. - void MaybeAddQuicDataToResend( - std::unique_ptr<QuicDataToResend> data_to_resend); - void set_store_response(bool val) { store_response_ = val; } int latest_response_code() const; @@ -158,9 +129,9 @@ const quic::ParsedQuicVersionVector& supported_versions, QuicConnection* connection) override; - void ClearDataToResend() override; + void ClearDataToResend() override {} - void ResendSavedData() override; + void ResendSavedData() override {} bool HasActiveRequests() override; @@ -189,10 +160,6 @@ // Listens for full responses. std::unique_ptr<ResponseListener> response_listener_; - // Keeps track of any data that must be resent upon a subsequent successful - // connection, in case the client receives a stateless reject. - std::vector<std::unique_ptr<QuicDataToResend>> data_to_resend_on_connect_; - bool drop_response_body_ = false; bool enable_web_transport_ = false; bool use_datagram_contexts_ = false;