Add presubmit to disallow absl in /third_party/quic/
Motivation was that the quic_test_client change in cl/286244043 broke the Chromium merge.
gfe-relnote: n/a, no behavior change
PiperOrigin-RevId: 286489674
Change-Id: I65067f43f04a986028d9415e0e4a2b01d3fec0a4
diff --git a/quic/qbone/platform/netlink_test.cc b/quic/qbone/platform/netlink_test.cc
index 04ce68c..d6a4adf 100644
--- a/quic/qbone/platform/netlink_test.cc
+++ b/quic/qbone/platform/netlink_test.cc
@@ -194,8 +194,8 @@
family = AF_INET6;
break;
default:
- QUIC_BUG << absl::StrCat("unexpected address family: ",
- ip.address_family());
+ QUIC_BUG << quiche::QuicheStrCat("unexpected address family: ",
+ ip.address_family());
family = AF_UNSPEC;
}
auto* msg = reinterpret_cast<struct ifaddrmsg*>(NLMSG_DATA(nlm));
diff --git a/quic/qbone/qbone_server_session.cc b/quic/qbone/qbone_server_session.cc
index c5456bf..6c5697b 100644
--- a/quic/qbone/qbone_server_session.cc
+++ b/quic/qbone/qbone_server_session.cc
@@ -20,7 +20,7 @@
const QuicSocketAddress& peer_address,
const QuicSocketAddress& self_address,
string* error_details) const {
- absl::string_view alpn;
+ quiche::QuicheStringPiece alpn;
chlo.GetStringPiece(quic::kALPN, &alpn);
if (alpn != QboneConstants::kQboneAlpn) {
*error_details = "ALPN-indicated protocol is not qbone";
diff --git a/quic/test_tools/quic_test_client.cc b/quic/test_tools/quic_test_client.cc
index 9657c8b..1f95d22 100644
--- a/quic/test_tools/quic_test_client.cc
+++ b/quic/test_tools/quic_test_client.cc
@@ -672,7 +672,7 @@
return true;
}
-ssize_t QuicTestClient::Send(absl::string_view data) {
+ssize_t QuicTestClient::Send(quiche::QuicheStringPiece data) {
return SendData(std::string(data), false);
}
diff --git a/quic/test_tools/quic_test_client.h b/quic/test_tools/quic_test_client.h
index baeff71..f74974f 100644
--- a/quic/test_tools/quic_test_client.h
+++ b/quic/test_tools/quic_test_client.h
@@ -156,7 +156,7 @@
QuicSocketAddress local_address() const;
void ClearPerRequestState();
bool WaitUntil(int timeout_ms, std::function<bool()> trigger);
- ssize_t Send(absl::string_view data);
+ ssize_t Send(quiche::QuicheStringPiece data);
bool connected() const;
bool buffer_body() const;
void set_buffer_body(bool buffer_body);
