commit a12ff5d8f36605b54fa99bbefcb8e6e5fddc413d
author martinduke <martinduke@google.com> Wed Oct 12 17:25:51 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Oct 12 17:26:36 2022 -0700
tree e2694ac16f8a841a8f39ed09ec614b44ecbc0cff
parent a338ea8277642f6d78022dc8e3aaed182a804413

Eliminate enum QuicConnectionIdLength.

We are evolving to having a wide range of connection ID lengths and having special values is no longer appropriate.

PiperOrigin-RevId: 480759110

quiche/quic/core/quic_stream_test.cc

diff --git a/quiche/quic/core/quic_stream_test.cc b/quiche/quic/core/quic_stream_test.cc
index deb7c98..1e77c5a 100644
--- a/quiche/quic/core/quic_stream_test.cc
+++ b/quiche/quic/core/quic_stream_test.cc
@@ -50,6 +50,8 @@
 const char kData1[] = "FooAndBar";
 const char kData2[] = "EepAndBaz";
 const QuicByteCount kDataLen = 9;
+const uint8_t kPacket0ByteConnectionId = 0;
+const uint8_t kPacket8ByteConnectionId = 8;
 
 class TestStream : public QuicStream {
  public:
@@ -343,8 +345,8 @@
 
   QuicByteCount length =
       1 + QuicPacketCreator::StreamFramePacketOverhead(
-              connection_->transport_version(), PACKET_8BYTE_CONNECTION_ID,
-              PACKET_0BYTE_CONNECTION_ID, !kIncludeVersion,
+              connection_->transport_version(), kPacket8ByteConnectionId,
+              kPacket0ByteConnectionId, !kIncludeVersion,
               !kIncludeDiversificationNonce, PACKET_4BYTE_PACKET_NUMBER,
               quiche::VARIABLE_LENGTH_INTEGER_LENGTH_0,
               quiche::VARIABLE_LENGTH_INTEGER_LENGTH_0, 0u);
@@ -428,8 +430,8 @@
   EXPECT_FALSE(HasWriteBlockedStreams());
   QuicByteCount length =
       1 + QuicPacketCreator::StreamFramePacketOverhead(
-              connection_->transport_version(), PACKET_8BYTE_CONNECTION_ID,
-              PACKET_0BYTE_CONNECTION_ID, !kIncludeVersion,
+              connection_->transport_version(), kPacket8ByteConnectionId,
+              kPacket0ByteConnectionId, !kIncludeVersion,
               !kIncludeDiversificationNonce, PACKET_4BYTE_PACKET_NUMBER,
               quiche::VARIABLE_LENGTH_INTEGER_LENGTH_0,
               quiche::VARIABLE_LENGTH_INTEGER_LENGTH_0, 0u);