gfe-relnote: Fixes HPACK encoding of SpdyHeaderBlocks when compression is disabled. No functional change in production.
For HTTP/2, compression is always enabled in production. Shinkansen metadata uses a different HpackEncoder API that is not affected by this CL.
PiperOrigin-RevId: 285208542
Change-Id: I8c755500bb4c1004d264c7663bc4d6308a0b06ce
diff --git a/spdy/core/hpack/hpack_encoder_test.cc b/spdy/core/hpack/hpack_encoder_test.cc
index fb09301..b18abad 100644
--- a/spdy/core/hpack/hpack_encoder_test.cc
+++ b/spdy/core/hpack/hpack_encoder_test.cc
@@ -426,8 +426,7 @@
ExpectNonIndexedLiteral(":path", "/index.html");
ExpectNonIndexedLiteral("cookie", "foo=bar");
ExpectNonIndexedLiteral("cookie", "baz=bing");
- if (strategy_ != kDefault) {
- // BUG: encodes as a \0-delimited value. Should be separate entries.
+ if (strategy_ == kRepresentations) {
ExpectNonIndexedLiteral("hello", std::string("goodbye\0aloha", 13));
} else {
ExpectNonIndexedLiteral("hello", "goodbye");
@@ -444,9 +443,7 @@
CompareWithExpectedEncoding(headers);
- if (strategy_ != kDefault) {
- // BUG: value for "hello" encodes as \0-delimited. Should be separate
- // entries.
+ if (strategy_ == kRepresentations) {
EXPECT_THAT(
headers_observed_,
ElementsAre(Pair(":path", "/index.html"), Pair("cookie", "foo=bar"),
