Allow variable length connection IDs in v99
This CL enables the use of QUIC variable length connection IDs (VLCIDs) in v99. It also relaxes some checks when VLCIDs are enabled, and fixes tests that were relying on this. This CL also fixes QuicFramerTest.MissingDiversificationNonce as this work uncovered that the test was failure to parse headers because the headers were wrong, instead of testing for missing diversification nonces.
gfe-relnote: change only impacts v99 and tests, not flag protected
PiperOrigin-RevId: 238522262
Change-Id: I1a33470f1c9f8e5e83da44e82bdb2969fa9ed8ea
diff --git a/quic/test_tools/quic_test_utils.cc b/quic/test_tools/quic_test_utils.cc
index aca0a57..d74df6a 100644
--- a/quic/test_tools/quic_test_utils.cc
+++ b/quic/test_tools/quic_test_utils.cc
@@ -47,6 +47,18 @@
sizeof(connection_id64_net));
}
+QuicConnectionId TestConnectionIdNineBytesLong(uint64_t connection_number) {
+ const uint64_t connection_number_net =
+ QuicEndian::HostToNet64(connection_number);
+ char connection_id_bytes[9] = {};
+ static_assert(
+ sizeof(connection_id_bytes) == 1 + sizeof(connection_number_net),
+ "bad lengths");
+ memcpy(connection_id_bytes + 1, &connection_number_net,
+ sizeof(connection_number_net));
+ return QuicConnectionId(connection_id_bytes, sizeof(connection_id_bytes));
+}
+
uint64_t TestConnectionIdToUInt64(QuicConnectionId connection_id) {
DCHECK_EQ(connection_id.length(), kQuicDefaultConnectionIdLength);
uint64_t connection_id64_net = 0;
