commit 8a39cd0796cae211f29b939bbc5e55cf65132747
author wub <wub@google.com> Fri Mar 13 12:35:25 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Mar 13 12:35:58 2020 -0700
tree cdaad1b73f020b88efeb5dca78128b8f7da1c09b
parent 09c1edaf25b92cd650459a38b1a1dcfa9ef513b7

gfe-relnote: Add some QUIC_BUGs to debug b/151424244. Not protected.

Since the errors in b/151424244 appeared soon after cl/300605878 were submitted, the error logs in this CL should appear in the next Monday's GFE canary.

PiperOrigin-RevId: 300807090
Change-Id: I0720ab544d1c33a975084dc37f96894f81d6d2bc

quic/core/congestion_control/bandwidth_sampler.cc

diff --git a/quic/core/congestion_control/bandwidth_sampler.cc b/quic/core/congestion_control/bandwidth_sampler.cc
index 54aa89e..df6eb24 100644
--- a/quic/core/congestion_control/bandwidth_sampler.cc
+++ b/quic/core/congestion_control/bandwidth_sampler.cc
@@ -300,6 +300,7 @@
   // current packet was sent. In that case, there is no bandwidth sample to
   // make.
   if (sent_packet.last_acked_packet_sent_time == QuicTime::Zero()) {
+    QUIC_BUG << "sent_packet.last_acked_packet_sent_time is zero";
     return BandwidthSample();
   }
 
@@ -334,11 +335,10 @@
     } else {
       QUIC_CODE_COUNT_N(quic_prev_ack_time_larger_than_current_ack_time, 2, 2);
     }
-    QUIC_LOG_EVERY_N_SEC(ERROR, 60)
-        << "Time of the previously acked packet:"
-        << a0.ack_time.ToDebuggingValue()
-        << " is larger than the ack time of the current packet:"
-        << ack_time.ToDebuggingValue();
+    QUIC_BUG << "Time of the previously acked packet:"
+             << a0.ack_time.ToDebuggingValue()
+             << " is larger than the ack time of the current packet:"
+             << ack_time.ToDebuggingValue();
     return BandwidthSample();
   }
   QuicBandwidth ack_rate = QuicBandwidth::FromBytesAndTimeDelta(
@@ -351,6 +351,9 @@
   // on low bandwidth connections.
   sample.rtt = ack_time - sent_packet.sent_time;
   SentPacketToSendTimeState(sent_packet, &sample.state_at_send);
+
+  QUIC_BUG_IF(sample.bandwidth.IsZero())
+      << "ack_rate: " << ack_rate << ", send_rate: " << send_rate;
   return sample;
 }