commit 8873e57794cdb6dd643edd0dfc9e52f74195b67e
author bnc <bnc@google.com> Thu Jul 25 08:45:42 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Jul 25 18:02:11 2019 -0700
tree 92c6b187c82d7f26cc1f7cc0cf8377e48971d2ad
parent c8579866e275d980b4793b7e1ba5c96631490b07

Use QpackEncodeRequiredInsertCount(0) instead of 0 in QpackEncoder.

gfe-relnote: n/a, change to QUIC v99-only code.  Protected by existing disabled gfe2_reloadable_flag_quic_enable_version_99.
PiperOrigin-RevId: 259953593
Change-Id: I68f8f2e8e90aa48ed0aa3879bb524253abc965d9

quic/core/qpack/qpack_encoder.cc

diff --git a/quic/core/qpack/qpack_encoder.cc b/quic/core/qpack/qpack_encoder.cc
index 3ffe9d0..4759e42 100644
--- a/quic/core/qpack/qpack_encoder.cc
+++ b/quic/core/qpack/qpack_encoder.cc
@@ -8,6 +8,7 @@
 
 #include "net/third_party/quiche/src/quic/core/qpack/qpack_constants.h"
 #include "net/third_party/quiche/src/quic/core/qpack/qpack_instruction_encoder.h"
+#include "net/third_party/quiche/src/quic/core/qpack/qpack_required_insert_count.h"
 #include "net/third_party/quiche/src/quic/core/qpack/value_splitting_header_list.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h"
@@ -72,15 +73,18 @@
     }
   }
 
+  // TODO(bnc): Implement dynamic entries and set Required Insert Count
+  // accordingly.
+  const uint64_t required_insert_count = 0;
+
   // Second pass.
   QpackInstructionEncoder instruction_encoder;
   std::string encoded_headers;
 
   // Header block prefix.
-  // TODO(bnc): Implement dynamic entries and set Required Insert Count and
-  // Delta Base accordingly.
   QpackInstructionEncoder::Values values;
-  values.varint = 0;     // Encoded required insert count.
+  values.varint = QpackEncodeRequiredInsertCount(required_insert_count,
+                                                 header_table_.max_entries());
   values.varint2 = 0;    // Delta Base.
   values.s_bit = false;  // Delta Base sign.