gfe-relnote: Close QUIC connection is there are too many (> 1000) buffered control frames in control frame manager. Protected by gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames.
PiperOrigin-RevId: 261002263
Change-Id: I4dd92d5c1ea159d05cf35719f1a7ccc36f7b3fd3
diff --git a/quic/core/quic_control_frame_manager_test.cc b/quic/core/quic_control_frame_manager_test.cc
index 216ba74..8059ff6 100644
--- a/quic/core/quic_control_frame_manager_test.cc
+++ b/quic/core/quic_control_frame_manager_test.cc
@@ -4,6 +4,7 @@
#include "net/third_party/quiche/src/quic/core/quic_control_frame_manager.h"
+#include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h"
#include "net/third_party/quiche/src/quic/platform/api/quic_flags.h"
#include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h"
#include "net/third_party/quiche/src/quic/platform/api/quic_test.h"
@@ -288,6 +289,27 @@
EXPECT_FALSE(manager_->WillingToWrite());
}
+TEST_F(QuicControlFrameManagerTest, TooManyBufferedControlFrames) {
+ SetQuicReloadableFlag(quic_add_upper_limit_of_buffered_control_frames, true);
+ Initialize();
+ EXPECT_CALL(*connection_, SendControlFrame(_))
+ .Times(5)
+ .WillRepeatedly(Invoke(&ClearControlFrame));
+ // Flush buffered frames.
+ manager_->OnCanWrite();
+ // Write 995 control frames.
+ EXPECT_CALL(*connection_, SendControlFrame(_)).WillOnce(Return(false));
+ for (size_t i = 0; i < 995; ++i) {
+ manager_->WriteOrBufferRstStream(kTestStreamId, QUIC_STREAM_CANCELLED, 0);
+ }
+ // Verify write one more control frame causes connection close.
+ EXPECT_CALL(
+ *connection_,
+ CloseConnection(QUIC_TOO_MANY_BUFFERED_CONTROL_FRAMES, _,
+ ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET));
+ manager_->WriteOrBufferRstStream(kTestStreamId, QUIC_STREAM_CANCELLED, 0);
+}
+
} // namespace
} // namespace test
} // namespace quic
