Move NoopQpackStreamSenderDelegate to qpack_test_utils.h. BUILD files cleaned with build_cleaner. gfe-relnote: n/a, test-only change. PiperOrigin-RevId: 281872413 Change-Id: I46c909742c2e49e064accc7d604b49d9e57d6f16
diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc index 01595c9..26215bb 100644 --- a/quic/core/http/end_to_end_test.cc +++ b/quic/core/http/end_to_end_test.cc
@@ -42,6 +42,7 @@ #include "net/third_party/quiche/src/quic/test_tools/packet_dropping_test_writer.h" #include "net/third_party/quiche/src/quic/test_tools/packet_reordering_writer.h" #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_encoder_test_utils.h" +#include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_client_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_connection_peer.h"
diff --git a/quic/core/http/quic_spdy_session.h b/quic/core/http/quic_spdy_session.h index 0b86627..6bbf2ed 100644 --- a/quic/core/http/quic_spdy_session.h +++ b/quic/core/http/quic_spdy_session.h
@@ -21,7 +21,6 @@ #include "net/third_party/quiche/src/quic/core/qpack/qpack_encoder_stream_sender.h" #include "net/third_party/quiche/src/quic/core/qpack/qpack_receive_stream.h" #include "net/third_party/quiche/src/quic/core/qpack/qpack_send_stream.h" -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/core/quic_session.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/platform/api/quic_export.h"
diff --git a/quic/core/http/quic_spdy_stream_test.cc b/quic/core/http/quic_spdy_stream_test.cc index f6ae7f5..61e6f37 100644 --- a/quic/core/http/quic_spdy_stream_test.cc +++ b/quic/core/http/quic_spdy_stream_test.cc
@@ -22,6 +22,7 @@ #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h" +#include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_flow_controller_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_session_peer.h"
diff --git a/quic/core/qpack/fuzzer/qpack_decoder_fuzzer.cc b/quic/core/qpack/fuzzer/qpack_decoder_fuzzer.cc index 7078da1..162f88a 100644 --- a/quic/core/qpack/fuzzer/qpack_decoder_fuzzer.cc +++ b/quic/core/qpack/fuzzer/qpack_decoder_fuzzer.cc
@@ -8,10 +8,10 @@ #include <utility> #include "net/third_party/quiche/src/quic/core/qpack/qpack_decoder.h" -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_fuzzed_data_provider.h" #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_decoder_test_utils.h" +#include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_test_utils.h" namespace quic { namespace test {
diff --git a/quic/core/qpack/fuzzer/qpack_encoder_stream_sender_fuzzer.cc b/quic/core/qpack/fuzzer/qpack_encoder_stream_sender_fuzzer.cc index 39fb674..7efaf88 100644 --- a/quic/core/qpack/fuzzer/qpack_encoder_stream_sender_fuzzer.cc +++ b/quic/core/qpack/fuzzer/qpack_encoder_stream_sender_fuzzer.cc
@@ -8,10 +8,10 @@ #include <string> #include "net/third_party/quiche/src/quic/core/qpack/qpack_encoder_stream_sender.h" -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_fuzzed_data_provider.h" #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_encoder_test_utils.h" +#include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_test_utils.h" namespace quic { namespace test {
diff --git a/quic/core/qpack/fuzzer/qpack_round_trip_fuzzer.cc b/quic/core/qpack/fuzzer/qpack_round_trip_fuzzer.cc index 2a2efc4..43a637d 100644 --- a/quic/core/qpack/fuzzer/qpack_round_trip_fuzzer.cc +++ b/quic/core/qpack/fuzzer/qpack_round_trip_fuzzer.cc
@@ -13,7 +13,6 @@ #include "net/third_party/quiche/src/quic/core/qpack/qpack_decoder.h" #include "net/third_party/quiche/src/quic/core/qpack/qpack_encoder.h" #include "net/third_party/quiche/src/quic/core/qpack/qpack_stream_sender_delegate.h" -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/core/qpack/value_splitting_header_list.h" #include "net/third_party/quiche/src/quic/platform/api/quic_containers.h" #include "net/third_party/quiche/src/quic/platform/api/quic_fuzzed_data_provider.h"
diff --git a/quic/core/qpack/qpack_encoder_test.cc b/quic/core/qpack/qpack_encoder_test.cc index d29e9e4..6b92e4b 100644 --- a/quic/core/qpack/qpack_encoder_test.cc +++ b/quic/core/qpack/qpack_encoder_test.cc
@@ -7,7 +7,6 @@ #include <limits> #include <string> -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h" #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_encoder_peer.h"
diff --git a/quic/core/qpack/qpack_round_trip_test.cc b/quic/core/qpack/qpack_round_trip_test.cc index 306103c..f0dc797 100644 --- a/quic/core/qpack/qpack_round_trip_test.cc +++ b/quic/core/qpack/qpack_round_trip_test.cc
@@ -5,7 +5,6 @@ #include <string> #include <tuple> -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_decoder_test_utils.h"
diff --git a/quic/core/qpack/qpack_utils.h b/quic/core/qpack/qpack_utils.h deleted file mode 100644 index 1b63422..0000000 --- a/quic/core/qpack/qpack_utils.h +++ /dev/null
@@ -1,23 +0,0 @@ -// Copyright (c) 2019 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef QUICHE_QUIC_CORE_QPACK_QPACK_UTILS_H_ -#define QUICHE_QUIC_CORE_QPACK_QPACK_UTILS_H_ - -#include "net/third_party/quiche/src/quic/core/qpack/qpack_stream_sender_delegate.h" - -namespace quic { -// TODO(renjietang): Move this class to qpack_test_utils.h once it is not needed -// in QuicSpdySession. -class QUIC_EXPORT_PRIVATE NoopQpackStreamSenderDelegate - : public QpackStreamSenderDelegate { - public: - ~NoopQpackStreamSenderDelegate() override = default; - - void WriteStreamData(QuicStringPiece /*data*/) override {} -}; - -} // namespace quic - -#endif // QUICHE_QUIC_CORE_QPACK_QPACK_UTILS_H_
diff --git a/quic/test_tools/qpack/qpack_offline_decoder.h b/quic/test_tools/qpack/qpack_offline_decoder.h index e945737..cb7dedd 100644 --- a/quic/test_tools/qpack/qpack_offline_decoder.h +++ b/quic/test_tools/qpack/qpack_offline_decoder.h
@@ -8,9 +8,9 @@ #include <list> #include "net/third_party/quiche/src/quic/core/qpack/qpack_decoder.h" -#include "net/third_party/quiche/src/quic/core/qpack/qpack_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" #include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_decoder_test_utils.h" +#include "net/third_party/quiche/src/quic/test_tools/qpack/qpack_test_utils.h" #include "net/third_party/quiche/src/spdy/core/spdy_header_block.h" namespace quic { @@ -71,7 +71,7 @@ spdy::SpdyHeaderBlock expected_header_list); bool encoder_stream_error_detected_; - NoopQpackStreamSenderDelegate decoder_stream_sender_delegate_; + test::NoopQpackStreamSenderDelegate decoder_stream_sender_delegate_; std::unique_ptr<QpackDecoder> qpack_decoder_; // Objects necessary for decoding, one list element for each header block.
diff --git a/quic/test_tools/qpack/qpack_test_utils.h b/quic/test_tools/qpack/qpack_test_utils.h index 2dc3933..08cab4e 100644 --- a/quic/test_tools/qpack/qpack_test_utils.h +++ b/quic/test_tools/qpack/qpack_test_utils.h
@@ -34,6 +34,13 @@ MOCK_METHOD1(WriteStreamData, void(QuicStringPiece data)); }; +class NoopQpackStreamSenderDelegate : public QpackStreamSenderDelegate { + public: + ~NoopQpackStreamSenderDelegate() override = default; + + void WriteStreamData(QuicStringPiece /*data*/) override {} +}; + } // namespace test } // namespace quic