commit 7c2391750ea32c7bcf31344f3ee46099cb0fb0e8
author renjietang <renjietang@google.com> Fri Feb 21 13:50:39 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Feb 21 13:51:15 2020 -0800
tree 7c9a03d35abcf725bf2a5e84e427650b0645e52d
parent 77b4641876cabd926934979ecb0a2d1f9a8e10d9

Remove stream pointer from QuicSession::WritevData.

The session only uses the pointer to access stream_bytes_written. It could simply be replaced by a |is_retransmission| boolean. This change makes the boundary of streams and sessions clearer.

gfe-relnote: no behavior change, not protected.
PiperOrigin-RevId: 296504335
Change-Id: I349bdadadd923e9dcb5b03231ce351e4f1a25c96

quic/core/qpack/qpack_send_stream_test.cc

diff --git a/quic/core/qpack/qpack_send_stream_test.cc b/quic/core/qpack/qpack_send_stream_test.cc
index ab0f3d7..e3fcc15 100644
--- a/quic/core/qpack/qpack_send_stream_test.cc
+++ b/quic/core/qpack/qpack_send_stream_test.cc
@@ -77,7 +77,7 @@
         QuicSpdySessionPeer::GetQpackDecoderSendStream(&session_);
 
     ON_CALL(session_, WritevData(_, _, _, _, _))
-        .WillByDefault(Invoke(MockQuicSession::ConsumeData));
+        .WillByDefault(Invoke(&session_, &MockQuicSpdySession::ConsumeData));
   }
 
   Perspective perspective() const { return GetParam().perspective; }
@@ -96,11 +96,11 @@
 
 TEST_P(QpackSendStreamTest, WriteStreamTypeOnlyFirstTime) {
   std::string data = "data";
-  EXPECT_CALL(session_, WritevData(_, _, 1, _, _));
-  EXPECT_CALL(session_, WritevData(_, _, data.length(), _, _));
+  EXPECT_CALL(session_, WritevData(_, 1, _, _, _));
+  EXPECT_CALL(session_, WritevData(_, data.length(), _, _, _));
   qpack_send_stream_->WriteStreamData(quiche::QuicheStringPiece(data));
 
-  EXPECT_CALL(session_, WritevData(_, _, data.length(), _, _));
+  EXPECT_CALL(session_, WritevData(_, data.length(), _, _, _));
   qpack_send_stream_->WriteStreamData(quiche::QuicheStringPiece(data));
   EXPECT_CALL(session_, WritevData(_, _, _, _, _)).Times(0);
   qpack_send_stream_->MaybeSendStreamType();