commit 7b9278ccf37a720fdeffea8b55104797229514fe
author dschinazi <dschinazi@google.com> Mon May 20 07:36:21 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Mon May 20 08:42:05 2019 -0700
tree 22158c04140356a1ab9a6f3a91e7595050a65880
parent 034c98c00b23150a20d39e9ce90e71586102bc6c

Rename connection_id to server_connection_id

This is a step on the way to enabling client connection IDs. It will make the code less ambiguous once we introduce client_connection_id.

gfe-relnote: n/a, renaming code only
PiperOrigin-RevId: 249045070
Change-Id: Ia7ba75511f96c896bc6f0f4978dae2cd13e707fb

quic/core/quic_framer.cc

diff --git a/quic/core/quic_framer.cc b/quic/core/quic_framer.cc
index 27af834..eff8f49 100644
--- a/quic/core/quic_framer.cc
+++ b/quic/core/quic_framer.cc
@@ -462,7 +462,7 @@
                        uint8_t expected_connection_id_length)
     : visitor_(nullptr),
       error_(QUIC_NO_ERROR),
-      last_serialized_connection_id_(EmptyQuicConnectionId()),
+      last_serialized_server_connection_id_(EmptyQuicConnectionId()),
       last_version_label_(0),
       version_(PROTOCOL_UNSUPPORTED, QUIC_VERSION_UNSUPPORTED),
       supported_versions_(supported_versions),
@@ -1427,13 +1427,13 @@
 // static
 std::unique_ptr<QuicEncryptedPacket>
 QuicFramer::BuildIetfVersionNegotiationPacket(
-    QuicConnectionId connection_id,
+    QuicConnectionId source_connection_id,
     const ParsedQuicVersionVector& versions) {
   QUIC_DVLOG(1) << "Building IETF version negotiation packet: "
                 << ParsedQuicVersionVectorToString(versions);
   DCHECK(!versions.empty());
   size_t len = kPacketHeaderTypeSize + kConnectionIdLengthSize +
-               connection_id.length() +
+               source_connection_id.length() +
                (versions.size() + 1) * kQuicVersionSize;
   std::unique_ptr<char[]> buffer(new char[len]);
   QuicDataWriter writer(len, buffer.get());
@@ -1452,8 +1452,8 @@
     return nullptr;
   }
 
-  if (!AppendIetfConnectionIds(true, EmptyQuicConnectionId(), connection_id,
-                               &writer)) {
+  if (!AppendIetfConnectionIds(true, EmptyQuicConnectionId(),
+                               source_connection_id, &writer)) {
     return nullptr;
   }
 
@@ -2064,14 +2064,14 @@
     public_flags |= PACKET_PUBLIC_FLAGS_NONCE;
   }
 
-  QuicConnectionId connection_id =
+  QuicConnectionId server_connection_id =
       GetServerConnectionIdAsSender(header, perspective_);
-  QuicConnectionIdIncluded connection_id_included =
+  QuicConnectionIdIncluded server_connection_id_included =
       GetServerConnectionIdIncludedAsSender(header, perspective_);
   DCHECK_EQ(CONNECTION_ID_ABSENT,
             GetClientConnectionIdIncludedAsSender(header, perspective_));
 
-  switch (connection_id_included) {
+  switch (server_connection_id_included) {
     case CONNECTION_ID_ABSENT:
       if (!writer->WriteUInt8(public_flags |
                               PACKET_PUBLIC_FLAGS_0BYTE_CONNECTION_ID)) {
@@ -2080,9 +2080,9 @@
       break;
     case CONNECTION_ID_PRESENT:
       QUIC_BUG_IF(!QuicUtils::IsConnectionIdValidForVersion(
-          connection_id, transport_version()))
+          server_connection_id, transport_version()))
           << "AppendPacketHeader: attempted to use connection ID "
-          << connection_id << " which is invalid with version "
+          << server_connection_id << " which is invalid with version "
           << QuicVersionToString(transport_version());
 
       public_flags |= PACKET_PUBLIC_FLAGS_8BYTE_CONNECTION_ID;
@@ -2090,12 +2090,12 @@
         public_flags |= PACKET_PUBLIC_FLAGS_8BYTE_CONNECTION_ID_OLD;
       }
       if (!writer->WriteUInt8(public_flags) ||
-          !writer->WriteConnectionId(connection_id)) {
+          !writer->WriteConnectionId(server_connection_id)) {
         return false;
       }
       break;
   }
-  last_serialized_connection_id_ = connection_id;
+  last_serialized_server_connection_id_ = server_connection_id;
 
   if (header.version_flag) {
     DCHECK_EQ(Perspective::IS_CLIENT, perspective_);
@@ -2194,7 +2194,7 @@
     return false;
   }
 
-  last_serialized_connection_id_ = server_connection_id;
+  last_serialized_server_connection_id_ = server_connection_id;
 
   if (QuicVersionHasLongHeaderLengths(transport_version()) &&
       header.version_flag) {
@@ -2336,7 +2336,7 @@
       break;
     case PACKET_PUBLIC_FLAGS_0BYTE_CONNECTION_ID:
       *header_connection_id_included = CONNECTION_ID_ABSENT;
-      *header_connection_id = last_serialized_connection_id_;
+      *header_connection_id = last_serialized_server_connection_id_;
       break;
   }
 
@@ -2709,13 +2709,13 @@
       header->destination_connection_id = header->source_connection_id;
     } else if (header->destination_connection_id_included ==
                CONNECTION_ID_ABSENT) {
-      header->destination_connection_id = last_serialized_connection_id_;
+      header->destination_connection_id = last_serialized_server_connection_id_;
     }
   } else {
     QUIC_RESTART_FLAG_COUNT_N(quic_do_not_override_connection_id, 5, 5);
     if (header->source_connection_id_included == CONNECTION_ID_ABSENT) {
       DCHECK_EQ(EmptyQuicConnectionId(), header->source_connection_id);
-      header->source_connection_id = last_serialized_connection_id_;
+      header->source_connection_id = last_serialized_server_connection_id_;
     }
   }