commit 6aefa0b886864cc9e3a4af2b885133aeab693f48
author ianswett <ianswett@google.com> Tue Dec 10 07:26:15 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Dec 10 07:26:47 2019 -0800
tree 7d7fae9f2e71fa7e08a7d7cfd7c867dfc8d2dd71
parent c1f530ddd1481bea390e9ca23dc4165d231ff9aa

Stop using "delete connection()" in QuicSession classes and use DeleteConnection() instead, which prevents double deletion and sets connection_ to nullptr.

gfe-relnote: n/a (Set deleted pointer to nullptr)
PiperOrigin-RevId: 284764494
Change-Id: I6d7f36768e14f06b9cd8267ac74d22d189463579

quic/core/quic_session_test.cc

diff --git a/quic/core/quic_session_test.cc b/quic/core/quic_session_test.cc
index 4603d6c..5c04379 100644
--- a/quic/core/quic_session_test.cc
+++ b/quic/core/quic_session_test.cc
@@ -170,9 +170,7 @@
         std::make_unique<NullEncrypter>(connection->perspective()));
   }
 
-  ~TestSession() override {
-    delete connection();
-  }
+  ~TestSession() override { DeleteConnection(); }
 
   TestCryptoStream* GetMutableCryptoStream() override {
     return &crypto_stream_;