commit 66dea072431f94095dfc3dd2743cb94ef365f7ef
author dschinazi <dschinazi@google.com> Tue Apr 09 11:41:06 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 09 11:41:41 2019 -0700
tree 36a88508e0fecf465a4e6eedff451918070394e0
parent 306b53faffacc0f0f93fdf0279a00196a529a13c

Rename quic::kMaxPacketSize to quic::kMaxOutgoingPacketSize

As part of cl/242197597, QUIC now has separate values for maximum incoming and outgoing packet sizes. This CL renames the constant to be clearer.

gfe-relnote: constant rename, no functional impact
PiperOrigin-RevId: 242708648
Change-Id: I3f440ba44b9c12394026116aaecdd2c166cc63b6

quic/core/http/end_to_end_test.cc

diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc
index 6935dee..753b951 100644
--- a/quic/core/http/end_to_end_test.cc
+++ b/quic/core/http/end_to_end_test.cc
@@ -918,7 +918,7 @@
 TEST_P(EndToEndTestWithTls, RequestOverMultiplePackets) {
   // Send a large enough request to guarantee fragmentation.
   std::string huge_request =
-      "/some/path?query=" + std::string(kMaxPacketSize, '.');
+      "/some/path?query=" + std::string(kMaxOutgoingPacketSize, '.');
   AddToCache(huge_request, 200, kBarResponseBody);
 
   ASSERT_TRUE(Initialize());
@@ -930,7 +930,7 @@
 TEST_P(EndToEndTestWithTls, MultiplePacketsRandomOrder) {
   // Send a large enough request to guarantee fragmentation.
   std::string huge_request =
-      "/some/path?query=" + std::string(kMaxPacketSize, '.');
+      "/some/path?query=" + std::string(kMaxOutgoingPacketSize, '.');
   AddToCache(huge_request, 200, kBarResponseBody);
 
   ASSERT_TRUE(Initialize());
@@ -1426,7 +1426,7 @@
   ASSERT_TRUE(Initialize());
   EXPECT_TRUE(client_->client()->WaitForCryptoHandshakeConfirmed());
 
-  std::string body(kMaxPacketSize, 'a');
+  std::string body(kMaxOutgoingPacketSize, 'a');
   SpdyHeaderBlock headers;
   headers[":method"] = "POST";
   headers[":path"] = "/foo";
@@ -1450,7 +1450,7 @@
   ASSERT_TRUE(Initialize());
   EXPECT_TRUE(client_->client()->WaitForCryptoHandshakeConfirmed());
 
-  std::string body(kMaxPacketSize, 'a');
+  std::string body(kMaxOutgoingPacketSize, 'a');
   SpdyHeaderBlock headers;
   headers[":method"] = "POST";
   headers[":path"] = "/foo";
@@ -2267,7 +2267,7 @@
   // Test the AckNotifier's ability to track multiple packets by making the
   // request body exceed the size of a single packet.
   std::string request_string = "a request body bigger than one packet" +
-                               std::string(kMaxPacketSize, '.');
+                               std::string(kMaxOutgoingPacketSize, '.');
 
   // The TestAckListener will cause a failure if not notified.
   QuicReferenceCountedPointer<TestAckListener> ack_listener(
@@ -2802,7 +2802,7 @@
   // update.  This allows headers processing to trigger the error response
   // before the request FIN is processed but receive the request FIN before the
   // response is sent completely.
-  const uint32_t kRequestBodySize = kMaxPacketSize + 10;
+  const uint32_t kRequestBodySize = kMaxOutgoingPacketSize + 10;
   std::string request_body(kRequestBodySize, 'a');
 
   // Send the request.
@@ -3552,10 +3552,11 @@
   }
 
   SetPacketLossPercentage(30);
-  ASSERT_GT(kMaxPacketSize, client_session->GetCurrentLargestMessagePayload());
+  ASSERT_GT(kMaxOutgoingPacketSize,
+            client_session->GetCurrentLargestMessagePayload());
   ASSERT_LT(0, client_session->GetCurrentLargestMessagePayload());
 
-  std::string message_string(kMaxPacketSize, 'a');
+  std::string message_string(kMaxOutgoingPacketSize, 'a');
   QuicStringPiece message_buffer(message_string);
   QuicRandom* random =
       QuicConnectionPeer::GetHelper(client_connection)->GetRandomGenerator();