gfe-relnote: Move QuicCryptoServerStream::Helper::GenerateConnectionIdForReject to QuicDispatcher::GenerateNewServerConnectionId. Refactor only.
This function used to be related to reject, but now it is only used to generate server connection ids when the incoming id length is unexpected by the dispatcher.
PiperOrigin-RevId: 263843315
Change-Id: I5405ad8e5712ced51c8090be6a99aff396f5ab32
diff --git a/quic/quartc/quartc_crypto_helpers.cc b/quic/quartc/quartc_crypto_helpers.cc
index 1446ab3..4f39271 100644
--- a/quic/quartc/quartc_crypto_helpers.cc
+++ b/quic/quartc/quartc_crypto_helpers.cc
@@ -72,14 +72,6 @@
return nullptr;
}
-QuicConnectionId QuartcCryptoServerStreamHelper::GenerateConnectionIdForReject(
- QuicTransportVersion /*version*/,
- QuicConnectionId /*connection_id*/) const {
- // TODO(b/124399417): Request a zero-length connection id here when the QUIC
- // server perspective supports it.
- return QuicUtils::CreateRandomConnectionId();
-}
-
bool QuartcCryptoServerStreamHelper::CanAcceptClientHello(
const CryptoHandshakeMessage& /*message*/,
const QuicSocketAddress& /*client_address*/,
diff --git a/quic/quartc/quartc_crypto_helpers.h b/quic/quartc/quartc_crypto_helpers.h
index 1436aeb..cdf14a0 100644
--- a/quic/quartc/quartc_crypto_helpers.h
+++ b/quic/quartc/quartc_crypto_helpers.h
@@ -101,10 +101,6 @@
// Implementation of the server-side crypto stream helper.
class QuartcCryptoServerStreamHelper : public QuicCryptoServerStream::Helper {
public:
- QuicConnectionId GenerateConnectionIdForReject(
- QuicTransportVersion version,
- QuicConnectionId connection_id) const override;
-
bool CanAcceptClientHello(const CryptoHandshakeMessage& message,
const QuicSocketAddress& client_address,
const QuicSocketAddress& peer_address,
diff --git a/quic/quartc/quartc_dispatcher.h b/quic/quartc/quartc_dispatcher.h
index d1128d6..06e799e 100644
--- a/quic/quartc/quartc_dispatcher.h
+++ b/quic/quartc/quartc_dispatcher.h
@@ -45,6 +45,9 @@
QuicStringPiece alpn,
const ParsedQuicVersion& version) override;
+ // TODO(b/124399417): Override GenerateNewServerConnectionId and request a
+ // zero-length connection id when the QUIC server perspective supports it.
+
// QuartcPacketTransport::Delegate overrides.
void OnTransportCanWrite() override;
void OnTransportReceived(const char* data, size_t data_len) override;
