commit 5d92c4114bd0fc474b7e95536c303b8e717a2782
author fayang <fayang@google.com> Wed Feb 19 12:10:31 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Feb 19 12:10:59 2020 -0800
tree 0cb7e73e9f7a03536fe008918870ef5fdb74777f
parent 7c89615d6dd74bbb019f2d5413528baef363cec4

gfe-relnote: Add an IsAckFrameEmpty const method to received_packet_manager and make sure GetUpdatedAckFrame is only called to retrieve nonempty ACK frame. Refactoring only, not protected.

PiperOrigin-RevId: 296026015
Change-Id: I41976873d68db37b5c276befd3330c9cbda00108

quic/core/uber_received_packet_manager_test.cc

diff --git a/quic/core/uber_received_packet_manager_test.cc b/quic/core/uber_received_packet_manager_test.cc
index b1e7140..a2fb640 100644
--- a/quic/core/uber_received_packet_manager_test.cc
+++ b/quic/core/uber_received_packet_manager_test.cc
@@ -134,7 +134,9 @@
 };
 
 TEST_F(UberReceivedPacketManagerTest, DontWaitForPacketsBefore) {
+  EXPECT_TRUE(manager_->IsAckFrameEmpty(APPLICATION_DATA));
   RecordPacketReceipt(2);
+  EXPECT_FALSE(manager_->IsAckFrameEmpty(APPLICATION_DATA));
   RecordPacketReceipt(7);
   EXPECT_TRUE(manager_->IsAwaitingPacket(ENCRYPTION_FORWARD_SECURE,
                                          QuicPacketNumber(3u)));