Remove QuicSession::RegisterStaticStream() and merge it into
QuicSession::ActivateStream().
As static_stream_map_ has been removed, static streams are getting less and
less distinct from normal streams. And now after preventing
v99_stream_id_manager from knowing about stream staticness, static streams are
all the same as dynamic streams only to be different in is_static_ field.
So I think it'd be a nice cleanup to have only one method.
gfe-relnote: code refactoring. No behavior change.
PiperOrigin-RevId: 267652775
Change-Id: I27137a225c69c0a41c644d473d59e7a4c3c64359
diff --git a/quic/core/quic_session.h b/quic/core/quic_session.h
index 1f03a40..96633d8 100644
--- a/quic/core/quic_session.h
+++ b/quic/core/quic_session.h
@@ -547,12 +547,6 @@
// ProcessPendingStream().
virtual bool UsesPendingStreams() const { return false; }
- // Transfer ownership of |stream| to stream_map_, and register
- // |stream| as static in stream id manager. |stream_already_counted| is true
- // if |stream| is created from pending stream and is already known as an open
- // stream.
- void RegisterStaticStream(std::unique_ptr<QuicStream> stream);
-
StreamMap& stream_map() { return stream_map_; }
const StreamMap& stream_map() const { return stream_map_; }
@@ -581,7 +575,7 @@
// Returns true if the stream is a static stream.
bool IsStaticStream(QuicStreamId id) const;
- // Close connection when receive a frame for a locally-created nonexistant
+ // Close connection when receive a frame for a locally-created nonexistent
// stream.
// Prerequisite: IsClosedStream(stream_id) == false
// Server session might need to override this method to allow server push