commit 591814c31c58f49b3243e722c23b35e7bc0d40ed
author fkastenholz <fkastenholz@google.com> Fri Sep 06 12:11:46 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Sep 06 12:44:12 2019 -0700
tree 6ec34b847a88e794c9054f835d7653528c3366de
parent d1d0085ee4806a673bfb7635a1e938d6542108b5

Add version-aware QuicConnectionCloseFrame constructor

Adds a version-aware constructor for QuicConnectionCloseFrames. Based
on the version, this constructor handles generation of the correct
close codes and frame types.

gfe-relnote: N/A moves around existing function (some version-99 protected)
PiperOrigin-RevId: 267647428
Change-Id: I24aabc9abc1b803610b34d9f8fac60133bd1368c

quic/core/quic_packet_creator_test.cc

diff --git a/quic/core/quic_packet_creator_test.cc b/quic/core/quic_packet_creator_test.cc
index ff9960f..1da89ba 100644
--- a/quic/core/quic_packet_creator_test.cc
+++ b/quic/core/quic_packet_creator_test.cc
@@ -576,10 +576,9 @@
 }
 
 TEST_P(QuicPacketCreatorTest, SerializeConnectionClose) {
-  QuicConnectionCloseFrame frame(QUIC_NO_ERROR, "error");
-  if (VersionHasIetfQuicFrames(GetParam().version.transport_version)) {
-    frame.close_type = IETF_QUIC_TRANSPORT_CONNECTION_CLOSE;
-  }
+  QuicConnectionCloseFrame frame(GetParam().version.transport_version,
+                                 QUIC_NO_ERROR, "error",
+                                 /*transport_close_frame_type=*/0);
 
   QuicFrames frames;
   frames.push_back(QuicFrame(&frame));