commit 55e2bd3016b385257c3d51f08d1c802e3dff3814
author dschinazi <dschinazi@google.com> Tue Mar 10 15:32:10 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 10 15:32:40 2020 -0700
tree 08a29df061b09faa0f402fc9c0b2e3ffb51a5ee4
parent 4f6ba16cf16505f12dc8d2f23cfc6e13c1aa5806

Remove incorrect QUIC_BUG in QUIC transport parameters

Our transport parameter code has QUIC_BUGs for write errors (which should never happen) and returns false without a QUIC_BUG for read errors, as they can be caused by receiving invalid input over the network. This CL fixes an oversight where we accidentally had a QUIC_BUG on the receive path. This issue was found by clusterfuzz <https://crbug.com/1059103>.

gfe-relnote: n/a, remove incorrect QUIC_BUG, no behavior change, protected by TLS flags
PiperOrigin-RevId: 300192023
Change-Id: If34864e534ec68cb9ecd88c10870f0677faff60c

quic/core/crypto/transport_parameters.cc

diff --git a/quic/core/crypto/transport_parameters.cc b/quic/core/crypto/transport_parameters.cc
index 9ca7915..eacc28e 100644
--- a/quic/core/crypto/transport_parameters.cc
+++ b/quic/core/crypto/transport_parameters.cc
@@ -163,7 +163,6 @@
   if (version.HasVarIntTransportParams()) {
     uint64_t param_id64;
     if (!reader->ReadVarInt62(&param_id64)) {
-      QUIC_BUG << "Failed to read param_id";
       return false;
     }
     *out_param_id =
@@ -171,7 +170,6 @@
   } else {
     uint16_t param_id16;
     if (!reader->ReadUInt16(&param_id16)) {
-      QUIC_BUG << "Failed to read param_id16";
       return false;
     }
     *out_param_id =