Remove incorrect QUIC_BUG in QUIC transport parameters Our transport parameter code has QUIC_BUGs for write errors (which should never happen) and returns false without a QUIC_BUG for read errors, as they can be caused by receiving invalid input over the network. This CL fixes an oversight where we accidentally had a QUIC_BUG on the receive path. This issue was found by clusterfuzz <https://crbug.com/1059103>. gfe-relnote: n/a, remove incorrect QUIC_BUG, no behavior change, protected by TLS flags PiperOrigin-RevId: 300192023 Change-Id: If34864e534ec68cb9ecd88c10870f0677faff60c
diff --git a/quic/core/crypto/transport_parameters.cc b/quic/core/crypto/transport_parameters.cc index 9ca7915..eacc28e 100644 --- a/quic/core/crypto/transport_parameters.cc +++ b/quic/core/crypto/transport_parameters.cc
@@ -163,7 +163,6 @@ if (version.HasVarIntTransportParams()) { uint64_t param_id64; if (!reader->ReadVarInt62(¶m_id64)) { - QUIC_BUG << "Failed to read param_id"; return false; } *out_param_id = @@ -171,7 +170,6 @@ } else { uint16_t param_id16; if (!reader->ReadUInt16(¶m_id16)) { - QUIC_BUG << "Failed to read param_id16"; return false; } *out_param_id =