commit 55bc295d9b967ba74621762a2735a098a98db418
author dschinazi <dschinazi@google.com> Wed Mar 11 14:17:32 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Mar 11 14:18:15 2020 -0700
tree a72a9506fefb0527704c98dd2b2e2a92bc1ef78e
parent afcd5aef45baad362056cbda872838b7c0cf1bf0

Enable additional warning

This CL enables -Wtautological-constant-out-of-range-compare in QUIC as that caused a merge failure inEnvoy.

gfe-relnote: n/a, add warning
PiperOrigin-RevId: 300404951
Change-Id: I74050bb1816b6fc64fd7338d623e9f47ff6def91

quic/core/crypto/transport_parameters.cc

diff --git a/quic/core/crypto/transport_parameters.cc b/quic/core/crypto/transport_parameters.cc
index eacc28e..4cefcdd 100644
--- a/quic/core/crypto/transport_parameters.cc
+++ b/quic/core/crypto/transport_parameters.cc
@@ -118,7 +118,8 @@
       return false;
     }
   } else {
-    if (param_id > std::numeric_limits<uint16_t>::max()) {
+    if (static_cast<uint64_t>(param_id) >
+        std::numeric_limits<uint16_t>::max()) {
       QUIC_BUG << "Cannot serialize transport parameter "
                << TransportParameterIdToString(param_id) << " with version "
                << version;