gfe-relnote: Deprecate gfe2_reloadable_flag_quic_terminate_gquic_connection_as_ietf. PiperOrigin-RevId: 254749659 Change-Id: Ia6162d26c156058f597247e7a633f7d881019834
diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc index 96b7ee3..96e5aef 100644 --- a/quic/core/http/end_to_end_test.cc +++ b/quic/core/http/end_to_end_test.cc
@@ -3381,16 +3381,7 @@ client_.reset(CreateQuicClient(client_writer_)); EXPECT_EQ("", client_->SendSynchronousRequest("/foo")); - - if (VersionHasIetfInvariantHeader(client_->client() - ->client_session() - ->connection() - ->transport_version()) || - GetQuicReloadableFlag(quic_terminate_gquic_connection_as_ietf)) { - EXPECT_EQ(QUIC_HANDSHAKE_FAILED, client_->connection_error()); - } else { - EXPECT_EQ(QUIC_PUBLIC_RESET, client_->connection_error()); - } + EXPECT_EQ(QUIC_HANDSHAKE_FAILED, client_->connection_error()); } // Regression test for b/116200989.
diff --git a/quic/core/quic_dispatcher.cc b/quic/core/quic_dispatcher.cc index f6fa002..da18b03 100644 --- a/quic/core/quic_dispatcher.cc +++ b/quic/core/quic_dispatcher.cc
@@ -497,8 +497,7 @@ if (connection->termination_packets() != nullptr && !connection->termination_packets()->empty()) { action = QuicTimeWaitListManager::SEND_TERMINATION_PACKETS; - } else if (VersionHasIetfInvariantHeader(connection->transport_version()) || - GetQuicReloadableFlag(quic_terminate_gquic_connection_as_ietf)) { + } else { if (!connection->IsHandshakeConfirmed()) { if (!VersionHasIetfInvariantHeader(connection->transport_version())) { QUIC_CODE_COUNT(gquic_add_to_time_wait_list_with_handshake_failed); @@ -661,9 +660,7 @@ QuicErrorCode error_code, const std::string& error_details, QuicTimeWaitListManager::TimeWaitAction action) { - if (format != IETF_QUIC_LONG_HEADER_PACKET && - (!GetQuicReloadableFlag(quic_terminate_gquic_connection_as_ietf) || - !version_flag)) { + if (format != IETF_QUIC_LONG_HEADER_PACKET && !version_flag) { QUIC_DVLOG(1) << "Statelessly terminating " << server_connection_id << " based on a non-ietf-long packet, action:" << action << ", error_code:" << error_code @@ -686,10 +683,6 @@ helper_.get(), time_wait_list_manager_.get()); // This also adds the connection to time wait list. - if (format == GOOGLE_QUIC_PACKET) { - QUIC_RELOADABLE_FLAG_COUNT_N(quic_terminate_gquic_connection_as_ietf, 1, - 2); - } terminator.CloseConnection(error_code, error_details, format != GOOGLE_QUIC_PACKET); return; @@ -707,9 +700,6 @@ server_connection_id, EmptyQuicConnectionId(), /*ietf_quic=*/format != GOOGLE_QUIC_PACKET, ParsedQuicVersionVector{QuicVersionReservedForNegotiation()})); - if (format == GOOGLE_QUIC_PACKET) { - QUIC_RELOADABLE_FLAG_COUNT_N(quic_terminate_gquic_connection_as_ietf, 2, 2); - } time_wait_list_manager()->AddConnectionIdToTimeWait( server_connection_id, /*ietf_quic=*/format != GOOGLE_QUIC_PACKET, QuicTimeWaitListManager::SEND_TERMINATION_PACKETS, ENCRYPTION_INITIAL,