Remove QUIC_ARRAYSIZE; use QUICHE_ARRAYSIZE instead. gfe-relnote: n/a, no functional change. PiperOrigin-RevId: 285973186 Change-Id: I271125e024eca41ec02c6ba7701d5b5ae677da0b
diff --git a/quic/core/chlo_extractor_test.cc b/quic/core/chlo_extractor_test.cc index d556f7a..e293902 100644 --- a/quic/core/chlo_extractor_test.cc +++ b/quic/core/chlo_extractor_test.cc
@@ -10,10 +10,10 @@ #include "net/third_party/quiche/src/quic/core/quic_framer.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -90,7 +90,7 @@ EXPECT_TRUE(packet != nullptr); size_t encrypted_length = framer.EncryptPayload(ENCRYPTION_INITIAL, header_.packet_number, - *packet, buffer_, QUIC_ARRAYSIZE(buffer_)); + *packet, buffer_, QUICHE_ARRAYSIZE(buffer_)); ASSERT_NE(0u, encrypted_length); packet_ = std::make_unique<QuicEncryptedPacket>(buffer_, encrypted_length); EXPECT_TRUE(packet_ != nullptr);
diff --git a/quic/core/crypto/aead_base_decrypter.cc b/quic/core/crypto/aead_base_decrypter.cc index baaf6ce..f3be16e 100644 --- a/quic/core/crypto/aead_base_decrypter.cc +++ b/quic/core/crypto/aead_base_decrypter.cc
@@ -11,9 +11,9 @@ #include "third_party/boringssl/src/include/openssl/err.h" #include "third_party/boringssl/src/include/openssl/evp.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -34,7 +34,7 @@ #else while (uint32_t error = ERR_get_error()) { char buf[120]; - ERR_error_string_n(error, buf, QUIC_ARRAYSIZE(buf)); + ERR_error_string_n(error, buf, QUICHE_ARRAYSIZE(buf)); QUIC_DLOG(ERROR) << "OpenSSL error: " << buf; } #endif
diff --git a/quic/core/crypto/aead_base_encrypter.cc b/quic/core/crypto/aead_base_encrypter.cc index b794e7e..14aca26 100644 --- a/quic/core/crypto/aead_base_encrypter.cc +++ b/quic/core/crypto/aead_base_encrypter.cc
@@ -9,9 +9,9 @@ #include "third_party/boringssl/src/include/openssl/evp.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_aligned.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -27,7 +27,7 @@ #else while (unsigned long error = ERR_get_error()) { char buf[120]; - ERR_error_string_n(error, buf, QUIC_ARRAYSIZE(buf)); + ERR_error_string_n(error, buf, QUICHE_ARRAYSIZE(buf)); QUIC_DLOG(ERROR) << "OpenSSL error: " << buf; } #endif
diff --git a/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc b/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc index 130ebd0..cfd6812 100644 --- a/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc +++ b/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc
@@ -8,9 +8,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -224,7 +224,7 @@ class Aes128Gcm12DecrypterTest : public QuicTest {}; TEST_F(Aes128Gcm12DecrypterTest, Decrypt) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_group_array); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_group_array); i++) { SCOPED_TRACE(i); const TestVector* test_vectors = test_group_array[i]; const TestGroupInfo& test_info = test_group_info[i];
diff --git a/quic/core/crypto/aes_128_gcm_12_encrypter_test.cc b/quic/core/crypto/aes_128_gcm_12_encrypter_test.cc index 0ca6b18..3241b07 100644 --- a/quic/core/crypto/aes_128_gcm_12_encrypter_test.cc +++ b/quic/core/crypto/aes_128_gcm_12_encrypter_test.cc
@@ -8,9 +8,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -176,7 +176,7 @@ class Aes128Gcm12EncrypterTest : public QuicTest {}; TEST_F(Aes128Gcm12EncrypterTest, Encrypt) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_group_array); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_group_array); i++) { SCOPED_TRACE(i); const TestVector* test_vectors = test_group_array[i]; const TestGroupInfo& test_info = test_group_info[i];
diff --git a/quic/core/crypto/aes_128_gcm_decrypter_test.cc b/quic/core/crypto/aes_128_gcm_decrypter_test.cc index 3b6ad4d..5b9aa5c 100644 --- a/quic/core/crypto/aes_128_gcm_decrypter_test.cc +++ b/quic/core/crypto/aes_128_gcm_decrypter_test.cc
@@ -8,9 +8,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" namespace { @@ -218,7 +218,7 @@ class Aes128GcmDecrypterTest : public QuicTest {}; TEST_F(Aes128GcmDecrypterTest, Decrypt) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_group_array); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_group_array); i++) { SCOPED_TRACE(i); const TestVector* test_vectors = test_group_array[i]; const TestGroupInfo& test_info = test_group_info[i];
diff --git a/quic/core/crypto/aes_128_gcm_encrypter_test.cc b/quic/core/crypto/aes_128_gcm_encrypter_test.cc index 8e48bfd..1fa8a47 100644 --- a/quic/core/crypto/aes_128_gcm_encrypter_test.cc +++ b/quic/core/crypto/aes_128_gcm_encrypter_test.cc
@@ -8,9 +8,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" namespace { @@ -175,7 +175,7 @@ class Aes128GcmEncrypterTest : public QuicTest {}; TEST_F(Aes128GcmEncrypterTest, Encrypt) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_group_array); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_group_array); i++) { SCOPED_TRACE(i); const TestVector* test_vectors = test_group_array[i]; const TestGroupInfo& test_info = test_group_info[i];
diff --git a/quic/core/crypto/aes_256_gcm_decrypter_test.cc b/quic/core/crypto/aes_256_gcm_decrypter_test.cc index f59a532..abd2651 100644 --- a/quic/core/crypto/aes_256_gcm_decrypter_test.cc +++ b/quic/core/crypto/aes_256_gcm_decrypter_test.cc
@@ -8,9 +8,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -223,7 +223,7 @@ class Aes256GcmDecrypterTest : public QuicTest {}; TEST_F(Aes256GcmDecrypterTest, Decrypt) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_group_array); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_group_array); i++) { SCOPED_TRACE(i); const TestVector* test_vectors = test_group_array[i]; const TestGroupInfo& test_info = test_group_info[i];
diff --git a/quic/core/crypto/aes_256_gcm_encrypter_test.cc b/quic/core/crypto/aes_256_gcm_encrypter_test.cc index 5136424..16c96e2 100644 --- a/quic/core/crypto/aes_256_gcm_encrypter_test.cc +++ b/quic/core/crypto/aes_256_gcm_encrypter_test.cc
@@ -8,9 +8,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -183,7 +183,7 @@ class Aes256GcmEncrypterTest : public QuicTest {}; TEST_F(Aes256GcmEncrypterTest, Encrypt) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_group_array); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_group_array); i++) { SCOPED_TRACE(i); const TestVector* test_vectors = test_group_array[i]; const TestGroupInfo& test_info = test_group_info[i];
diff --git a/quic/core/crypto/chacha20_poly1305_encrypter_test.cc b/quic/core/crypto/chacha20_poly1305_encrypter_test.cc index edb81a4..a15fbc5 100644 --- a/quic/core/crypto/chacha20_poly1305_encrypter_test.cc +++ b/quic/core/crypto/chacha20_poly1305_encrypter_test.cc
@@ -9,9 +9,9 @@ #include "net/third_party/quiche/src/quic/core/crypto/chacha20_poly1305_decrypter.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -104,12 +104,12 @@ size_t len; ASSERT_TRUE(encrypter.EncryptPacket(packet_number, associated_data, plaintext, encrypted, &len, - QUIC_ARRAYSIZE(encrypted))); + QUICHE_ARRAYSIZE(encrypted))); quiche::QuicheStringPiece ciphertext(encrypted, len); char decrypted[1024]; ASSERT_TRUE(decrypter.DecryptPacket(packet_number, associated_data, ciphertext, decrypted, &len, - QUIC_ARRAYSIZE(decrypted))); + QUICHE_ARRAYSIZE(decrypted))); } TEST_F(ChaCha20Poly1305EncrypterTest, Encrypt) {
diff --git a/quic/core/crypto/chacha20_poly1305_tls_encrypter_test.cc b/quic/core/crypto/chacha20_poly1305_tls_encrypter_test.cc index a62c843..628ecc8 100644 --- a/quic/core/crypto/chacha20_poly1305_tls_encrypter_test.cc +++ b/quic/core/crypto/chacha20_poly1305_tls_encrypter_test.cc
@@ -9,9 +9,9 @@ #include "net/third_party/quiche/src/quic/core/crypto/chacha20_poly1305_tls_decrypter.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -104,12 +104,12 @@ size_t len; ASSERT_TRUE(encrypter.EncryptPacket(packet_number, associated_data, plaintext, encrypted, &len, - QUIC_ARRAYSIZE(encrypted))); + QUICHE_ARRAYSIZE(encrypted))); quiche::QuicheStringPiece ciphertext(encrypted, len); char decrypted[1024]; ASSERT_TRUE(decrypter.DecryptPacket(packet_number, associated_data, ciphertext, decrypted, &len, - QUIC_ARRAYSIZE(decrypted))); + QUICHE_ARRAYSIZE(decrypted))); } TEST_F(ChaCha20Poly1305TlsEncrypterTest, Encrypt) {
diff --git a/quic/core/crypto/chacha_base_decrypter.cc b/quic/core/crypto/chacha_base_decrypter.cc index d7a4984..bc09b66 100644 --- a/quic/core/crypto/chacha_base_decrypter.cc +++ b/quic/core/crypto/chacha_base_decrypter.cc
@@ -8,8 +8,8 @@ #include "third_party/boringssl/src/include/openssl/chacha.h" #include "net/third_party/quiche/src/quic/core/quic_data_reader.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -36,9 +36,9 @@ QuicDataReader(sample.data(), 4, quiche::HOST_BYTE_ORDER) .ReadUInt32(&counter); const uint8_t zeroes[] = {0, 0, 0, 0, 0}; - std::string out(QUIC_ARRAYSIZE(zeroes), 0); + std::string out(QUICHE_ARRAYSIZE(zeroes), 0); CRYPTO_chacha_20(reinterpret_cast<uint8_t*>(const_cast<char*>(out.data())), - zeroes, QUIC_ARRAYSIZE(zeroes), pne_key_, nonce, counter); + zeroes, QUICHE_ARRAYSIZE(zeroes), pne_key_, nonce, counter); return out; }
diff --git a/quic/core/crypto/chacha_base_encrypter.cc b/quic/core/crypto/chacha_base_encrypter.cc index 1e0d80f..7fdc019 100644 --- a/quic/core/crypto/chacha_base_encrypter.cc +++ b/quic/core/crypto/chacha_base_encrypter.cc
@@ -6,8 +6,8 @@ #include "third_party/boringssl/src/include/openssl/chacha.h" #include "net/third_party/quiche/src/quic/core/quic_data_reader.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -33,9 +33,9 @@ QuicDataReader(sample.data(), 4, quiche::HOST_BYTE_ORDER) .ReadUInt32(&counter); const uint8_t zeroes[] = {0, 0, 0, 0, 0}; - std::string out(QUIC_ARRAYSIZE(zeroes), 0); + std::string out(QUICHE_ARRAYSIZE(zeroes), 0); CRYPTO_chacha_20(reinterpret_cast<uint8_t*>(const_cast<char*>(out.data())), - zeroes, QUIC_ARRAYSIZE(zeroes), pne_key_, nonce, counter); + zeroes, QUICHE_ARRAYSIZE(zeroes), pne_key_, nonce, counter); return out; }
diff --git a/quic/core/crypto/common_cert_set.cc b/quic/core/crypto/common_cert_set.cc index be4883b..0ccbf2d 100644 --- a/quic/core/crypto/common_cert_set.cc +++ b/quic/core/crypto/common_cert_set.cc
@@ -7,7 +7,7 @@ #include <cstddef> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -82,12 +82,12 @@ quiche::QuicheStringPiece GetCommonHashes() const override { return quiche::QuicheStringPiece( reinterpret_cast<const char*>(kSetHashes), - sizeof(uint64_t) * QUIC_ARRAYSIZE(kSetHashes)); + sizeof(uint64_t) * QUICHE_ARRAYSIZE(kSetHashes)); } quiche::QuicheStringPiece GetCert(uint64_t hash, uint32_t index) const override { - for (size_t i = 0; i < QUIC_ARRAYSIZE(kSets); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kSets); i++) { if (kSets[i].hash == hash) { if (index < kSets[i].num_certs) { return quiche::QuicheStringPiece( @@ -114,7 +114,7 @@ memcpy(&hash, common_set_hashes.data() + i * sizeof(uint64_t), sizeof(uint64_t)); - for (size_t j = 0; j < QUIC_ARRAYSIZE(kSets); j++) { + for (size_t j = 0; j < QUICHE_ARRAYSIZE(kSets); j++) { if (kSets[j].hash != hash) { continue; }
diff --git a/quic/core/crypto/crypto_framer_test.cc b/quic/core/crypto/crypto_framer_test.cc index 8a8787a..fed6b53 100644 --- a/quic/core/crypto/crypto_framer_test.cc +++ b/quic/core/crypto/crypto_framer_test.cc
@@ -11,11 +11,11 @@ #include "net/third_party/quiche/src/quic/core/crypto/crypto_handshake.h" #include "net/third_party/quiche/src/quic/core/crypto/crypto_protocol.h" #include "net/third_party/quiche/src/quic/core/quic_packets.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -84,7 +84,7 @@ ASSERT_TRUE(data != nullptr); test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST(CryptoFramerTest, ConstructHandshakeMessageWithTwoKeys) { @@ -120,7 +120,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST(CryptoFramerTest, ConstructHandshakeMessageZeroLength) { @@ -147,7 +147,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST(CryptoFramerTest, ConstructHandshakeMessageTooManyEntries) { @@ -197,7 +197,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST(CryptoFramerTest, ConstructHandshakeMessageMinimumSizePadLast) { @@ -233,7 +233,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST(CryptoFramerTest, ProcessInput) { @@ -263,7 +263,7 @@ }; EXPECT_TRUE(framer.ProcessInput( - quiche::QuicheStringPiece(AsChars(input), QUIC_ARRAYSIZE(input)))); + quiche::QuicheStringPiece(AsChars(input), QUICHE_ARRAYSIZE(input)))); EXPECT_EQ(0u, framer.InputBytesRemaining()); EXPECT_EQ(0, visitor.error_count_); ASSERT_EQ(1u, visitor.messages_.size()); @@ -307,7 +307,7 @@ }; EXPECT_TRUE(framer.ProcessInput( - quiche::QuicheStringPiece(AsChars(input), QUIC_ARRAYSIZE(input)))); + quiche::QuicheStringPiece(AsChars(input), QUICHE_ARRAYSIZE(input)))); EXPECT_EQ(0u, framer.InputBytesRemaining()); EXPECT_EQ(0, visitor.error_count_); ASSERT_EQ(1u, visitor.messages_.size()); @@ -345,7 +345,7 @@ 'g', 'h', 'i', 'j', 'k', }; - for (size_t i = 0; i < QUIC_ARRAYSIZE(input); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(input); i++) { EXPECT_TRUE( framer.ProcessInput(quiche::QuicheStringPiece(AsChars(input) + i, 1))); } @@ -381,7 +381,7 @@ }; EXPECT_FALSE(framer.ProcessInput( - quiche::QuicheStringPiece(AsChars(input), QUIC_ARRAYSIZE(input)))); + quiche::QuicheStringPiece(AsChars(input), QUICHE_ARRAYSIZE(input)))); EXPECT_THAT(framer.error(), IsError(QUIC_CRYPTO_TAGS_OUT_OF_ORDER)); EXPECT_EQ(1, visitor.error_count_); } @@ -409,7 +409,7 @@ }; EXPECT_FALSE(framer.ProcessInput( - quiche::QuicheStringPiece(AsChars(input), QUIC_ARRAYSIZE(input)))); + quiche::QuicheStringPiece(AsChars(input), QUICHE_ARRAYSIZE(input)))); EXPECT_THAT(framer.error(), IsError(QUIC_CRYPTO_TAGS_OUT_OF_ORDER)); EXPECT_EQ(1, visitor.error_count_); } @@ -429,7 +429,7 @@ }; EXPECT_FALSE(framer.ProcessInput( - quiche::QuicheStringPiece(AsChars(input), QUIC_ARRAYSIZE(input)))); + quiche::QuicheStringPiece(AsChars(input), QUICHE_ARRAYSIZE(input)))); EXPECT_THAT(framer.error(), IsError(QUIC_CRYPTO_TOO_MANY_ENTRIES)); EXPECT_EQ(1, visitor.error_count_); } @@ -457,7 +457,7 @@ }; EXPECT_TRUE(framer.ProcessInput( - quiche::QuicheStringPiece(AsChars(input), QUIC_ARRAYSIZE(input)))); + quiche::QuicheStringPiece(AsChars(input), QUICHE_ARRAYSIZE(input)))); EXPECT_EQ(0, visitor.error_count_); }
diff --git a/quic/core/crypto/crypto_server_test.cc b/quic/core/crypto/crypto_server_test.cc index 9c606a2..922ccc5 100644 --- a/quic/core/crypto/crypto_server_test.cc +++ b/quic/core/crypto/crypto_server_test.cc
@@ -21,7 +21,6 @@ #include "net/third_party/quiche/src/quic/core/proto/crypto_server_config_proto.h" #include "net/third_party/quiche/src/quic/core/quic_socket_address_coder.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" @@ -30,6 +29,7 @@ #include "net/third_party/quiche/src/quic/test_tools/mock_random.h" #include "net/third_party/quiche/src/quic/test_tools/quic_crypto_server_config_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -154,7 +154,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); quiche::QuicheStringPiece srct; ASSERT_TRUE(out_.GetStringPiece(kSourceAddressTokenTag, &srct)); @@ -386,7 +386,7 @@ }; // clang-format on - for (size_t i = 0; i < QUIC_ARRAYSIZE(kBadSNIs); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kBadSNIs); i++) { CryptoHandshakeMessage msg = crypto_test_utils::CreateCHLO({{"PDMD", "X509"}, {"SNI", kBadSNIs[i]}, @@ -395,7 +395,7 @@ ShouldFailMentioning("SNI", msg); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } } @@ -421,7 +421,7 @@ EXPECT_NE(0u, proof.size()); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); EXPECT_LT(0u, cert_sct.size()); } @@ -448,7 +448,7 @@ EXPECT_FALSE(out_.GetStringPiece(kCertificateSCTTag, &cert_sct)); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, RejectNotTooLarge) { @@ -475,7 +475,7 @@ EXPECT_TRUE(out_.GetStringPiece(kCertificateSCTTag, &cert_sct)); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, RejectTooLargeButValidSTK) { @@ -504,7 +504,7 @@ EXPECT_NE(0u, proof.size()); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, TooSmall) { @@ -514,7 +514,7 @@ const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, BadSourceAddressToken) { @@ -528,7 +528,7 @@ }; // clang-format on - for (size_t i = 0; i < QUIC_ARRAYSIZE(kBadSourceAddressTokens); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kBadSourceAddressTokens); i++) { CryptoHandshakeMessage msg = crypto_test_utils::CreateCHLO({{"PDMD", "X509"}, {"STK", kBadSourceAddressTokens[i]}, @@ -537,7 +537,7 @@ ShouldSucceed(msg); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } } @@ -550,7 +550,7 @@ }; // clang-format on - for (size_t i = 0; i < QUIC_ARRAYSIZE(kBadNonces); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kBadNonces); i++) { // Invalid nonces should be ignored, in an inchoate CHLO. CryptoHandshakeMessage msg = @@ -562,7 +562,7 @@ ShouldSucceed(msg); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); // Invalid nonces should result in CLIENT_NONCE_INVALID_FAILURE. CryptoHandshakeMessage msg1 = @@ -583,7 +583,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons1[] = { CLIENT_NONCE_INVALID_FAILURE}; - CheckRejectReasons(kRejectReasons1, QUIC_ARRAYSIZE(kRejectReasons1)); + CheckRejectReasons(kRejectReasons1, QUICHE_ARRAYSIZE(kRejectReasons1)); } } @@ -597,7 +597,7 @@ ShouldSucceed(msg); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); CryptoHandshakeMessage msg1 = crypto_test_utils::CreateCHLO({{"PDMD", "X509"}, @@ -614,7 +614,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons1[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons1, QUIC_ARRAYSIZE(kRejectReasons1)); + CheckRejectReasons(kRejectReasons1, QUICHE_ARRAYSIZE(kRejectReasons1)); } TEST_P(CryptoServerTest, DowngradeAttack) { @@ -633,7 +633,7 @@ ShouldFailMentioning("Downgrade", msg); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, CorruptServerConfig) { @@ -653,7 +653,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_UNKNOWN_CONFIG_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, CorruptSourceAddressToken) { @@ -674,7 +674,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons[] = { SOURCE_ADDRESS_TOKEN_DECRYPTION_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, CorruptSourceAddressTokenIsStillAccepted) { @@ -715,7 +715,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons[] = { SOURCE_ADDRESS_TOKEN_DECRYPTION_FAILURE, CLIENT_NONCE_INVALID_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, CorruptMultipleTags) { @@ -739,7 +739,7 @@ const HandshakeFailureReason kRejectReasons[] = { SOURCE_ADDRESS_TOKEN_DECRYPTION_FAILURE, CLIENT_NONCE_INVALID_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, NoServerNonce) { @@ -788,7 +788,7 @@ CheckRejectTag(); const HandshakeFailureReason kRejectReasons[] = { SOURCE_ADDRESS_TOKEN_DIFFERENT_IP_ADDRESS_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); quiche::QuicheStringPiece cert, proof, scfg_str; EXPECT_TRUE(out_.GetStringPiece(kCertificateTag, &cert)); @@ -850,7 +850,7 @@ const HandshakeFailureReason kRejectReasons[] = { INVALID_EXPECTED_LEAF_CERTIFICATE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } TEST_P(CryptoServerTest, ValidXlct) { @@ -1065,7 +1065,7 @@ const HandshakeFailureReason kRejectReasons[] = { SERVER_CONFIG_INCHOATE_HELLO_FAILURE}; - CheckRejectReasons(kRejectReasons, QUIC_ARRAYSIZE(kRejectReasons)); + CheckRejectReasons(kRejectReasons, QUICHE_ARRAYSIZE(kRejectReasons)); } class CryptoServerTestOldVersion : public CryptoServerTest {
diff --git a/quic/core/crypto/crypto_utils.cc b/quic/core/crypto/crypto_utils.cc index 47da4c1..dc586df 100644 --- a/quic/core/crypto/crypto_utils.cc +++ b/quic/core/crypto/crypto_utils.cc
@@ -26,9 +26,9 @@ #include "net/third_party/quiche/src/quic/core/quic_data_writer.h" #include "net/third_party/quiche/src/quic/core/quic_time.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -70,7 +70,7 @@ !CBB_add_u8_length_prefixed(quic_hkdf_label.get(), &inner_label) || !CBB_add_bytes(&inner_label, reinterpret_cast<const uint8_t*>(label_prefix), - QUIC_ARRAYSIZE(label_prefix) - 1) || + QUICHE_ARRAYSIZE(label_prefix) - 1) || !CBB_add_bytes(&inner_label, reinterpret_cast<const uint8_t*>(label.data()), label.size()) || @@ -135,23 +135,23 @@ const uint8_t* InitialSaltForVersion(const ParsedQuicVersion& version, size_t* out_len) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync with initial encryption salts"); switch (version.handshake_protocol) { case PROTOCOL_QUIC_CRYPTO: switch (version.transport_version) { case QUIC_VERSION_50: - *out_len = QUIC_ARRAYSIZE(kQ050Salt); + *out_len = QUICHE_ARRAYSIZE(kQ050Salt); return kQ050Salt; case QUIC_VERSION_99: - *out_len = QUIC_ARRAYSIZE(kQ099Salt); + *out_len = QUICHE_ARRAYSIZE(kQ099Salt); return kQ099Salt; case QUIC_VERSION_RESERVED_FOR_NEGOTIATION: // It doesn't matter what salt we use for // QUIC_VERSION_RESERVED_FOR_NEGOTIATION, but some tests try to use a // QuicFramer with QUIC_VERSION_RESERVED_FOR_NEGOTIATION and will hit // the following QUIC_BUG if there isn't a case for it. ): - *out_len = QUIC_ARRAYSIZE(kDraft23InitialSalt); + *out_len = QUICHE_ARRAYSIZE(kDraft23InitialSalt); return kDraft23InitialSalt; default: QUIC_BUG << "No initial obfuscation salt for version " << version; @@ -160,12 +160,12 @@ case PROTOCOL_TLS1_3: switch (version.transport_version) { case QUIC_VERSION_50: - *out_len = QUIC_ARRAYSIZE(kT050Salt); + *out_len = QUICHE_ARRAYSIZE(kT050Salt); return kT050Salt; case QUIC_VERSION_99: // ParsedQuicVersion(PROTOCOL_TLS1_3, QUIC_VERSION_99) uses the IETF // salt. - *out_len = QUIC_ARRAYSIZE(kDraft23InitialSalt); + *out_len = QUICHE_ARRAYSIZE(kDraft23InitialSalt); return kDraft23InitialSalt; default: QUIC_BUG << "No initial obfuscation salt for version " << version; @@ -175,7 +175,7 @@ default: QUIC_BUG << "No initial obfuscation salt for version " << version; } - *out_len = QUIC_ARRAYSIZE(kDraft23InitialSalt); + *out_len = QUICHE_ARRAYSIZE(kDraft23InitialSalt); return kDraft23InitialSalt; }
diff --git a/quic/core/crypto/crypto_utils_test.cc b/quic/core/crypto/crypto_utils_test.cc index bba62e9..247bd5d 100644 --- a/quic/core/crypto/crypto_utils_test.cc +++ b/quic/core/crypto/crypto_utils_test.cc
@@ -7,9 +7,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" namespace quic { @@ -49,7 +49,7 @@ "c9a46ed0757bd1812f1f21b4d41e62125fec8364a21db7"}, }; - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_vector); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_vector); i++) { // Decode the test vector. std::string subkey_secret = quiche::QuicheTextUtils::HexDecode(test_vector[i].subkey_secret);
diff --git a/quic/core/crypto/null_decrypter_test.cc b/quic/core/crypto/null_decrypter_test.cc index 9f18cc2..1baecad 100644 --- a/quic/core/crypto/null_decrypter_test.cc +++ b/quic/core/crypto/null_decrypter_test.cc
@@ -3,9 +3,9 @@ // found in the LICENSE file. #include "net/third_party/quiche/src/quic/core/crypto/null_decrypter.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -38,7 +38,7 @@ '!', }; const char* data = reinterpret_cast<const char*>(expected); - size_t len = QUIC_ARRAYSIZE(expected); + size_t len = QUICHE_ARRAYSIZE(expected); NullDecrypter decrypter(Perspective::IS_SERVER); char buffer[256]; size_t length = 0; @@ -75,7 +75,7 @@ '!', }; const char* data = reinterpret_cast<const char*>(expected); - size_t len = QUIC_ARRAYSIZE(expected); + size_t len = QUICHE_ARRAYSIZE(expected); NullDecrypter decrypter(Perspective::IS_CLIENT); char buffer[256]; size_t length = 0; @@ -112,7 +112,7 @@ '!', }; const char* data = reinterpret_cast<const char*>(expected); - size_t len = QUIC_ARRAYSIZE(expected); + size_t len = QUICHE_ARRAYSIZE(expected); NullDecrypter decrypter(Perspective::IS_CLIENT); char buffer[256]; size_t length = 0; @@ -127,7 +127,7 @@ 0x46, 0x11, 0xea, 0x5f, 0xcf, 0x1d, 0x66, 0x5b, 0xba, 0xf0, 0xbc, }; const char* data = reinterpret_cast<const char*>(expected); - size_t len = QUIC_ARRAYSIZE(expected); + size_t len = QUICHE_ARRAYSIZE(expected); NullDecrypter decrypter(Perspective::IS_CLIENT); char buffer[256]; size_t length = 0;
diff --git a/quic/core/crypto/null_encrypter_test.cc b/quic/core/crypto/null_encrypter_test.cc index c6a89ef..83b61ef 100644 --- a/quic/core/crypto/null_encrypter_test.cc +++ b/quic/core/crypto/null_encrypter_test.cc
@@ -3,9 +3,9 @@ // found in the LICENSE file. #include "net/third_party/quiche/src/quic/core/crypto/null_encrypter.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -44,7 +44,7 @@ &encrypted_len, 256)); test::CompareCharArraysWithHexError( "encrypted data", encrypted, encrypted_len, - reinterpret_cast<const char*>(expected), QUIC_ARRAYSIZE(expected)); + reinterpret_cast<const char*>(expected), QUICHE_ARRAYSIZE(expected)); } TEST_F(NullEncrypterTest, EncryptServer) { @@ -79,7 +79,7 @@ &encrypted_len, 256)); test::CompareCharArraysWithHexError( "encrypted data", encrypted, encrypted_len, - reinterpret_cast<const char*>(expected), QUIC_ARRAYSIZE(expected)); + reinterpret_cast<const char*>(expected), QUICHE_ARRAYSIZE(expected)); } TEST_F(NullEncrypterTest, GetMaxPlaintextSize) {
diff --git a/quic/core/crypto/quic_crypto_client_config.cc b/quic/core/crypto/quic_crypto_client_config.cc index 330192b..06dd8b6 100644 --- a/quic/core/crypto/quic_crypto_client_config.cc +++ b/quic/core/crypto/quic_crypto_client_config.cc
@@ -25,13 +25,13 @@ #include "net/third_party/quiche/src/quic/core/quic_connection_id.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_client_stats.h" #include "net/third_party/quiche/src/quic/platform/api/quic_hostname_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -487,9 +487,9 @@ } char proof_nonce[32]; - rand->RandBytes(proof_nonce, QUIC_ARRAYSIZE(proof_nonce)); + rand->RandBytes(proof_nonce, QUICHE_ARRAYSIZE(proof_nonce)); out->SetStringPiece(kNONP, quiche::QuicheStringPiece( - proof_nonce, QUIC_ARRAYSIZE(proof_nonce))); + proof_nonce, QUICHE_ARRAYSIZE(proof_nonce))); out->SetVector(kPDMD, QuicTagVector{kX509});
diff --git a/quic/core/crypto/quic_hkdf_test.cc b/quic/core/crypto/quic_hkdf_test.cc index 92dc085..8b74f63 100644 --- a/quic/core/crypto/quic_hkdf_test.cc +++ b/quic/core/crypto/quic_hkdf_test.cc
@@ -6,8 +6,8 @@ #include <string> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" namespace quic { @@ -67,7 +67,7 @@ class QuicHKDFTest : public QuicTest {}; TEST_F(QuicHKDFTest, HKDF) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(kHKDFInputs); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kHKDFInputs); i++) { const HKDFInput& test(kHKDFInputs[i]); SCOPED_TRACE(i);
diff --git a/quic/core/crypto/transport_parameters_test.cc b/quic/core/crypto/transport_parameters_test.cc index 77638e2..ed7a63c 100644 --- a/quic/core/crypto/transport_parameters_test.cc +++ b/quic/core/crypto/transport_parameters_test.cc
@@ -9,10 +9,10 @@ #include "third_party/boringssl/src/include/openssl/mem.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_ip_address.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -356,7 +356,7 @@ TransportParameters new_params; ASSERT_TRUE( ParseTransportParameters(kVersion, Perspective::IS_CLIENT, kClientParams, - QUIC_ARRAYSIZE(kClientParams), &new_params)); + QUICHE_ARRAYSIZE(kClientParams), &new_params)); EXPECT_EQ(Perspective::IS_CLIENT, new_params.perspective); EXPECT_EQ(kFakeVersionLabel, new_params.version); @@ -412,7 +412,7 @@ EXPECT_FALSE(ParseTransportParameters( kVersion, Perspective::IS_CLIENT, kClientParamsWithFullToken, - QUIC_ARRAYSIZE(kClientParamsWithFullToken), &out_params)); + QUICHE_ARRAYSIZE(kClientParamsWithFullToken), &out_params)); // clang-format off const uint8_t kClientParamsWithEmptyToken[] = { @@ -437,7 +437,7 @@ EXPECT_FALSE(ParseTransportParameters( kVersion, Perspective::IS_CLIENT, kClientParamsWithEmptyToken, - QUIC_ARRAYSIZE(kClientParamsWithEmptyToken), &out_params)); + QUICHE_ARRAYSIZE(kClientParamsWithEmptyToken), &out_params)); } TEST_F(TransportParametersTest, ParseClientParametersRepeated) { @@ -464,7 +464,7 @@ TransportParameters out_params; EXPECT_FALSE(ParseTransportParameters( kVersion, Perspective::IS_CLIENT, kClientParamsRepeated, - QUIC_ARRAYSIZE(kClientParamsRepeated), &out_params)); + QUICHE_ARRAYSIZE(kClientParamsRepeated), &out_params)); } TEST_F(TransportParametersTest, ParseServerParams) { @@ -552,7 +552,7 @@ TransportParameters new_params; ASSERT_TRUE( ParseTransportParameters(kVersion, Perspective::IS_SERVER, kServerParams, - QUIC_ARRAYSIZE(kServerParams), &new_params)); + QUICHE_ARRAYSIZE(kServerParams), &new_params)); EXPECT_EQ(Perspective::IS_SERVER, new_params.perspective); EXPECT_EQ(kFakeVersionLabel, new_params.version); @@ -619,7 +619,7 @@ TransportParameters out_params; EXPECT_FALSE(ParseTransportParameters( kVersion, Perspective::IS_SERVER, kServerParamsRepeated, - QUIC_ARRAYSIZE(kServerParamsRepeated), &out_params)); + QUICHE_ARRAYSIZE(kServerParamsRepeated), &out_params)); } TEST_F(TransportParametersTest, CryptoHandshakeMessageRoundtrip) {
diff --git a/quic/core/http/http_decoder_test.cc b/quic/core/http/http_decoder_test.cc index 6796d25..bcdf6c1 100644 --- a/quic/core/http/http_decoder_test.cc +++ b/quic/core/http/http_decoder_test.cc
@@ -11,9 +11,9 @@ #include "net/third_party/quiche/src/quic/core/http/http_frames.h" #include "net/third_party/quiche/src/quic/core/quic_data_writer.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -875,7 +875,7 @@ writer.WriteStringPiece("Malformed payload"); EXPECT_CALL(visitor_, OnError(&decoder_)); - EXPECT_EQ(5u, decoder_.ProcessInput(input, QUIC_ARRAYSIZE(input))); + EXPECT_EQ(5u, decoder_.ProcessInput(input, QUICHE_ARRAYSIZE(input))); EXPECT_THAT(decoder_.error(), IsError(QUIC_INVALID_FRAME_DATA)); EXPECT_EQ("Frame is too large", decoder_.error_detail()); }
diff --git a/quic/core/http/http_encoder_test.cc b/quic/core/http/http_encoder_test.cc index 2df89bd..062df95 100644 --- a/quic/core/http/http_encoder_test.cc +++ b/quic/core/http/http_encoder_test.cc
@@ -4,9 +4,9 @@ #include "net/third_party/quiche/src/quic/core/http/http_encoder.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -19,9 +19,9 @@ 0x00, // length 0x05}; - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("DATA", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializeHeadersFrameHeader) { @@ -32,9 +32,9 @@ 0x01, // length 0x07}; - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("HEADERS", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializePriorityFrame) { @@ -60,9 +60,9 @@ std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializePriorityFrame(priority, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("PRIORITY", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); PriorityFrame priority2; priority2.prioritized_type = ROOT_OF_TREE; @@ -81,9 +81,9 @@ // weight 0xff}; length = HttpEncoder::SerializePriorityFrame(priority2, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output2), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output2), length); CompareCharArraysWithHexError("PRIORITY", buffer.get(), length, output2, - QUIC_ARRAYSIZE(output2)); + QUICHE_ARRAYSIZE(output2)); PriorityFrame priority3; priority3.prioritized_type = ROOT_OF_TREE; @@ -99,9 +99,9 @@ // weight 0xff}; length = HttpEncoder::SerializePriorityFrame(priority3, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output3), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output3), length); CompareCharArraysWithHexError("PRIORITY", buffer.get(), length, output3, - QUIC_ARRAYSIZE(output3)); + QUICHE_ARRAYSIZE(output3)); } TEST(HttpEncoderTest, SerializeCancelPushFrame) { @@ -115,9 +115,9 @@ 0x01}; std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializeCancelPushFrame(cancel_push, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("CANCEL_PUSH", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializeSettingsFrame) { @@ -143,9 +143,9 @@ 0x04}; std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializeSettingsFrame(settings, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("SETTINGS", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializePushPromiseFrameWithOnlyPushId) { @@ -161,9 +161,9 @@ std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializePushPromiseFrameWithOnlyPushId( push_promise, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("PUSH_PROMISE", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializeGoAwayFrame) { @@ -177,9 +177,9 @@ 0x01}; std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializeGoAwayFrame(goaway, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("GOAWAY", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializeMaxPushIdFrame) { @@ -193,9 +193,9 @@ 0x01}; std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializeMaxPushIdFrame(max_push_id, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("MAX_PUSH_ID", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } TEST(HttpEncoderTest, SerializeDuplicatePushFrame) { @@ -210,9 +210,9 @@ std::unique_ptr<char[]> buffer; uint64_t length = HttpEncoder::SerializeDuplicatePushFrame(duplicate_push, &buffer); - EXPECT_EQ(QUIC_ARRAYSIZE(output), length); + EXPECT_EQ(QUICHE_ARRAYSIZE(output), length); CompareCharArraysWithHexError("DUPLICATE_PUSH", buffer.get(), length, output, - QUIC_ARRAYSIZE(output)); + QUICHE_ARRAYSIZE(output)); } } // namespace test
diff --git a/quic/core/http/quic_headers_stream.cc b/quic/core/http/quic_headers_stream.cc index 394d42a..5b1a87b 100644 --- a/quic/core/http/quic_headers_stream.cc +++ b/quic/core/http/quic_headers_stream.cc
@@ -6,9 +6,9 @@ #include "net/third_party/quiche/src/quic/core/http/quic_spdy_session.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic {
diff --git a/quic/core/http/quic_send_control_stream.cc b/quic/core/http/quic_send_control_stream.cc index abb21ae..a4bca3d 100644 --- a/quic/core/http/quic_send_control_stream.cc +++ b/quic/core/http/quic_send_control_stream.cc
@@ -10,7 +10,7 @@ #include "net/third_party/quiche/src/quic/core/quic_session.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -44,7 +44,7 @@ QuicConnection::ScopedPacketFlusher flusher(session()->connection()); // Send the stream type on so the peer knows about this stream. char data[sizeof(kControlStream)]; - QuicDataWriter writer(QUIC_ARRAYSIZE(data), data); + QuicDataWriter writer(QUICHE_ARRAYSIZE(data), data); writer.WriteVarInt62(kControlStream); WriteOrBufferData(quiche::QuicheStringPiece(writer.data(), writer.length()), false, nullptr);
diff --git a/quic/core/http/quic_spdy_client_session_test.cc b/quic/core/http/quic_spdy_client_session_test.cc index d699c85..89f719d 100644 --- a/quic/core/http/quic_spdy_client_session_test.cc +++ b/quic/core/http/quic_spdy_client_session_test.cc
@@ -14,7 +14,6 @@ #include "net/third_party/quiche/src/quic/core/http/quic_spdy_client_stream.h" #include "net/third_party/quiche/src/quic/core/http/spdy_server_push_utils.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" #include "net/third_party/quiche/src/quic/platform/api/quic_socket_address.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" @@ -27,6 +26,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_session_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_session_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -234,7 +234,7 @@ // Verify that no data may be send on existing streams. char data[] = "hello world"; QuicConsumedData consumed = session_->WritevData( - stream, stream->id(), QUIC_ARRAYSIZE(data), 0, NO_FIN); + stream, stream->id(), QUICHE_ARRAYSIZE(data), 0, NO_FIN); EXPECT_FALSE(consumed.fin_consumed); EXPECT_EQ(0u, consumed.bytes_consumed); }
diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc index 7503593..2867f5e 100644 --- a/quic/core/http/quic_spdy_session_test.cc +++ b/quic/core/http/quic_spdy_session_test.cc
@@ -21,7 +21,6 @@ #include "net/third_party/quiche/src/quic/core/quic_stream.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" @@ -38,6 +37,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_stream_send_buffer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -2123,7 +2123,7 @@ char input[] = {0x04, // type 'a', 'b', 'c'}; // data - quiche::QuicheStringPiece payload(input, QUIC_ARRAYSIZE(input)); + quiche::QuicheStringPiece payload(input, QUICHE_ARRAYSIZE(input)); // This is a server test with a client-initiated unidirectional stream. QuicStreamId stream_id = QuicUtils::GetFirstUnidirectionalStreamId( @@ -2159,7 +2159,7 @@ char input[] = {0x04, // type 'a', 'b', 'c'}; // data - quiche::QuicheStringPiece payload(input, QUIC_ARRAYSIZE(input)); + quiche::QuicheStringPiece payload(input, QUICHE_ARRAYSIZE(input)); // This is a server test with a client-initiated unidirectional stream. QuicStreamId stream_id = QuicUtils::GetFirstUnidirectionalStreamId( @@ -2200,7 +2200,7 @@ char input[] = {0x41, 0x00, // type (256) 'a', 'b', 'c'}; // data - quiche::QuicheStringPiece payload(input, QUIC_ARRAYSIZE(input)); + quiche::QuicheStringPiece payload(input, QUICHE_ARRAYSIZE(input)); // This is a server test with a client-initiated unidirectional stream. QuicStreamId stream_id = QuicUtils::GetFirstUnidirectionalStreamId(
diff --git a/quic/core/http/quic_spdy_stream.cc b/quic/core/http/quic_spdy_stream.cc index a65e964..ce3cb3e 100644 --- a/quic/core/http/quic_spdy_stream.cc +++ b/quic/core/http/quic_spdy_stream.cc
@@ -17,12 +17,12 @@ #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_mem_slice_storage.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" #include "net/third_party/quiche/src/spdy/core/spdy_protocol.h" @@ -264,7 +264,7 @@ if (VersionUsesHttp3(transport_version()) && type() == WRITE_UNIDIRECTIONAL && send_buffer().stream_offset() == 0) { char data[sizeof(kServerPushStream)]; - QuicDataWriter writer(QUIC_ARRAYSIZE(data), data); + QuicDataWriter writer(QUICHE_ARRAYSIZE(data), data); writer.WriteVarInt62(kServerPushStream); // Similar to frame headers, stream type byte shouldn't be exposed to upper
diff --git a/quic/core/http/quic_spdy_stream_body_manager_test.cc b/quic/core/http/quic_spdy_stream_body_manager_test.cc index b9e63ab..0cdc65a 100644 --- a/quic/core/http/quic_spdy_stream_body_manager_test.cc +++ b/quic/core/http/quic_spdy_stream_body_manager_test.cc
@@ -8,10 +8,10 @@ #include <numeric> #include <string> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -75,7 +75,7 @@ }; for (size_t test_case_index = 0; - test_case_index < QUIC_ARRAYSIZE(kOnBodyConsumedTestData); + test_case_index < QUICHE_ARRAYSIZE(kOnBodyConsumedTestData); ++test_case_index) { const std::vector<QuicByteCount>& frame_header_lengths = kOnBodyConsumedTestData[test_case_index].frame_header_lengths; @@ -127,7 +127,8 @@ }; for (size_t test_case_index = 0; - test_case_index < QUIC_ARRAYSIZE(kPeekBodyTestData); ++test_case_index) { + test_case_index < QUICHE_ARRAYSIZE(kPeekBodyTestData); + ++test_case_index) { const std::vector<QuicByteCount>& frame_header_lengths = kPeekBodyTestData[test_case_index].frame_header_lengths; const std::vector<const char*>& frame_payloads = @@ -220,7 +221,8 @@ }; for (size_t test_case_index = 0; - test_case_index < QUIC_ARRAYSIZE(kReadBodyTestData); ++test_case_index) { + test_case_index < QUICHE_ARRAYSIZE(kReadBodyTestData); + ++test_case_index) { const std::vector<QuicByteCount>& frame_header_lengths = kReadBodyTestData[test_case_index].frame_header_lengths; const std::vector<const char*>& frame_payloads =
diff --git a/quic/core/http/quic_spdy_stream_test.cc b/quic/core/http/quic_spdy_stream_test.cc index c5dc417..61b0d35 100644 --- a/quic/core/http/quic_spdy_stream_test.cc +++ b/quic/core/http/quic_spdy_stream_test.cc
@@ -15,7 +15,6 @@ #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" @@ -28,6 +27,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_stream_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -72,7 +72,7 @@ char buffer[2048]; struct iovec vec; vec.iov_base = buffer; - vec.iov_len = QUIC_ARRAYSIZE(buffer); + vec.iov_len = QUICHE_ARRAYSIZE(buffer); size_t bytes_read = Readv(&vec, 1); data_ += std::string(buffer, bytes_read); } @@ -598,10 +598,10 @@ stream_->ConsumeHeaderList(); char buffer[2048]; - ASSERT_LT(data.length(), QUIC_ARRAYSIZE(buffer)); + ASSERT_LT(data.length(), QUICHE_ARRAYSIZE(buffer)); struct iovec vec; vec.iov_base = buffer; - vec.iov_len = QUIC_ARRAYSIZE(buffer); + vec.iov_len = QUICHE_ARRAYSIZE(buffer); size_t bytes_read = stream_->Readv(&vec, 1); QuicStreamPeer::CloseReadSide(stream_); @@ -623,9 +623,9 @@ char buffer2[2048]; struct iovec vec[2]; vec[0].iov_base = buffer; - vec[0].iov_len = QUIC_ARRAYSIZE(buffer); + vec[0].iov_len = QUICHE_ARRAYSIZE(buffer); vec[1].iov_base = buffer2; - vec[1].iov_len = QUIC_ARRAYSIZE(buffer2); + vec[1].iov_len = QUICHE_ARRAYSIZE(buffer2); size_t bytes_read = stream_->Readv(vec, 2); EXPECT_EQ(2048u * 2, bytes_read); EXPECT_EQ(body.substr(0, 2048), std::string(buffer, 2048)); @@ -690,7 +690,7 @@ char buffer[1]; struct iovec vec; vec.iov_base = buffer; - vec.iov_len = QUIC_ARRAYSIZE(buffer); + vec.iov_len = QUICHE_ARRAYSIZE(buffer); for (size_t i = 0; i < body.length(); ++i) { size_t bytes_read = stream_->Readv(&vec, 1); @@ -715,9 +715,9 @@ char buffer2[1]; struct iovec vec[2]; vec[0].iov_base = buffer1; - vec[0].iov_len = QUIC_ARRAYSIZE(buffer1); + vec[0].iov_len = QUICHE_ARRAYSIZE(buffer1); vec[1].iov_base = buffer2; - vec[1].iov_len = QUIC_ARRAYSIZE(buffer2); + vec[1].iov_len = QUICHE_ARRAYSIZE(buffer2); for (size_t i = 0; i < body.length(); i += 2) { size_t bytes_read = stream_->Readv(vec, 2); @@ -1844,7 +1844,7 @@ char buffer[2048]; struct iovec vec; vec.iov_base = buffer; - vec.iov_len = QUIC_ARRAYSIZE(buffer); + vec.iov_len = QUICHE_ARRAYSIZE(buffer); size_t bytes_read = stream_->Readv(&vec, 1); EXPECT_EQ(kDataFramePayload, quiche::QuicheStringPiece(buffer, bytes_read));
diff --git a/quic/core/http/spdy_server_push_utils_test.cc b/quic/core/http/spdy_server_push_utils_test.cc index aa35550..ed7895e 100644 --- a/quic/core/http/spdy_server_push_utils_test.cc +++ b/quic/core/http/spdy_server_push_utils_test.cc
@@ -7,8 +7,8 @@ #include <memory> #include <string> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" using spdy::SpdyHeaderBlock; @@ -157,11 +157,11 @@ {"[::ffff:192.168", 0}, {"]/", 0}, {"//", 0}}; - for (size_t i = 0; i < QUIC_ARRAYSIZE(input_headers); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(input_headers); ++i) { bool should_accept = (input_headers[i].second & SCHEME); - for (size_t j = 0; j < QUIC_ARRAYSIZE(input_headers); ++j) { + for (size_t j = 0; j < QUICHE_ARRAYSIZE(input_headers); ++j) { bool should_accept_2 = should_accept && (input_headers[j].second & AUTH); - for (size_t k = 0; k < QUIC_ARRAYSIZE(input_headers); ++k) { + for (size_t k = 0; k < QUICHE_ARRAYSIZE(input_headers); ++k) { // |should_accept_3| indicates whether or not GetPushPromiseUrl() is // expected to accept this input combination. bool should_accept_3 =
diff --git a/quic/core/http/spdy_utils_test.cc b/quic/core/http/spdy_utils_test.cc index 898d5f7..55d4706 100644 --- a/quic/core/http/spdy_utils_test.cc +++ b/quic/core/http/spdy_utils_test.cc
@@ -6,8 +6,8 @@ #include <string> #include "net/third_party/quiche/src/quic/core/http/spdy_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h"
diff --git a/quic/core/qpack/qpack_header_table_test.cc b/quic/core/qpack/qpack_header_table_test.cc index 071c65c..5cf3920 100644 --- a/quic/core/qpack/qpack_header_table_test.cc +++ b/quic/core/qpack/qpack_header_table_test.cc
@@ -7,8 +7,8 @@ #include <utility> #include "net/third_party/quiche/src/quic/core/qpack/qpack_static_table.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/spdy/core/hpack/hpack_entry.h"
diff --git a/quic/core/qpack/qpack_required_insert_count_test.cc b/quic/core/qpack/qpack_required_insert_count_test.cc index a84548d..fce7de9 100644 --- a/quic/core/qpack/qpack_required_insert_count_test.cc +++ b/quic/core/qpack/qpack_required_insert_count_test.cc
@@ -4,8 +4,8 @@ #include "net/third_party/quiche/src/quic/core/qpack/qpack_required_insert_count.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -50,7 +50,7 @@ {600, 100, 500}}; TEST(QpackRequiredInsertCountTest, QpackDecodeRequiredInsertCount) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(kTestData); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kTestData); ++i) { const uint64_t required_insert_count = kTestData[i].required_insert_count; const uint64_t max_entries = kTestData[i].max_entries; const uint64_t total_number_of_inserts = @@ -109,7 +109,7 @@ {601, 100, 500}}; TEST(QpackRequiredInsertCountTest, DecodeRequiredInsertCountError) { - for (size_t i = 0; i < QUIC_ARRAYSIZE(kInvalidTestData); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kInvalidTestData); ++i) { uint64_t decoded_required_insert_count = 0; EXPECT_FALSE(QpackDecodeRequiredInsertCount( kInvalidTestData[i].encoded_required_insert_count,
diff --git a/quic/core/qpack/qpack_send_stream.cc b/quic/core/qpack/qpack_send_stream.cc index 23f9db2..a42d0d0 100644 --- a/quic/core/qpack/qpack_send_stream.cc +++ b/quic/core/qpack/qpack_send_stream.cc
@@ -5,7 +5,7 @@ #include "net/third_party/quiche/src/quic/core/qpack/qpack_send_stream.h" #include "net/third_party/quiche/src/quic/core/quic_session.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -33,7 +33,7 @@ void QpackSendStream::MaybeSendStreamType() { if (!stream_type_sent_) { char type[sizeof(http3_stream_type_)]; - QuicDataWriter writer(QUIC_ARRAYSIZE(type), type); + QuicDataWriter writer(QUICHE_ARRAYSIZE(type), type); writer.WriteVarInt62(http3_stream_type_); WriteOrBufferData(quiche::QuicheStringPiece(writer.data(), writer.length()), false, nullptr);
diff --git a/quic/core/qpack/qpack_static_table.cc b/quic/core/qpack/qpack_static_table.cc index 98a24c7..17138be 100644 --- a/quic/core/qpack/qpack_static_table.cc +++ b/quic/core/qpack/qpack_static_table.cc
@@ -4,15 +4,15 @@ #include "net/third_party/quiche/src/quic/core/qpack/qpack_static_table.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { // The "constructor" for a QpackStaticEntry that computes the lengths at // compile time. #define STATIC_ENTRY(name, value) \ - { name, QUIC_ARRAYSIZE(name) - 1, value, QUIC_ARRAYSIZE(value) - 1 } + { name, QUICHE_ARRAYSIZE(name) - 1, value, QUICHE_ARRAYSIZE(value) - 1 } const std::vector<QpackStaticEntry>& QpackStaticTableVector() { static const auto* kQpackStaticTable = new std::vector<QpackStaticEntry>{
diff --git a/quic/core/qpack/qpack_static_table_test.cc b/quic/core/qpack/qpack_static_table_test.cc index a8e7ac2..1376d2c 100644 --- a/quic/core/qpack/qpack_static_table_test.cc +++ b/quic/core/qpack/qpack_static_table_test.cc
@@ -6,8 +6,8 @@ #include <set> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic {
diff --git a/quic/core/qpack/value_splitting_header_list_test.cc b/quic/core/qpack/value_splitting_header_list_test.cc index ef69aad..c1da85c 100644 --- a/quic/core/qpack/value_splitting_header_list_test.cc +++ b/quic/core/qpack/value_splitting_header_list_test.cc
@@ -4,8 +4,8 @@ #include "net/third_party/quiche/src/quic/core/qpack/value_splitting_header_list.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -113,7 +113,7 @@ {"cookie", "; foobar; ", {"", "foobar", ""}}, }; - for (size_t i = 0; i < QUIC_ARRAYSIZE(kTestData); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kTestData); ++i) { spdy::SpdyHeaderBlock block; block[kTestData[i].name] = kTestData[i].value;
diff --git a/quic/core/quic_connection_id_test.cc b/quic/core/quic_connection_id_test.cc index df73630..1703913 100644 --- a/quic/core/quic_connection_id_test.cc +++ b/quic/core/quic_connection_id_test.cc
@@ -9,9 +9,9 @@ #include <string> #include "net/third_party/quiche/src/quic/core/quic_types.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic {
diff --git a/quic/core/quic_crypto_client_stream_test.cc b/quic/core/quic_crypto_client_stream_test.cc index 2f758cc..576eb57 100644 --- a/quic/core/quic_crypto_client_stream_test.cc +++ b/quic/core/quic_crypto_client_stream_test.cc
@@ -14,7 +14,6 @@ #include "net/third_party/quiche/src/quic/core/quic_packets.h" #include "net/third_party/quiche/src/quic/core/quic_server_id.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" @@ -23,6 +22,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/simple_quic_framer.h" #include "net/third_party/quiche/src/quic/test_tools/simple_session_cache.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" using testing::_; @@ -298,7 +298,7 @@ const std::string& cached_scfg = state->server_config(); test::CompareCharArraysWithHexError( "scfg", cached_scfg.data(), cached_scfg.length(), - reinterpret_cast<char*>(scfg), QUIC_ARRAYSIZE(scfg)); + reinterpret_cast<char*>(scfg), QUICHE_ARRAYSIZE(scfg)); QuicStreamSequencer* sequencer = QuicStreamPeer::sequencer(stream()); EXPECT_FALSE(QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
diff --git a/quic/core/quic_crypto_server_handshaker.cc b/quic/core/quic_crypto_server_handshaker.cc index 18e635b..94293f4 100644 --- a/quic/core/quic_crypto_server_handshaker.cc +++ b/quic/core/quic_crypto_server_handshaker.cc
@@ -8,7 +8,7 @@ #include <string> #include "third_party/boringssl/src/include/openssl/sha.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -385,7 +385,8 @@ SHA256(reinterpret_cast<const uint8_t*>(channel_id.data()), channel_id.size(), digest); - quiche::QuicheTextUtils::Base64Encode(digest, QUIC_ARRAYSIZE(digest), output); + quiche::QuicheTextUtils::Base64Encode(digest, QUICHE_ARRAYSIZE(digest), + output); return true; }
diff --git a/quic/core/quic_data_writer_test.cc b/quic/core/quic_data_writer_test.cc index 653fbff..7cfde88 100644 --- a/quic/core/quic_data_writer_test.cc +++ b/quic/core/quic_data_writer_test.cc
@@ -10,11 +10,11 @@ #include "net/third_party/quiche/src/quic/core/quic_connection_id.h" #include "net/third_party/quiche/src/quic/core/quic_data_reader.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -267,7 +267,7 @@ char big_endian[] = { 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, }; - EXPECT_EQ(connection_id.length(), QUIC_ARRAYSIZE(big_endian)); + EXPECT_EQ(connection_id.length(), QUICHE_ARRAYSIZE(big_endian)); ASSERT_LE(connection_id.length(), 255); char buffer[255]; QuicDataWriter writer(connection_id.length(), buffer, GetParam().endianness); @@ -278,8 +278,8 @@ QuicConnectionId read_connection_id; QuicDataReader reader(buffer, connection_id.length(), GetParam().endianness); - EXPECT_TRUE( - reader.ReadConnectionId(&read_connection_id, QUIC_ARRAYSIZE(big_endian))); + EXPECT_TRUE(reader.ReadConnectionId(&read_connection_id, + QUICHE_ARRAYSIZE(big_endian))); EXPECT_EQ(connection_id, read_connection_id); } @@ -289,35 +289,35 @@ char length_prefixed_connection_id[] = { 0x08, 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, }; - EXPECT_EQ(QUIC_ARRAYSIZE(length_prefixed_connection_id), + EXPECT_EQ(QUICHE_ARRAYSIZE(length_prefixed_connection_id), kConnectionIdLengthSize + connection_id.length()); char buffer[kConnectionIdLengthSize + 255] = {}; - QuicDataWriter writer(QUIC_ARRAYSIZE(buffer), buffer); + QuicDataWriter writer(QUICHE_ARRAYSIZE(buffer), buffer); EXPECT_TRUE(writer.WriteLengthPrefixedConnectionId(connection_id)); test::CompareCharArraysWithHexError( "WriteLengthPrefixedConnectionId", buffer, writer.length(), length_prefixed_connection_id, - QUIC_ARRAYSIZE(length_prefixed_connection_id)); + QUICHE_ARRAYSIZE(length_prefixed_connection_id)); // Verify that writing length then connection ID produces the same output. - memset(buffer, 0, QUIC_ARRAYSIZE(buffer)); - QuicDataWriter writer2(QUIC_ARRAYSIZE(buffer), buffer); + memset(buffer, 0, QUICHE_ARRAYSIZE(buffer)); + QuicDataWriter writer2(QUICHE_ARRAYSIZE(buffer), buffer); EXPECT_TRUE(writer2.WriteUInt8(connection_id.length())); EXPECT_TRUE(writer2.WriteConnectionId(connection_id)); test::CompareCharArraysWithHexError( "Write length then ConnectionId", buffer, writer2.length(), length_prefixed_connection_id, - QUIC_ARRAYSIZE(length_prefixed_connection_id)); + QUICHE_ARRAYSIZE(length_prefixed_connection_id)); QuicConnectionId read_connection_id; - QuicDataReader reader(buffer, QUIC_ARRAYSIZE(buffer)); + QuicDataReader reader(buffer, QUICHE_ARRAYSIZE(buffer)); EXPECT_TRUE(reader.ReadLengthPrefixedConnectionId(&read_connection_id)); EXPECT_EQ(connection_id, read_connection_id); // Verify that reading length then connection ID produces the same output. uint8_t read_connection_id_length2 = 33; QuicConnectionId read_connection_id2; - QuicDataReader reader2(buffer, QUIC_ARRAYSIZE(buffer)); + QuicDataReader reader2(buffer, QUICHE_ARRAYSIZE(buffer)); ASSERT_TRUE(reader2.ReadUInt8(&read_connection_id_length2)); EXPECT_EQ(connection_id.length(), read_connection_id_length2); EXPECT_TRUE(reader2.ReadConnectionId(&read_connection_id2, @@ -328,7 +328,8 @@ TEST_P(QuicDataWriterTest, EmptyConnectionIds) { QuicConnectionId empty_connection_id = EmptyQuicConnectionId(); char buffer[2]; - QuicDataWriter writer(QUIC_ARRAYSIZE(buffer), buffer, GetParam().endianness); + QuicDataWriter writer(QUICHE_ARRAYSIZE(buffer), buffer, + GetParam().endianness); EXPECT_TRUE(writer.WriteConnectionId(empty_connection_id)); EXPECT_TRUE(writer.WriteUInt8(1)); EXPECT_TRUE(writer.WriteConnectionId(empty_connection_id)); @@ -341,7 +342,8 @@ QuicConnectionId read_connection_id = TestConnectionId(); uint8_t read_byte; - QuicDataReader reader(buffer, QUIC_ARRAYSIZE(buffer), GetParam().endianness); + QuicDataReader reader(buffer, QUICHE_ARRAYSIZE(buffer), + GetParam().endianness); EXPECT_TRUE(reader.ReadConnectionId(&read_connection_id, 0)); EXPECT_EQ(read_connection_id, empty_connection_id); EXPECT_TRUE(reader.ReadUInt8(&read_byte)); @@ -659,10 +661,10 @@ TEST_P(QuicDataWriterTest, WriteBytes) { char bytes[] = {0, 1, 2, 3, 4, 5, 6, 7, 8}; - char buf[QUIC_ARRAYSIZE(bytes)]; - QuicDataWriter writer(QUIC_ARRAYSIZE(buf), buf, GetParam().endianness); - EXPECT_TRUE(writer.WriteBytes(bytes, QUIC_ARRAYSIZE(bytes))); - for (unsigned int i = 0; i < QUIC_ARRAYSIZE(bytes); ++i) { + char buf[QUICHE_ARRAYSIZE(bytes)]; + QuicDataWriter writer(QUICHE_ARRAYSIZE(buf), buf, GetParam().endianness); + EXPECT_TRUE(writer.WriteBytes(bytes, QUICHE_ARRAYSIZE(bytes))); + for (unsigned int i = 0; i < QUICHE_ARRAYSIZE(bytes); ++i) { EXPECT_EQ(bytes[i], buf[i]); } } @@ -1210,13 +1212,14 @@ TEST_P(QuicDataWriterTest, Seek) { char buffer[3] = {}; - QuicDataWriter writer(QUIC_ARRAYSIZE(buffer), buffer, GetParam().endianness); + QuicDataWriter writer(QUICHE_ARRAYSIZE(buffer), buffer, + GetParam().endianness); EXPECT_TRUE(writer.WriteUInt8(42)); EXPECT_TRUE(writer.Seek(1)); EXPECT_TRUE(writer.WriteUInt8(3)); char expected[] = {42, 0, 3}; - for (size_t i = 0; i < QUIC_ARRAYSIZE(expected); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(expected); ++i) { EXPECT_EQ(buffer[i], expected[i]); } } @@ -1226,7 +1229,7 @@ // Check that one can seek to the end of the writer, but not past. { - QuicDataWriter writer(QUIC_ARRAYSIZE(buffer), buffer, + QuicDataWriter writer(QUICHE_ARRAYSIZE(buffer), buffer, GetParam().endianness); EXPECT_TRUE(writer.Seek(20)); EXPECT_FALSE(writer.Seek(1)); @@ -1234,14 +1237,14 @@ // Seeking several bytes past the end fails. { - QuicDataWriter writer(QUIC_ARRAYSIZE(buffer), buffer, + QuicDataWriter writer(QUICHE_ARRAYSIZE(buffer), buffer, GetParam().endianness); EXPECT_FALSE(writer.Seek(100)); } // Seeking so far that arithmetic overflow could occur also fails. { - QuicDataWriter writer(QUIC_ARRAYSIZE(buffer), buffer, + QuicDataWriter writer(QUICHE_ARRAYSIZE(buffer), buffer, GetParam().endianness); EXPECT_TRUE(writer.Seek(10)); EXPECT_FALSE(writer.Seek(std::numeric_limits<size_t>::max()));
diff --git a/quic/core/quic_dispatcher_test.cc b/quic/core/quic_dispatcher_test.cc index f70add6..1ea8036 100644 --- a/quic/core/quic_dispatcher_test.cc +++ b/quic/core/quic_dispatcher_test.cc
@@ -20,7 +20,6 @@ #include "net/third_party/quiche/src/quic/core/quic_time_wait_list_manager.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" @@ -34,6 +33,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_time_wait_list_manager_peer.h" #include "net/third_party/quiche/src/quic/tools/quic_simple_crypto_server_stream_helper.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" using testing::_; @@ -936,7 +936,7 @@ } TEST_F(QuicDispatcherTest, RejectDeprecatedVersionsWithVersionNegotiation) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Please add deprecated versions to this test"); QuicSocketAddress client_address(QuicIpAddress::Loopback4(), 1); CreateTimeWaitListManager();
diff --git a/quic/core/quic_framer.cc b/quic/core/quic_framer.cc index 678796c..79ee3aa 100644 --- a/quic/core/quic_framer.cc +++ b/quic/core/quic_framer.cc
@@ -32,7 +32,6 @@ #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/platform/api/quic_aligned.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_client_stats.h" #include "net/third_party/quiche/src/quic/platform/api/quic_fallthrough.h" @@ -41,6 +40,7 @@ #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" #include "net/third_party/quiche/src/quic/platform/api/quic_stack_trace.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -1435,10 +1435,10 @@ QUIC_CACHELINE_ALIGNED char buffer[kMaxIncomingPacketSize]; if (packet_has_ietf_packet_header) { rv = ProcessIetfDataPacket(&reader, &header, packet, buffer, - QUIC_ARRAYSIZE(buffer)); + QUICHE_ARRAYSIZE(buffer)); } else { rv = ProcessDataPacket(&reader, &header, packet, buffer, - QUIC_ARRAYSIZE(buffer)); + QUICHE_ARRAYSIZE(buffer)); } } else { std::unique_ptr<char[]> large_buffer(new char[packet.length()]); @@ -4270,7 +4270,7 @@ static_cast<QuicPacketNumberLength>((header->type_byte & 0x03) + 1); char pn_buffer[IETF_MAX_PACKET_NUMBER_LENGTH] = {}; - QuicDataWriter pn_writer(QUIC_ARRAYSIZE(pn_buffer), pn_buffer); + QuicDataWriter pn_writer(QUICHE_ARRAYSIZE(pn_buffer), pn_buffer); // Read the (protected) packet number from the reader and unmask the packet // number.
diff --git a/quic/core/quic_framer_test.cc b/quic/core/quic_framer_test.cc index ab254a2..e9c682a 100644 --- a/quic/core/quic_framer_test.cc +++ b/quic/core/quic_framer_test.cc
@@ -22,7 +22,6 @@ #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" @@ -31,6 +30,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_framer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/simple_data_producer.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -970,10 +970,10 @@ }; // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() > QUIC_VERSION_43) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } const size_t header_size = GetPacketHeaderSize( @@ -1169,10 +1169,10 @@ // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); @@ -1254,13 +1254,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_length = QUIC_ARRAYSIZE(packet46); + p_length = QUICHE_ARRAYSIZE(packet46); } uint8_t first_byte = 0x33; @@ -1331,7 +1331,7 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); uint8_t first_byte = 0x33; PacketHeaderFormat format = GOOGLE_QUIC_PACKET; @@ -1388,7 +1388,8 @@ 0x00, }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsQuicNoError()); EXPECT_EQ("", framer_.detailed_error()); @@ -1422,7 +1423,8 @@ 0x00, }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsQuicNoError()); EXPECT_EQ("", framer_.detailed_error()); @@ -1915,13 +1917,13 @@ } unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_size = QUIC_ARRAYSIZE(packet49); + p_size = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); @@ -1990,13 +1992,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_size = QUIC_ARRAYSIZE(packet49); + p_size = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -2093,13 +2095,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); @@ -2363,13 +2365,13 @@ // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_length = QUIC_ARRAYSIZE(packet46); + p_length = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); @@ -2948,8 +2950,8 @@ } QuicEncryptedPacket encrypted(AsChars(p), framer_.transport_version() > QUIC_VERSION_43 - ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet), + ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet), false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -2984,12 +2986,13 @@ }; // clang-format on - QuicEncryptedPacket encrypted( - framer_.transport_version() >= QUIC_VERSION_46 ? AsChars(packet46) - : AsChars(packet), - framer_.transport_version() >= QUIC_VERSION_46 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet), - false); + QuicEncryptedPacket encrypted(framer_.transport_version() >= QUIC_VERSION_46 + ? AsChars(packet46) + : AsChars(packet), + framer_.transport_version() >= QUIC_VERSION_46 + ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet), + false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsQuicNoError()); @@ -4008,7 +4011,7 @@ QuicEncryptedPacket encrypted( AsChars(framer_.transport_version() >= QUIC_VERSION_46 ? packet46 : packet), - QUIC_ARRAYSIZE(packet), false); + QUICHE_ARRAYSIZE(packet), false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); EXPECT_TRUE(quiche::QuicheTextUtils::StartsWith( framer_.detailed_error(), "delta_from_largest_observed too high")); @@ -4082,7 +4085,7 @@ QuicEncryptedPacket encrypted( AsChars(framer_.transport_version() >= QUIC_VERSION_46 ? packet46 : packet), - QUIC_ARRAYSIZE(packet), false); + QUICHE_ARRAYSIZE(packet), false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); EXPECT_TRUE(quiche::QuicheTextUtils::StartsWith( framer_.detailed_error(), "delta_from_largest_observed too high")); @@ -4202,8 +4205,8 @@ QuicEncryptedPacket encrypted( AsChars(framer_.transport_version() >= QUIC_VERSION_46 ? packet46 : packet), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet), + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet), false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsError(QUIC_INVALID_STOP_WAITING_DATA)); @@ -5082,10 +5085,10 @@ : (framer_.transport_version() >= QUIC_VERSION_46 ? packet46 : packet)), VersionHasIetfQuicFrames(framer_.transport_version()) - ? QUIC_ARRAYSIZE(packet99) + ? QUICHE_ARRAYSIZE(packet99) : (framer_.transport_version() >= QUIC_VERSION_46 - ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)), + ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)), false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -5325,7 +5328,8 @@ return; } - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); ASSERT_THAT(framer_.error(), IsError(QUIC_INVALID_PUBLIC_RST_PACKET)); EXPECT_EQ("Unable to read reset message.", framer_.detailed_error()); @@ -5426,7 +5430,8 @@ ENCRYPTION_ZERO_RTT, std::unique_ptr<QuicDecrypter>(decrypter_), false); } // This packet cannot be decrypted because diversification nonce is missing. - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); ASSERT_THAT(framer_.error(), IsQuicNoError()); ASSERT_TRUE(visitor_.stateless_reset_packet_.get()); @@ -5469,7 +5474,8 @@ ENCRYPTION_ZERO_RTT, std::unique_ptr<QuicDecrypter>(decrypter_), false); } // This packet cannot be decrypted because diversification nonce is missing. - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsError(QUIC_DECRYPTION_FAILURE)); ASSERT_FALSE(visitor_.stateless_reset_packet_); @@ -5589,10 +5595,10 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.version().HasLengthPrefixedConnectionIds()) { p = packet2; - p_length = QUIC_ARRAYSIZE(packet2); + p_length = QUICHE_ARRAYSIZE(packet2); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); @@ -5687,10 +5693,10 @@ // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -5733,7 +5739,8 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsError(QUIC_INVALID_PACKET_HEADER)); @@ -5810,8 +5817,8 @@ test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), AsChars(p), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)); + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildStreamFramePacketWithNewPaddingFrame) { @@ -5914,13 +5921,13 @@ ASSERT_TRUE(data != nullptr); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); @@ -5999,8 +6006,8 @@ test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), AsChars(p), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)); + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, Build2ByteSequenceNumberPaddingFramePacket) { @@ -6074,8 +6081,8 @@ test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), AsChars(p), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)); + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, Build1ByteSequenceNumberPaddingFramePacket) { @@ -6149,8 +6156,8 @@ test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), AsChars(p), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)); + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildStreamFramePacket) { @@ -6238,13 +6245,13 @@ ASSERT_TRUE(data != nullptr); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(p), p_size); @@ -6368,16 +6375,16 @@ ASSERT_TRUE(data != nullptr); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_size = QUIC_ARRAYSIZE(packet49); + p_size = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(p), p_size); @@ -6450,10 +6457,10 @@ // clang-format on unsigned char* packet = packet48; - size_t packet_size = QUIC_ARRAYSIZE(packet48); + size_t packet_size = QUICHE_ARRAYSIZE(packet48); if (framer_.transport_version() == QUIC_VERSION_99) { packet = packet99; - packet_size = QUIC_ARRAYSIZE(packet99); + packet_size = QUICHE_ARRAYSIZE(packet99); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -6588,13 +6595,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_size = QUIC_ARRAYSIZE(packet49); + p_size = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() > QUIC_VERSION_43) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicConnectionId connection_id = FramerTestConnectionId(); @@ -6641,7 +6648,7 @@ SupportedVersions(GetParam()))); test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildAckFramePacketOneAckBlock) { @@ -6722,13 +6729,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -6815,13 +6822,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -6963,13 +6970,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -7272,13 +7279,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -7326,7 +7333,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildRstFramePacketQuic) { @@ -7410,13 +7417,13 @@ ASSERT_TRUE(data != nullptr); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); @@ -7509,13 +7516,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -7614,13 +7621,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -7799,13 +7806,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -7864,7 +7871,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildTruncatedApplicationCloseFramePacket) { @@ -7946,7 +7953,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildGoAwayPacket) { @@ -8018,10 +8025,10 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() > QUIC_VERSION_43) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -8155,10 +8162,10 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() > QUIC_VERSION_43) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> data(BuildDataPacket(header, frames)); @@ -8239,13 +8246,13 @@ ASSERT_TRUE(data != nullptr); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } test::CompareCharArraysWithHexError("constructed packet", data->data(), @@ -8294,7 +8301,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildMaxDataPacket) { @@ -8338,7 +8345,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildBlockedPacket) { @@ -8411,13 +8418,13 @@ ASSERT_TRUE(data != nullptr); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } test::CompareCharArraysWithHexError("constructed packet", data->data(), @@ -8484,8 +8491,8 @@ test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), AsChars(p), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)); + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildMessagePacket) { @@ -8556,7 +8563,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(p), - QUIC_ARRAYSIZE(packet46)); + QUICHE_ARRAYSIZE(packet46)); } @@ -8621,8 +8628,8 @@ test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), AsChars(p), - framer_.transport_version() > QUIC_VERSION_43 ? QUIC_ARRAYSIZE(packet46) - : QUIC_ARRAYSIZE(packet)); + framer_.transport_version() > QUIC_VERSION_43 ? QUICHE_ARRAYSIZE(packet46) + : QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildPublicResetPacket) { @@ -8659,7 +8666,7 @@ ASSERT_TRUE(data != nullptr); test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildPublicResetPacketWithClientAddress) { @@ -8708,7 +8715,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, BuildPublicResetPacketWithEndpointId) { @@ -8782,11 +8789,11 @@ if ('d' == data->data()[data->length() - 1]) { test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), - AsChars(packet_variant1), QUIC_ARRAYSIZE(packet_variant1)); + AsChars(packet_variant1), QUICHE_ARRAYSIZE(packet_variant1)); } else { test::CompareCharArraysWithHexError( "constructed packet", data->data(), data->length(), - AsChars(packet_variant2), QUIC_ARRAYSIZE(packet_variant2)); + AsChars(packet_variant2), QUICHE_ARRAYSIZE(packet_variant2)); } } @@ -8818,7 +8825,7 @@ "constructed packet", data->data() + data->length() - sizeof(kTestStatelessResetToken), sizeof(kTestStatelessResetToken), - AsChars(packet) + QUIC_ARRAYSIZE(packet) - + AsChars(packet) + QUICHE_ARRAYSIZE(packet) - sizeof(kTestStatelessResetToken), sizeof(kTestStatelessResetToken)); } @@ -8874,10 +8881,10 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_50) { p = packet50; - p_size = QUIC_ARRAYSIZE(packet50); + p_size = QUICHE_ARRAYSIZE(packet50); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; } @@ -8959,14 +8966,14 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); // TODO(ianswett): see todo in previous test. if (framer_.transport_version() >= QUIC_VERSION_50) { p = packet50; - p_size = QUIC_ARRAYSIZE(packet50); + p_size = QUICHE_ARRAYSIZE(packet50); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<QuicPacket> raw(new QuicPacket( @@ -9242,13 +9249,13 @@ EXPECT_CALL(visitor, OnDecryptedPacket(_)); unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -9430,7 +9437,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, IetfStreamBlockedFrame) { @@ -9518,7 +9525,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BiDiMaxStreamsFrame) { @@ -9718,7 +9725,7 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet99), QUIC_ARRAYSIZE(packet99), + QuicEncryptedPacket encrypted(AsChars(packet99), QUICHE_ARRAYSIZE(packet99), false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsQuicNoError()); @@ -9755,7 +9762,7 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet99), QUIC_ARRAYSIZE(packet99), + QuicEncryptedPacket encrypted(AsChars(packet99), QUICHE_ARRAYSIZE(packet99), false); QuicFramerPeer::SetPerspective(&framer_, Perspective::IS_CLIENT); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -9795,7 +9802,7 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet99), QUIC_ARRAYSIZE(packet99), + QuicEncryptedPacket encrypted(AsChars(packet99), QUICHE_ARRAYSIZE(packet99), false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -9833,7 +9840,7 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet99), QUIC_ARRAYSIZE(packet99), + QuicEncryptedPacket encrypted(AsChars(packet99), QUICHE_ARRAYSIZE(packet99), false); QuicFramerPeer::SetPerspective(&framer_, Perspective::IS_CLIENT); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); @@ -9871,7 +9878,7 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet99), QUIC_ARRAYSIZE(packet99), + QuicEncryptedPacket encrypted(AsChars(packet99), QUICHE_ARRAYSIZE(packet99), false); EXPECT_TRUE(framer_.ProcessPacket(encrypted)); } @@ -10073,7 +10080,7 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet99), QUIC_ARRAYSIZE(packet99), + QuicEncryptedPacket encrypted(AsChars(packet99), QUICHE_ARRAYSIZE(packet99), false); QuicFramerPeer::SetPerspective(&framer_, Perspective::IS_CLIENT); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); @@ -10167,7 +10174,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildUniStreamsBlockedPacket) { @@ -10209,7 +10216,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildBiDiMaxStreamsPacket) { @@ -10251,7 +10258,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, BuildUniDiMaxStreamsPacket) { @@ -10296,7 +10303,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, NewConnectionIdFrame) { @@ -10565,7 +10572,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, NewTokenFrame) { @@ -10659,7 +10666,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet), - QUIC_ARRAYSIZE(packet)); + QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicFramerTest, IetfStopSendingFrame) { @@ -10747,7 +10754,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, IetfPathChallengeFrame) { @@ -10830,7 +10837,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, IetfPathResponseFrame) { @@ -10913,7 +10920,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, GetRetransmittableControlFrameSize) { @@ -11718,7 +11725,7 @@ test::CompareCharArraysWithHexError("constructed packet", data->data(), data->length(), AsChars(packet99), - QUIC_ARRAYSIZE(packet99)); + QUICHE_ARRAYSIZE(packet99)); } TEST_P(QuicFramerTest, AckFrameWithInvalidLargestObserved) { @@ -11786,10 +11793,10 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; } @@ -11864,13 +11871,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); @@ -11972,13 +11979,13 @@ // clang-format on unsigned char* p = packet; - size_t p_size = QUIC_ARRAYSIZE(packet); + size_t p_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(framer_.transport_version())) { p = packet99; - p_size = QUIC_ARRAYSIZE(packet99); + p_size = QUICHE_ARRAYSIZE(packet99); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_size = QUIC_ARRAYSIZE(packet46); + p_size = QUICHE_ARRAYSIZE(packet46); } QuicEncryptedPacket encrypted(AsChars(p), p_size, false); @@ -12119,10 +12126,10 @@ // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() == QUIC_VERSION_99) { p = packet99; - p_length = QUIC_ARRAYSIZE(packet99); + p_length = QUICHE_ARRAYSIZE(packet99); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); @@ -12231,13 +12238,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_length = QUIC_ARRAYSIZE(packet46); + p_length = QUICHE_ARRAYSIZE(packet46); } // First attempt decryption without the handshake crypter. EXPECT_FALSE( @@ -12333,13 +12340,13 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } else if (framer_.transport_version() >= QUIC_VERSION_46) { p = packet46; - p_length = QUIC_ARRAYSIZE(packet46); + p_length = QUICHE_ARRAYSIZE(packet46); } EXPECT_FALSE( @@ -12497,10 +12504,10 @@ const size_t length_of_first_coalesced_packet = 46; unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() == QUIC_VERSION_99) { p = packet99; - p_length = QUIC_ARRAYSIZE(packet99); + p_length = QUICHE_ARRAYSIZE(packet99); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); @@ -12664,10 +12671,10 @@ // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() == QUIC_VERSION_99) { p = packet99; - p_length = QUIC_ARRAYSIZE(packet99); + p_length = QUICHE_ARRAYSIZE(packet99); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); @@ -12770,10 +12777,10 @@ // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() == QUIC_VERSION_99) { p = packet99; - p_length = QUIC_ARRAYSIZE(packet99); + p_length = QUICHE_ARRAYSIZE(packet99); } QuicEncryptedPacket encrypted(AsChars(p), p_length, false); @@ -12833,7 +12840,7 @@ unsigned char packet[kMaxOutgoingPacketSize] = {}; size_t encrypted_length = framer_.EncryptPayload(ENCRYPTION_INITIAL, header.packet_number, *data, - AsChars(packet), QUIC_ARRAYSIZE(packet)); + AsChars(packet), QUICHE_ARRAYSIZE(packet)); ASSERT_NE(0u, encrypted_length); QuicFramerPeer::SetPerspective(&framer_, Perspective::IS_SERVER); @@ -12845,7 +12852,8 @@ std::move(server_crypters.decrypter)); // Make sure the first long header initial packet parses correctly. - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); // Make sure we discard the subsequent zeroes. EXPECT_QUIC_PEER_BUG(EXPECT_TRUE(framer_.ProcessPacket(encrypted)), @@ -12876,7 +12884,8 @@ }; // clang-format on - QuicEncryptedPacket encrypted(AsChars(packet), QUIC_ARRAYSIZE(packet), false); + QuicEncryptedPacket encrypted(AsChars(packet), QUICHE_ARRAYSIZE(packet), + false); EXPECT_FALSE(framer_.ProcessPacket(encrypted)); EXPECT_THAT(framer_.error(), IsError(QUIC_INVALID_VERSION)); @@ -13000,11 +13009,11 @@ if (!QuicVersionHasLongHeaderLengths(framer_.transport_version())) { EXPECT_TRUE(framer_.ProcessPacket( QuicEncryptedPacket(AsChars(long_header_packet), - QUIC_ARRAYSIZE(long_header_packet), false))); + QUICHE_ARRAYSIZE(long_header_packet), false))); } else { EXPECT_TRUE(framer_.ProcessPacket( QuicEncryptedPacket(AsChars(long_header_packet99), - QUIC_ARRAYSIZE(long_header_packet99), false))); + QUICHE_ARRAYSIZE(long_header_packet99), false))); } EXPECT_THAT(framer_.error(), IsQuicNoError()); @@ -13031,7 +13040,8 @@ // clang-format on QuicEncryptedPacket short_header_encrypted( - AsChars(short_header_packet), QUIC_ARRAYSIZE(short_header_packet), false); + AsChars(short_header_packet), QUICHE_ARRAYSIZE(short_header_packet), + false); if (framer_.version().KnowsWhichDecrypterToUse()) { framer_.InstallDecrypter(ENCRYPTION_FORWARD_SECURE, std::make_unique<TestDecrypter>()); @@ -13621,10 +13631,10 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } const bool parse_success = framer_.ProcessPacket(QuicEncryptedPacket(AsChars(p), p_length, false)); @@ -13687,10 +13697,10 @@ }; // clang-format on unsigned char* p = packet; - size_t p_length = QUIC_ARRAYSIZE(packet); + size_t p_length = QUICHE_ARRAYSIZE(packet); if (framer_.transport_version() >= QUIC_VERSION_49) { p = packet49; - p_length = QUIC_ARRAYSIZE(packet49); + p_length = QUICHE_ARRAYSIZE(packet49); } const bool parse_success = framer_.ProcessPacket(QuicEncryptedPacket(AsChars(p), p_length, false)); @@ -13910,8 +13920,8 @@ }; // clang-format on - framer_.ProcessPacket( - QuicEncryptedPacket(AsChars(packet99), QUIC_ARRAYSIZE(packet99), false)); + framer_.ProcessPacket(QuicEncryptedPacket(AsChars(packet99), + QUICHE_ARRAYSIZE(packet99), false)); ASSERT_EQ(1u, visitor_.ack_frames_.size()); // Verify ack_delay_time is set correctly. EXPECT_EQ(QuicTime::Delta::Infinite(),
diff --git a/quic/core/quic_ietf_framer_test.cc b/quic/core/quic_ietf_framer_test.cc index 3dd7a82..07f933d 100644 --- a/quic/core/quic_ietf_framer_test.cc +++ b/quic/core/quic_ietf_framer_test.cc
@@ -31,13 +31,13 @@ #include "net/third_party/quiche/src/quic/core/quic_data_writer.h" #include "net/third_party/quiche/src/quic/core/quic_packets.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_framer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/simple_data_producer.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -733,7 +733,7 @@ "input and output are the same!"; size_t transmit_packet_data_len = strlen(transmit_packet_data) + 1; - for (size_t i = 0; i < QUIC_ARRAYSIZE(stream_frame_to_test); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(stream_frame_to_test); ++i) { SCOPED_TRACE(i); struct stream_frame_variant* variant = &stream_frame_to_test[i]; TryStreamFrame(packet_buffer, sizeof(packet_buffer), transmit_packet_data, @@ -746,7 +746,7 @@ TEST_F(QuicIetfFramerTest, ZeroLengthStreamFrame) { char packet_buffer[kNormalPacketBufferSize]; - for (size_t i = 0; i < QUIC_ARRAYSIZE(stream_frame_to_test); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(stream_frame_to_test); ++i) { SCOPED_TRACE(i); struct stream_frame_variant* variant = &stream_frame_to_test[i]; TryStreamFrame(packet_buffer, sizeof(packet_buffer), @@ -770,7 +770,7 @@ QuicCryptoFrame frame(ENCRYPTION_INITIAL, offset, frame_data.length()); data_producer.SaveCryptoData(ENCRYPTION_INITIAL, offset, frame_data); - QuicDataWriter writer(QUIC_ARRAYSIZE(packet_buffer), packet_buffer, + QuicDataWriter writer(QUICHE_ARRAYSIZE(packet_buffer), packet_buffer, quiche::NETWORK_BYTE_ORDER); // Write the frame.
diff --git a/quic/core/quic_packet_creator.cc b/quic/core/quic_packet_creator.cc index 3b1a77a..ce919df 100644 --- a/quic/core/quic_packet_creator.cc +++ b/quic/core/quic_packet_creator.cc
@@ -21,12 +21,12 @@ #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/platform/api/quic_aligned.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_server_stats.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h"
diff --git a/quic/core/quic_packet_creator_test.cc b/quic/core/quic_packet_creator_test.cc index 56c62cb..0134fb6 100644 --- a/quic/core/quic_packet_creator_test.cc +++ b/quic/core/quic_packet_creator_test.cc
@@ -20,7 +20,6 @@ #include "net/third_party/quiche/src/quic/core/quic_simple_buffer_allocator.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" @@ -31,6 +30,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/simple_data_producer.h" #include "net/third_party/quiche/src/quic/test_tools/simple_quic_framer.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -652,9 +652,9 @@ MockRandom randomizer; size_t length = creator_.BuildPaddedPathChallengePacket( - header, buffer.get(), QUIC_ARRAYSIZE(packet), &payload, &randomizer, + header, buffer.get(), QUICHE_ARRAYSIZE(packet), &payload, &randomizer, ENCRYPTION_INITIAL); - EXPECT_EQ(length, QUIC_ARRAYSIZE(packet)); + EXPECT_EQ(length, QUICHE_ARRAYSIZE(packet)); // Payload has the random bytes that were generated. Copy them into packet, // above, before checking that the generated packet is correct. @@ -665,7 +665,7 @@ test::CompareCharArraysWithHexError( "constructed packet", data.data(), data.length(), - reinterpret_cast<char*>(packet), QUIC_ARRAYSIZE(packet)); + reinterpret_cast<char*>(packet), QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicPacketCreatorTest, BuildConnectivityProbingPacket) { @@ -723,13 +723,13 @@ // clang-format on unsigned char* p = packet; - size_t packet_size = QUIC_ARRAYSIZE(packet); + size_t packet_size = QUICHE_ARRAYSIZE(packet); if (VersionHasIetfQuicFrames(creator_.transport_version())) { p = packet99; - packet_size = QUIC_ARRAYSIZE(packet99); + packet_size = QUICHE_ARRAYSIZE(packet99); } else if (creator_.transport_version() >= QUIC_VERSION_46) { p = packet46; - packet_size = QUIC_ARRAYSIZE(packet46); + packet_size = QUICHE_ARRAYSIZE(packet46); } std::unique_ptr<char[]> buffer(new char[kMaxOutgoingPacketSize]); @@ -784,15 +784,15 @@ QuicDeque<QuicPathFrameBuffer> payloads; payloads.push_back(payload0); size_t length = creator_.BuildPathResponsePacket( - header, buffer.get(), QUIC_ARRAYSIZE(packet), payloads, + header, buffer.get(), QUICHE_ARRAYSIZE(packet), payloads, /*is_padded=*/false, ENCRYPTION_INITIAL); - EXPECT_EQ(length, QUIC_ARRAYSIZE(packet)); + EXPECT_EQ(length, QUICHE_ARRAYSIZE(packet)); QuicPacket data(creator_.transport_version(), buffer.release(), length, true, header); test::CompareCharArraysWithHexError( "constructed packet", data.data(), data.length(), - reinterpret_cast<char*>(packet), QUIC_ARRAYSIZE(packet)); + reinterpret_cast<char*>(packet), QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicPacketCreatorTest, BuildPathResponsePacket1ResponsePadded) { @@ -831,15 +831,15 @@ QuicDeque<QuicPathFrameBuffer> payloads; payloads.push_back(payload0); size_t length = creator_.BuildPathResponsePacket( - header, buffer.get(), QUIC_ARRAYSIZE(packet), payloads, + header, buffer.get(), QUICHE_ARRAYSIZE(packet), payloads, /*is_padded=*/true, ENCRYPTION_INITIAL); - EXPECT_EQ(length, QUIC_ARRAYSIZE(packet)); + EXPECT_EQ(length, QUICHE_ARRAYSIZE(packet)); QuicPacket data(creator_.transport_version(), buffer.release(), length, true, header); test::CompareCharArraysWithHexError( "constructed packet", data.data(), data.length(), - reinterpret_cast<char*>(packet), QUIC_ARRAYSIZE(packet)); + reinterpret_cast<char*>(packet), QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicPacketCreatorTest, BuildPathResponsePacket3ResponsesUnpadded) { @@ -883,15 +883,15 @@ payloads.push_back(payload1); payloads.push_back(payload2); size_t length = creator_.BuildPathResponsePacket( - header, buffer.get(), QUIC_ARRAYSIZE(packet), payloads, + header, buffer.get(), QUICHE_ARRAYSIZE(packet), payloads, /*is_padded=*/false, ENCRYPTION_INITIAL); - EXPECT_EQ(length, QUIC_ARRAYSIZE(packet)); + EXPECT_EQ(length, QUICHE_ARRAYSIZE(packet)); QuicPacket data(creator_.transport_version(), buffer.release(), length, true, header); test::CompareCharArraysWithHexError( "constructed packet", data.data(), data.length(), - reinterpret_cast<char*>(packet), QUIC_ARRAYSIZE(packet)); + reinterpret_cast<char*>(packet), QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicPacketCreatorTest, BuildPathResponsePacket3ResponsesPadded) { @@ -937,15 +937,15 @@ payloads.push_back(payload1); payloads.push_back(payload2); size_t length = creator_.BuildPathResponsePacket( - header, buffer.get(), QUIC_ARRAYSIZE(packet), payloads, + header, buffer.get(), QUICHE_ARRAYSIZE(packet), payloads, /*is_padded=*/true, ENCRYPTION_INITIAL); - EXPECT_EQ(length, QUIC_ARRAYSIZE(packet)); + EXPECT_EQ(length, QUICHE_ARRAYSIZE(packet)); QuicPacket data(creator_.transport_version(), buffer.release(), length, true, header); test::CompareCharArraysWithHexError( "constructed packet", data.data(), data.length(), - reinterpret_cast<char*>(packet), QUIC_ARRAYSIZE(packet)); + reinterpret_cast<char*>(packet), QUICHE_ARRAYSIZE(packet)); } TEST_P(QuicPacketCreatorTest, SerializeConnectivityProbingPacket) {
diff --git a/quic/core/quic_packet_reader.cc b/quic/core/quic_packet_reader.cc index bd46c69..81d2a7d 100644 --- a/quic/core/quic_packet_reader.cc +++ b/quic/core/quic_packet_reader.cc
@@ -14,7 +14,6 @@ #include "net/third_party/quiche/src/quic/core/quic_packets.h" #include "net/third_party/quiche/src/quic/core/quic_process_packet_interface.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" @@ -22,6 +21,7 @@ #include "net/third_party/quiche/src/quic/platform/api/quic_server_stats.h" #include "net/third_party/quiche/src/quic/platform/api/quic_socket_address.h" #include "net/quic/platform/impl/quic_socket_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #ifndef SO_RXQ_OVFL #define SO_RXQ_OVFL 40 @@ -201,9 +201,9 @@ QuicSocketAddress peer_address; QuicIpAddress self_ip; QuicWallTime walltimestamp = QuicWallTime::Zero(); - int bytes_read = - QuicSocketUtils::ReadPacket(fd, buf, QUIC_ARRAYSIZE(buf), packets_dropped, - &self_ip, &walltimestamp, &peer_address); + int bytes_read = QuicSocketUtils::ReadPacket(fd, buf, QUICHE_ARRAYSIZE(buf), + packets_dropped, &self_ip, + &walltimestamp, &peer_address); if (bytes_read < 0) { return false; // ReadPacket failed. }
diff --git a/quic/core/quic_sent_packet_manager_test.cc b/quic/core/quic_sent_packet_manager_test.cc index fd130fa..ccbd88e 100644 --- a/quic/core/quic_sent_packet_manager_test.cc +++ b/quic/core/quic_sent_packet_manager_test.cc
@@ -7,12 +7,12 @@ #include <memory> #include <utility> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_sent_packet_manager_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" using testing::_; @@ -341,10 +341,10 @@ SendDataPacket(1); uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); uint64_t retransmittable[] = {1}; VerifyRetransmittablePackets(retransmittable, - QUIC_ARRAYSIZE(retransmittable)); + QUICHE_ARRAYSIZE(retransmittable)); } TEST_F(QuicSentPacketManagerTest, IsUnAckedRetransmit) { @@ -353,7 +353,7 @@ EXPECT_TRUE(QuicSentPacketManagerPeer::IsRetransmission(&manager_, 2)); uint64_t unacked[] = {1, 2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); std::vector<uint64_t> retransmittable = {1, 2}; VerifyRetransmittablePackets(&retransmittable[0], retransmittable.size()); } @@ -373,7 +373,7 @@ EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); // Packet 1 is unacked, pending, but not retransmittable. uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); EXPECT_TRUE(manager_.HasInFlightPackets()); VerifyRetransmittablePackets(nullptr, 0); } @@ -396,7 +396,7 @@ EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); uint64_t unacked[] = {2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); // We do not know packet 2 is a spurious retransmission until it gets acked. VerifyRetransmittablePackets(nullptr, 0); EXPECT_EQ(0u, stats_.packets_spuriously_retransmitted); @@ -411,7 +411,7 @@ EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); EXPECT_EQ(0u, stats_.packets_spuriously_retransmitted); } @@ -433,7 +433,7 @@ EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); // 2 remains unacked, but no packets have retransmittable data. uint64_t unacked[] = {2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); EXPECT_TRUE(manager_.HasInFlightPackets()); VerifyRetransmittablePackets(nullptr, 0); // Ack 2 causes 2 be considered as spurious retransmission. @@ -513,7 +513,7 @@ ENCRYPTION_INITIAL)); uint64_t unacked[] = {2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); EXPECT_FALSE(manager_.HasInFlightPackets()); VerifyRetransmittablePackets(nullptr, 0); @@ -546,7 +546,7 @@ // Since 2 was marked for retransmit, when 1 is acked, 2 is kept for RTT. uint64_t unacked[] = {2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); EXPECT_FALSE(manager_.HasInFlightPackets()); VerifyRetransmittablePackets(nullptr, 0); @@ -583,7 +583,7 @@ // 2 and 3 remain unacked, but no packets have retransmittable data. uint64_t unacked[] = {2, 3}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); EXPECT_TRUE(manager_.HasInFlightPackets()); VerifyRetransmittablePackets(nullptr, 0); @@ -594,7 +594,7 @@ .WillOnce(Return(false)) .WillRepeatedly(Return(true)); uint64_t acked[] = {3, 4}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(4), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(3), QuicPacketNumber(5)); @@ -604,7 +604,7 @@ ENCRYPTION_INITIAL)); uint64_t unacked2[] = {2}; - VerifyUnackedPackets(unacked2, QUIC_ARRAYSIZE(unacked2)); + VerifyUnackedPackets(unacked2, QUICHE_ARRAYSIZE(unacked2)); EXPECT_TRUE(manager_.HasInFlightPackets()); SendDataPacket(5); @@ -625,7 +625,7 @@ ENCRYPTION_INITIAL)); uint64_t unacked3[] = {2}; - VerifyUnackedPackets(unacked3, QUIC_ARRAYSIZE(unacked3)); + VerifyUnackedPackets(unacked3, QUICHE_ARRAYSIZE(unacked3)); EXPECT_FALSE(manager_.HasInFlightPackets()); // Spurious retransmission is detected when packet 3 gets acked. We cannot // know packet 2 is a spurious until it gets acked. @@ -671,7 +671,7 @@ // Ack 3, which causes SpuriousRetransmitDetected to be called. { uint64_t acked[] = {3}; - ExpectAcksAndLosses(false, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(false, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); EXPECT_CALL(*loss_algorithm, DetectLosses(_, _, _, _, _, _)); EXPECT_CALL(*loss_algorithm, SpuriousLossDetected(_, _, _, QuicPacketNumber(3), @@ -715,7 +715,7 @@ // Now ack the ack and expect an RTT update. uint64_t acked[] = {1, 2}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(2), QuicTime::Delta::FromMilliseconds(5), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(1), QuicPacketNumber(3)); @@ -728,7 +728,7 @@ // Now ack the ack and expect only an RTT update. uint64_t acked2[] = {3}; - ExpectAcksAndLosses(true, acked2, QUIC_ARRAYSIZE(acked2), nullptr, 0); + ExpectAcksAndLosses(true, acked2, QUICHE_ARRAYSIZE(acked2), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(3), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(1), QuicPacketNumber(4)); @@ -874,8 +874,8 @@ SendDataPacket(5); uint64_t acked[] = {4, 5}; uint64_t lost[] = {1, 2}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), lost, - QUIC_ARRAYSIZE(lost)); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), lost, + QUICHE_ARRAYSIZE(lost)); // Frames in all packets are acked. EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); // Notify session that stream frame in packets 1 and 2 get lost although @@ -1005,8 +1005,8 @@ // Crypto packets remain in flight, so any that aren't acked will be lost. uint64_t acked[] = {3, 4, 5, 8, 9}; uint64_t lost[] = {1, 2, 6}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), lost, - QUIC_ARRAYSIZE(lost)); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), lost, + QUICHE_ARRAYSIZE(lost)); EXPECT_CALL(notifier_, OnFrameLost(_)).Times(3); EXPECT_CALL(notifier_, HasUnackedCryptoData()).WillRepeatedly(Return(false)); manager_.OnAckFrameStart(QuicPacketNumber(9), QuicTime::Delta::Infinite(), @@ -1057,7 +1057,7 @@ // Least unacked isn't raised until an ack is received, so ack the // crypto packets. uint64_t acked[] = {8, 9}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(9), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(8), QuicPacketNumber(10)); @@ -1086,7 +1086,7 @@ // Now ack the second crypto packet, and ensure the first gets removed, but // the third does not. uint64_t acked[] = {2}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); EXPECT_CALL(notifier_, HasUnackedCryptoData()).WillRepeatedly(Return(false)); EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); manager_.OnAckFrameStart(QuicPacketNumber(2), QuicTime::Delta::Infinite(), @@ -1098,7 +1098,7 @@ EXPECT_FALSE(manager_.HasUnackedCryptoPackets()); uint64_t unacked[] = {1, 3}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); } TEST_F(QuicSentPacketManagerTest, CryptoHandshakeTimeoutUnsentDataPacket) { @@ -1167,14 +1167,14 @@ manager_.NeuterUnencryptedPackets(); EXPECT_FALSE(manager_.HasUnackedCryptoPackets()); uint64_t unacked[] = {1, 2, 3}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); EXPECT_FALSE(manager_.HasUnackedCryptoPackets()); EXPECT_FALSE(manager_.HasInFlightPackets()); // Ensure both packets get discarded when packet 2 is acked. uint64_t acked[] = {3}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(3), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(3), QuicPacketNumber(4)); @@ -1636,7 +1636,7 @@ // Ack a packet before the first RTO and ensure the RTO timeout returns to the // original value and OnRetransmissionTimeout is not called or reverted. uint64_t acked[] = {1, 2}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(2), QuicTime::Delta::Zero(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(1), QuicPacketNumber(3)); @@ -2401,8 +2401,8 @@ // Ack [5, 7), [10, 12), [15, 17). uint64_t acked1[] = {5, 6, 10, 11, 15, 16}; uint64_t lost1[] = {1, 2, 3, 4, 7, 8, 9, 12, 13}; - ExpectAcksAndLosses(true, acked1, QUIC_ARRAYSIZE(acked1), lost1, - QUIC_ARRAYSIZE(lost1)); + ExpectAcksAndLosses(true, acked1, QUICHE_ARRAYSIZE(acked1), lost1, + QUICHE_ARRAYSIZE(lost1)); EXPECT_CALL(notifier_, OnFrameLost(_)).Times(AnyNumber()); manager_.OnAckFrameStart(QuicPacketNumber(16), QuicTime::Delta::Infinite(), clock_.Now()); @@ -2417,7 +2417,7 @@ // Ack [4, 8), [9, 13), [14, 21). uint64_t acked2[] = {4, 7, 9, 12, 14, 17, 18, 19, 20}; - ExpectAcksAndLosses(true, acked2, QUIC_ARRAYSIZE(acked2), nullptr, 0); + ExpectAcksAndLosses(true, acked2, QUICHE_ARRAYSIZE(acked2), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(20), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(14), QuicPacketNumber(21)); @@ -2436,8 +2436,8 @@ // Ack [5, 7), [10, 12), [15, 17). uint64_t acked1[] = {5, 6, 10, 11, 15, 16}; uint64_t lost1[] = {1, 2, 3, 4, 7, 8, 9, 12, 13}; - ExpectAcksAndLosses(true, acked1, QUIC_ARRAYSIZE(acked1), lost1, - QUIC_ARRAYSIZE(lost1)); + ExpectAcksAndLosses(true, acked1, QUICHE_ARRAYSIZE(acked1), lost1, + QUICHE_ARRAYSIZE(lost1)); EXPECT_CALL(notifier_, OnFrameLost(_)).Times(AnyNumber()); manager_.OnAckFrameStart(QuicPacketNumber(16), QuicTime::Delta::Infinite(), clock_.Now()); @@ -2450,7 +2450,7 @@ // Making sure reneged ACK does not harm. Ack [4, 8), [9, 13). uint64_t acked2[] = {4, 7, 9, 12}; - ExpectAcksAndLosses(true, acked2, QUIC_ARRAYSIZE(acked2), nullptr, 0); + ExpectAcksAndLosses(true, acked2, QUICHE_ARRAYSIZE(acked2), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(12), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(9), QuicPacketNumber(13)); @@ -2558,7 +2558,7 @@ manager_.GetLargestSentPacket(ENCRYPTION_FORWARD_SECURE)); // Ack all packets. uint64_t acked[] = {4, 6, 7, 8}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(8), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(4), QuicPacketNumber(9)); @@ -2628,7 +2628,7 @@ // Packet 1 gets acked in the wrong packet number space. Since packet 1 has // been acked in the correct packet number space, tolerate it. uint64_t acked[] = {2, 3}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(3), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(1), QuicPacketNumber(4)); @@ -2667,7 +2667,7 @@ // Received Ack of packets 1, 3 and 4. uint64_t acked[] = {1, 3, 4}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(4), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(3), QuicPacketNumber(5)); @@ -2680,8 +2680,8 @@ uint64_t loss[] = {2}; // Verify packet 2 is detected lost. EXPECT_CALL(notifier_, OnFrameLost(_)).Times(1); - ExpectAcksAndLosses(true, acked2, QUIC_ARRAYSIZE(acked2), loss, - QUIC_ARRAYSIZE(loss)); + ExpectAcksAndLosses(true, acked2, QUICHE_ARRAYSIZE(acked2), loss, + QUICHE_ARRAYSIZE(loss)); manager_.OnAckFrameStart(QuicPacketNumber(6), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(3), QuicPacketNumber(7)); @@ -2763,7 +2763,7 @@ // Received ACK for packets 1 and 2. uint64_t acked[] = {1, 2}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(2), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(1), QuicPacketNumber(3)); @@ -2958,7 +2958,7 @@ // Received ACK for packets 1 and 2. uint64_t acked[] = {1, 2}; - ExpectAcksAndLosses(true, acked, QUIC_ARRAYSIZE(acked), nullptr, 0); + ExpectAcksAndLosses(true, acked, QUICHE_ARRAYSIZE(acked), nullptr, 0); manager_.OnAckFrameStart(QuicPacketNumber(2), QuicTime::Delta::Infinite(), clock_.Now()); manager_.OnAckRange(QuicPacketNumber(1), QuicPacketNumber(3));
diff --git a/quic/core/quic_session_test.cc b/quic/core/quic_session_test.cc index ee3695a..4c7e112 100644 --- a/quic/core/quic_session_test.cc +++ b/quic/core/quic_session_test.cc
@@ -19,7 +19,6 @@ #include "net/third_party/quiche/src/quic/core/quic_stream.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_map_util.h" @@ -36,6 +35,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_stream_send_buffer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_str_cat.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -2523,8 +2523,8 @@ .Times(1); char data[1024]; std::vector<std::pair<char*, size_t>> buffers; - buffers.push_back(std::make_pair(data, QUIC_ARRAYSIZE(data))); - buffers.push_back(std::make_pair(data, QUIC_ARRAYSIZE(data))); + buffers.push_back(std::make_pair(data, QUICHE_ARRAYSIZE(data))); + buffers.push_back(std::make_pair(data, QUICHE_ARRAYSIZE(data))); QuicTestMemSliceVector vector(buffers); stream4->WriteMemSlices(vector.span(), false); }
diff --git a/quic/core/quic_socket_address_coder_test.cc b/quic/core/quic_socket_address_coder_test.cc index 7ab1383..cbfe04f 100644 --- a/quic/core/quic_socket_address_coder_test.cc +++ b/quic/core/quic_socket_address_coder_test.cc
@@ -6,8 +6,8 @@ #include <string> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -111,7 +111,7 @@ {"::1", 65534}, }; - for (size_t i = 0; i < QUIC_ARRAYSIZE(test_case); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(test_case); i++) { QuicIpAddress ip; ASSERT_TRUE(ip.FromString(test_case[i].ip_literal)); QuicSocketAddressCoder encoder(QuicSocketAddress(ip, test_case[i].port));
diff --git a/quic/core/quic_stream_sequencer_test.cc b/quic/core/quic_stream_sequencer_test.cc index e31abc9..216a60e 100644 --- a/quic/core/quic_stream_sequencer_test.cc +++ b/quic/core/quic_stream_sequencer_test.cc
@@ -13,13 +13,13 @@ #include "net/third_party/quiche/src/quic/core/quic_stream.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_stream_sequencer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" using testing::_; @@ -59,7 +59,7 @@ public: void ConsumeData(size_t num_bytes) { char buffer[1024]; - ASSERT_GT(QUIC_ARRAYSIZE(buffer), num_bytes); + ASSERT_GT(QUICHE_ARRAYSIZE(buffer), num_bytes); struct iovec iov; iov.iov_base = buffer; iov.iov_len = num_bytes; @@ -103,7 +103,7 @@ const std::vector<std::string>& expected) { iovec iovecs[5]; size_t num_iovecs = - sequencer.GetReadableRegions(iovecs, QUIC_ARRAYSIZE(iovecs)); + sequencer.GetReadableRegions(iovecs, QUICHE_ARRAYSIZE(iovecs)); return VerifyReadableRegion(sequencer, expected) && VerifyIovecs(sequencer, iovecs, num_iovecs, expected); } @@ -393,7 +393,7 @@ typedef std::vector<Frame> FrameList; void CreateFrames() { - int payload_size = QUIC_ARRAYSIZE(kPayload) - 1; + int payload_size = QUICHE_ARRAYSIZE(kPayload) - 1; int remaining_payload = payload_size; while (remaining_payload != 0) { int size = std::min(OneToN(6), remaining_payload); @@ -416,10 +416,10 @@ void ReadAvailableData() { // Read all available data - char output[QUIC_ARRAYSIZE(kPayload) + 1]; + char output[QUICHE_ARRAYSIZE(kPayload) + 1]; iovec iov; iov.iov_base = output; - iov.iov_len = QUIC_ARRAYSIZE(output); + iov.iov_len = QUICHE_ARRAYSIZE(output); int bytes_read = sequencer_->Readv(&iov, 1); EXPECT_NE(0, bytes_read); output_.append(output, bytes_read); @@ -455,9 +455,9 @@ list_.erase(list_.begin() + index); } - ASSERT_EQ(QUIC_ARRAYSIZE(kPayload) - 1, output_.size()); + ASSERT_EQ(QUICHE_ARRAYSIZE(kPayload) - 1, output_.size()); EXPECT_EQ(kPayload, output_); - EXPECT_EQ(QUIC_ARRAYSIZE(kPayload) - 1, total_bytes_consumed); + EXPECT_EQ(QUICHE_ARRAYSIZE(kPayload) - 1, total_bytes_consumed); } TEST_F(QuicSequencerRandomTest, RandomFramesNoDroppingBackup) { @@ -477,7 +477,7 @@ total_bytes_consumed += bytes; })); - while (output_.size() != QUIC_ARRAYSIZE(kPayload) - 1) { + while (output_.size() != QUICHE_ARRAYSIZE(kPayload) - 1) { if (!list_.empty() && OneToN(2) == 1) { // Send data int index = OneToN(list_.size()) - 1; OnFrame(list_[index].first, list_[index].second.data()); @@ -493,7 +493,7 @@ ASSERT_EQ(0, iovs_peeked); ASSERT_FALSE(sequencer_->GetReadableRegion(peek_iov)); } - int total_bytes_to_peek = QUIC_ARRAYSIZE(buffer); + int total_bytes_to_peek = QUICHE_ARRAYSIZE(buffer); for (int i = 0; i < iovs_peeked; ++i) { int bytes_to_peek = std::min<int>(peek_iov[i].iov_len, total_bytes_to_peek); @@ -510,7 +510,7 @@ } EXPECT_EQ(std::string(kPayload), output_); EXPECT_EQ(std::string(kPayload), peeked_); - EXPECT_EQ(QUIC_ARRAYSIZE(kPayload) - 1, total_bytes_consumed); + EXPECT_EQ(QUICHE_ARRAYSIZE(kPayload) - 1, total_bytes_consumed); } // Same as above, just using a different method for reading.
diff --git a/quic/core/quic_stream_test.cc b/quic/core/quic_stream_test.cc index 0a71787..c53504a 100644 --- a/quic/core/quic_stream_test.cc +++ b/quic/core/quic_stream_test.cc
@@ -16,7 +16,6 @@ #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/core/quic_write_blocked_list.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" @@ -31,6 +30,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_stream_sequencer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" using testing::_; @@ -1157,8 +1157,8 @@ Initialize(); char data[1024]; std::vector<std::pair<char*, size_t>> buffers; - buffers.push_back(std::make_pair(data, QUIC_ARRAYSIZE(data))); - buffers.push_back(std::make_pair(data, QUIC_ARRAYSIZE(data))); + buffers.push_back(std::make_pair(data, QUICHE_ARRAYSIZE(data))); + buffers.push_back(std::make_pair(data, QUICHE_ARRAYSIZE(data))); QuicTestMemSliceVector vector1(buffers); QuicTestMemSliceVector vector2(buffers); QuicMemSliceSpan span1 = vector1.span(); @@ -1173,7 +1173,7 @@ QuicConsumedData consumed = stream_->WriteMemSlices(span1, false); EXPECT_EQ(2048u, consumed.bytes_consumed); EXPECT_FALSE(consumed.fin_consumed); - EXPECT_EQ(2 * QUIC_ARRAYSIZE(data) - 100, stream_->BufferedDataBytes()); + EXPECT_EQ(2 * QUICHE_ARRAYSIZE(data) - 100, stream_->BufferedDataBytes()); EXPECT_FALSE(stream_->fin_buffered()); EXPECT_CALL(*session_, WritevData(_, _, _, _, _)).Times(0); @@ -1181,10 +1181,10 @@ consumed = stream_->WriteMemSlices(span2, true); EXPECT_EQ(0u, consumed.bytes_consumed); EXPECT_FALSE(consumed.fin_consumed); - EXPECT_EQ(2 * QUIC_ARRAYSIZE(data) - 100, stream_->BufferedDataBytes()); + EXPECT_EQ(2 * QUICHE_ARRAYSIZE(data) - 100, stream_->BufferedDataBytes()); EXPECT_FALSE(stream_->fin_buffered()); - size_t data_to_write = 2 * QUIC_ARRAYSIZE(data) - 100 - + size_t data_to_write = 2 * QUICHE_ARRAYSIZE(data) - 100 - GetQuicFlag(FLAGS_quic_buffered_data_threshold) + 1; EXPECT_CALL(*session_, WritevData(_, _, _, _, _)) .WillOnce(InvokeWithoutArgs([this, data_to_write]() { @@ -1201,7 +1201,7 @@ consumed = stream_->WriteMemSlices(span2, true); EXPECT_EQ(2048u, consumed.bytes_consumed); EXPECT_TRUE(consumed.fin_consumed); - EXPECT_EQ(2 * QUIC_ARRAYSIZE(data) + + EXPECT_EQ(2 * QUICHE_ARRAYSIZE(data) + GetQuicFlag(FLAGS_quic_buffered_data_threshold) - 1, stream_->BufferedDataBytes()); EXPECT_TRUE(stream_->fin_buffered()); @@ -1220,7 +1220,7 @@ QuicStreamPeer::SetStreamBytesWritten(kMaxStreamLength - 5u, stream_); char data[5]; std::vector<std::pair<char*, size_t>> buffers; - buffers.push_back(std::make_pair(data, QUIC_ARRAYSIZE(data))); + buffers.push_back(std::make_pair(data, QUICHE_ARRAYSIZE(data))); QuicTestMemSliceVector vector1(buffers); QuicMemSliceSpan span1 = vector1.span(); EXPECT_CALL(*session_, WritevData(_, _, _, _, _))
diff --git a/quic/core/quic_tag.cc b/quic/core/quic_tag.cc index bc0e28e..270383d 100644 --- a/quic/core/quic_tag.cc +++ b/quic/core/quic_tag.cc
@@ -7,9 +7,9 @@ #include <algorithm> #include <string> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" namespace quic { @@ -43,10 +43,10 @@ bool ascii = true; const QuicTag orig_tag = tag; - for (size_t i = 0; i < QUIC_ARRAYSIZE(chars); i++) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(chars); i++) { chars[i] = static_cast<char>(tag); if ((chars[i] == 0 || chars[i] == '\xff') && - i == QUIC_ARRAYSIZE(chars) - 1) { + i == QUICHE_ARRAYSIZE(chars) - 1) { chars[i] = ' '; } if (!isprint(static_cast<unsigned char>(chars[i]))) {
diff --git a/quic/core/quic_unacked_packet_map_test.cc b/quic/core/quic_unacked_packet_map_test.cc index 92e61e3..7439675 100644 --- a/quic/core/quic_unacked_packet_map_test.cc +++ b/quic/core/quic_unacked_packet_map_test.cc
@@ -8,10 +8,10 @@ #include "net/third_party/quiche/src/quic/core/frames/quic_stream_frame.h" #include "net/third_party/quiche/src/quic/core/quic_transmission_info.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_unacked_packet_map_peer.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" using testing::_; using testing::Return; @@ -172,7 +172,7 @@ unacked_packets_.AddSentPacket(&packet, NOT_RETRANSMISSION, now_, false); uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyInFlightPackets(nullptr, 0); VerifyRetransmittablePackets(nullptr, 0); @@ -188,18 +188,18 @@ unacked_packets_.AddSentPacket(&packet, NOT_RETRANSMISSION, now_, true); uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyRetransmittablePackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyRetransmittablePackets(unacked, QUICHE_ARRAYSIZE(unacked)); unacked_packets_.RemoveRetransmittability(QuicPacketNumber(1)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); unacked_packets_.IncreaseLargestAcked(QuicPacketNumber(1)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); unacked_packets_.RemoveFromInFlight(QuicPacketNumber(1)); @@ -214,15 +214,15 @@ unacked_packets_.AddSentPacket(&packet, NOT_RETRANSMISSION, now_, true); uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); uint64_t retransmittable[] = {1}; VerifyRetransmittablePackets(retransmittable, - QUIC_ARRAYSIZE(retransmittable)); + QUICHE_ARRAYSIZE(retransmittable)); EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); } @@ -232,16 +232,16 @@ unacked_packets_.AddSentPacket(&packet, NOT_RETRANSMISSION, now_, true); uint64_t unacked[] = {1}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); uint64_t retransmittable[] = {1}; VerifyRetransmittablePackets(retransmittable, - QUIC_ARRAYSIZE(retransmittable)); + QUICHE_ARRAYSIZE(retransmittable)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(retransmittable, - QUIC_ARRAYSIZE(retransmittable)); + QUICHE_ARRAYSIZE(retransmittable)); } TEST_P(QuicUnackedPacketMapTest, StopRetransmissionAfterRetransmission) { @@ -251,14 +251,14 @@ RetransmitAndSendPacket(1, 2, LOSS_RETRANSMISSION); uint64_t unacked[] = {1, 2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); std::vector<uint64_t> retransmittable = {1, 2}; VerifyRetransmittablePackets(&retransmittable[0], retransmittable.size()); EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); } @@ -270,26 +270,26 @@ RetransmitAndSendPacket(1, 2, LOSS_RETRANSMISSION); uint64_t unacked[] = {1, 2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); std::vector<uint64_t> retransmittable = {1, 2}; VerifyRetransmittablePackets(&retransmittable[0], retransmittable.size()); EXPECT_CALL(notifier_, IsFrameOutstanding(_)).WillRepeatedly(Return(false)); unacked_packets_.RemoveRetransmittability(QuicPacketNumber(1)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); unacked_packets_.IncreaseLargestAcked(QuicPacketNumber(2)); - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); VerifyRetransmittablePackets(nullptr, 0); unacked_packets_.RemoveFromInFlight(QuicPacketNumber(2)); uint64_t unacked2[] = {1}; - VerifyUnackedPackets(unacked2, QUIC_ARRAYSIZE(unacked2)); - VerifyInFlightPackets(unacked2, QUIC_ARRAYSIZE(unacked2)); + VerifyUnackedPackets(unacked2, QUICHE_ARRAYSIZE(unacked2)); + VerifyInFlightPackets(unacked2, QUICHE_ARRAYSIZE(unacked2)); VerifyRetransmittablePackets(nullptr, 0); unacked_packets_.RemoveFromInFlight(QuicPacketNumber(1)); @@ -306,11 +306,11 @@ unacked_packets_.AddSentPacket(&packet2, NOT_RETRANSMISSION, now_, true); uint64_t unacked[] = {1, 2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); uint64_t retransmittable[] = {1, 2}; VerifyRetransmittablePackets(retransmittable, - QUIC_ARRAYSIZE(retransmittable)); + QUICHE_ARRAYSIZE(retransmittable)); // Early retransmit 1 as 3 and send new data as 4. unacked_packets_.IncreaseLargestAcked(QuicPacketNumber(2)); @@ -322,9 +322,9 @@ unacked_packets_.AddSentPacket(&packet4, NOT_RETRANSMISSION, now_, true); uint64_t unacked2[] = {1, 3, 4}; - VerifyUnackedPackets(unacked2, QUIC_ARRAYSIZE(unacked2)); + VerifyUnackedPackets(unacked2, QUICHE_ARRAYSIZE(unacked2)); uint64_t pending2[] = {3, 4}; - VerifyInFlightPackets(pending2, QUIC_ARRAYSIZE(pending2)); + VerifyInFlightPackets(pending2, QUICHE_ARRAYSIZE(pending2)); std::vector<uint64_t> retransmittable2 = {1, 3, 4}; VerifyRetransmittablePackets(&retransmittable2[0], retransmittable2.size()); @@ -341,7 +341,7 @@ VerifyUnackedPackets(&unacked3[0], unacked3.size()); VerifyRetransmittablePackets(&retransmittable3[0], retransmittable3.size()); uint64_t pending3[] = {3, 5, 6}; - VerifyInFlightPackets(pending3, QUIC_ARRAYSIZE(pending3)); + VerifyInFlightPackets(pending3, QUICHE_ARRAYSIZE(pending3)); // Early retransmit 5 as 7 and ensure in flight packet 3 is not removed. unacked_packets_.IncreaseLargestAcked(QuicPacketNumber(6)); @@ -354,13 +354,13 @@ VerifyUnackedPackets(&unacked4[0], unacked4.size()); VerifyRetransmittablePackets(&retransmittable4[0], retransmittable4.size()); uint64_t pending4[] = {3, 5, 7}; - VerifyInFlightPackets(pending4, QUIC_ARRAYSIZE(pending4)); + VerifyInFlightPackets(pending4, QUICHE_ARRAYSIZE(pending4)); // Remove the older two transmissions from in flight. unacked_packets_.RemoveFromInFlight(QuicPacketNumber(3)); unacked_packets_.RemoveFromInFlight(QuicPacketNumber(5)); uint64_t pending5[] = {7}; - VerifyInFlightPackets(pending5, QUIC_ARRAYSIZE(pending5)); + VerifyInFlightPackets(pending5, QUICHE_ARRAYSIZE(pending5)); } TEST_P(QuicUnackedPacketMapTest, RetransmitFourTimes) { @@ -371,11 +371,11 @@ unacked_packets_.AddSentPacket(&packet2, NOT_RETRANSMISSION, now_, true); uint64_t unacked[] = {1, 2}; - VerifyUnackedPackets(unacked, QUIC_ARRAYSIZE(unacked)); - VerifyInFlightPackets(unacked, QUIC_ARRAYSIZE(unacked)); + VerifyUnackedPackets(unacked, QUICHE_ARRAYSIZE(unacked)); + VerifyInFlightPackets(unacked, QUICHE_ARRAYSIZE(unacked)); uint64_t retransmittable[] = {1, 2}; VerifyRetransmittablePackets(retransmittable, - QUIC_ARRAYSIZE(retransmittable)); + QUICHE_ARRAYSIZE(retransmittable)); // Early retransmit 1 as 3. unacked_packets_.IncreaseLargestAcked(QuicPacketNumber(2)); @@ -385,9 +385,9 @@ RetransmitAndSendPacket(1, 3, LOSS_RETRANSMISSION); uint64_t unacked2[] = {1, 3}; - VerifyUnackedPackets(unacked2, QUIC_ARRAYSIZE(unacked2)); + VerifyUnackedPackets(unacked2, QUICHE_ARRAYSIZE(unacked2)); uint64_t pending2[] = {3}; - VerifyInFlightPackets(pending2, QUIC_ARRAYSIZE(pending2)); + VerifyInFlightPackets(pending2, QUICHE_ARRAYSIZE(pending2)); std::vector<uint64_t> retransmittable2 = {1, 3}; VerifyRetransmittablePackets(&retransmittable2[0], retransmittable2.size()); @@ -397,9 +397,9 @@ unacked_packets_.AddSentPacket(&packet5, NOT_RETRANSMISSION, now_, true); uint64_t unacked3[] = {1, 3, 4, 5}; - VerifyUnackedPackets(unacked3, QUIC_ARRAYSIZE(unacked3)); + VerifyUnackedPackets(unacked3, QUICHE_ARRAYSIZE(unacked3)); uint64_t pending3[] = {3, 4, 5}; - VerifyInFlightPackets(pending3, QUIC_ARRAYSIZE(pending3)); + VerifyInFlightPackets(pending3, QUICHE_ARRAYSIZE(pending3)); std::vector<uint64_t> retransmittable3 = {1, 3, 4, 5}; VerifyRetransmittablePackets(&retransmittable3[0], retransmittable3.size()); @@ -414,7 +414,7 @@ std::vector<uint64_t> unacked4 = {4, 6}; VerifyUnackedPackets(&unacked4[0], unacked4.size()); uint64_t pending4[] = {6}; - VerifyInFlightPackets(pending4, QUIC_ARRAYSIZE(pending4)); + VerifyInFlightPackets(pending4, QUICHE_ARRAYSIZE(pending4)); std::vector<uint64_t> retransmittable4 = {4, 6}; VerifyRetransmittablePackets(&retransmittable4[0], retransmittable4.size()); }
diff --git a/quic/core/quic_utils.cc b/quic/core/quic_utils.cc index ef3af54..a695c94 100644 --- a/quic/core/quic_utils.cc +++ b/quic/core/quic_utils.cc
@@ -13,12 +13,12 @@ #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" #include "net/third_party/quiche/src/quic/platform/api/quic_aligned.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_prefetch.h" #include "net/third_party/quiche/src/quic/platform/api/quic_uint128.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" @@ -531,7 +531,7 @@ if (!VariableLengthConnectionIdAllowedForVersion(version)) { char connection_id_bytes[8] = {0, 0, 0, 0, 0, 0, 0, 0}; return QuicConnectionId(static_cast<char*>(connection_id_bytes), - QUIC_ARRAYSIZE(connection_id_bytes)); + QUICHE_ARRAYSIZE(connection_id_bytes)); } return EmptyQuicConnectionId(); }
diff --git a/quic/core/quic_utils_test.cc b/quic/core/quic_utils_test.cc index 2633bab..fa471f0 100644 --- a/quic/core/quic_utils_test.cc +++ b/quic/core/quic_utils_test.cc
@@ -8,9 +8,9 @@ #include "net/third_party/quiche/src/quic/core/crypto/crypto_protocol.h" #include "net/third_party/quiche/src/quic/core/quic_connection_id.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -214,10 +214,10 @@ QuicConnectionId connection_id = QuicUtils::CreateRandomConnectionId(&random); EXPECT_EQ(connection_id.length(), sizeof(uint64_t)); char connection_id_bytes[sizeof(uint64_t)]; - random.RandBytes(connection_id_bytes, QUIC_ARRAYSIZE(connection_id_bytes)); + random.RandBytes(connection_id_bytes, QUICHE_ARRAYSIZE(connection_id_bytes)); EXPECT_EQ(connection_id, QuicConnectionId(static_cast<char*>(connection_id_bytes), - QUIC_ARRAYSIZE(connection_id_bytes))); + QUICHE_ARRAYSIZE(connection_id_bytes))); EXPECT_NE(connection_id, EmptyQuicConnectionId()); EXPECT_NE(connection_id, TestConnectionId()); EXPECT_NE(connection_id, TestConnectionId(1)); @@ -233,10 +233,10 @@ QuicUtils::CreateRandomConnectionId(connection_id_length, &random); EXPECT_EQ(connection_id.length(), connection_id_length); char connection_id_bytes[connection_id_length]; - random.RandBytes(connection_id_bytes, QUIC_ARRAYSIZE(connection_id_bytes)); + random.RandBytes(connection_id_bytes, QUICHE_ARRAYSIZE(connection_id_bytes)); EXPECT_EQ(connection_id, QuicConnectionId(static_cast<char*>(connection_id_bytes), - QUIC_ARRAYSIZE(connection_id_bytes))); + QUICHE_ARRAYSIZE(connection_id_bytes))); EXPECT_NE(connection_id, EmptyQuicConnectionId()); EXPECT_NE(connection_id, TestConnectionId()); EXPECT_NE(connection_id, TestConnectionId(1));
diff --git a/quic/core/quic_version_manager.cc b/quic/core/quic_version_manager.cc index 0f21f01..8b25ecc 100644 --- a/quic/core/quic_version_manager.cc +++ b/quic/core/quic_version_manager.cc
@@ -4,12 +4,12 @@ #include "net/third_party/quiche/src/quic/core/quic_version_manager.h" +#include <algorithm> + #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" - -#include <algorithm> +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { @@ -24,7 +24,7 @@ disable_version_q046_(GetQuicReloadableFlag(quic_disable_version_q046)), disable_version_q043_(GetQuicReloadableFlag(quic_disable_version_q043)), allowed_supported_versions_(std::move(supported_versions)) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); RefilterSupportedVersions(); } @@ -43,7 +43,7 @@ } void QuicVersionManager::MaybeRefilterSupportedVersions() { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); if (enable_version_q099_ != GetQuicReloadableFlag(quic_enable_version_q099) || enable_version_t099_ != GetQuicReloadableFlag(quic_enable_version_t099) ||
diff --git a/quic/core/quic_version_manager_test.cc b/quic/core/quic_version_manager_test.cc index 89f15ac..7f3d83d 100644 --- a/quic/core/quic_version_manager_test.cc +++ b/quic/core/quic_version_manager_test.cc
@@ -5,9 +5,9 @@ #include "net/third_party/quiche/src/quic/core/quic_version_manager.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -16,7 +16,7 @@ class QuicVersionManagerTest : public QuicTest {}; TEST_F(QuicVersionManagerTest, QuicVersionManager) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); SetQuicReloadableFlag(quic_enable_version_q099, false); SetQuicReloadableFlag(quic_enable_version_t099, false);
diff --git a/quic/core/quic_versions.cc b/quic/core/quic_versions.cc index c387f3a..372d5d0 100644 --- a/quic/core/quic_versions.cc +++ b/quic/core/quic_versions.cc
@@ -9,11 +9,11 @@ #include "net/third_party/quiche/src/quic/core/crypto/quic_random.h" #include "net/third_party/quiche/src/quic/core/quic_tag.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flag_utils.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_text_utils.h" @@ -109,7 +109,7 @@ << parsed_version.handshake_protocol; return 0; } - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); switch (parsed_version.transport_version) { case QUIC_VERSION_43: @@ -354,7 +354,7 @@ return #x std::string QuicVersionToString(QuicTransportVersion transport_version) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); switch (transport_version) { RETURN_STRING_LITERAL(QUIC_VERSION_43); @@ -460,7 +460,7 @@ } void QuicEnableVersion(ParsedQuicVersion parsed_version) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); if (parsed_version.transport_version == QUIC_VERSION_99) { if (parsed_version.handshake_protocol == PROTOCOL_QUIC_CRYPTO) {
diff --git a/quic/core/quic_versions_test.cc b/quic/core/quic_versions_test.cc index 56ef26f..0c3ddec 100644 --- a/quic/core/quic_versions_test.cc +++ b/quic/core/quic_versions_test.cc
@@ -4,12 +4,12 @@ #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_mock_log.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -41,7 +41,7 @@ // Loop over all supported versions and make sure that we never hit the // default case (i.e. all supported versions should be successfully converted // to valid QuicVersionLabels). - for (size_t i = 0; i < QUIC_ARRAYSIZE(kSupportedTransportVersions); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kSupportedTransportVersions); ++i) { QuicTransportVersion version = kSupportedTransportVersions[i]; EXPECT_LT(0u, QuicVersionToQuicVersionLabel(version)); } @@ -66,7 +66,7 @@ EXPECT_EQ(QUIC_VERSION_43, QuicVersionLabelToQuicVersion(MakeQuicTag('3', '4', '0', 'Q'))); - for (size_t i = 0; i < QUIC_ARRAYSIZE(kSupportedTransportVersions); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kSupportedTransportVersions); ++i) { QuicTransportVersion version = kSupportedTransportVersions[i]; // Get the label from the version (we can loop over QuicVersions easily). @@ -99,7 +99,7 @@ EXPECT_QUIC_LOG_CALL(log).Times(0); log.StartCapturingLogs(); - for (size_t i = 0; i < QUIC_ARRAYSIZE(kSupportedTransportVersions); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kSupportedTransportVersions); ++i) { QuicVersionLabel version_label = QuicVersionToQuicVersionLabel(kSupportedTransportVersions[i]); EXPECT_EQ(PROTOCOL_QUIC_CRYPTO, @@ -206,7 +206,7 @@ QuicTransportVersion single_version[] = {QUIC_VERSION_43}; QuicTransportVersionVector versions_vector; - for (size_t i = 0; i < QUIC_ARRAYSIZE(single_version); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(single_version); ++i) { versions_vector.push_back(single_version[i]); } EXPECT_EQ("QUIC_VERSION_43", @@ -215,14 +215,14 @@ QuicTransportVersion multiple_versions[] = {QUIC_VERSION_UNSUPPORTED, QUIC_VERSION_43}; versions_vector.clear(); - for (size_t i = 0; i < QUIC_ARRAYSIZE(multiple_versions); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(multiple_versions); ++i) { versions_vector.push_back(multiple_versions[i]); } EXPECT_EQ("QUIC_VERSION_UNSUPPORTED,QUIC_VERSION_43", QuicTransportVersionVectorToString(versions_vector)); // Make sure that all supported versions are present in QuicVersionToString. - for (size_t i = 0; i < QUIC_ARRAYSIZE(kSupportedTransportVersions); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kSupportedTransportVersions); ++i) { QuicTransportVersion version = kSupportedTransportVersions[i]; EXPECT_NE("QUIC_VERSION_UNSUPPORTED", QuicVersionToString(version)); } @@ -254,7 +254,7 @@ } TEST_F(QuicVersionsTest, FilterSupportedVersionsAllVersions) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); SetQuicReloadableFlag(quic_enable_version_q099, true); SetQuicReloadableFlag(quic_enable_version_t099, true); @@ -289,7 +289,7 @@ } TEST_F(QuicVersionsTest, FilterSupportedVersionsNo99) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); SetQuicReloadableFlag(quic_enable_version_q099, false); SetQuicReloadableFlag(quic_enable_version_t099, false); @@ -319,7 +319,7 @@ } TEST_F(QuicVersionsTest, FilterSupportedVersionsNoFlags) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); SetQuicReloadableFlag(quic_enable_version_q099, false); SetQuicReloadableFlag(quic_enable_version_t099, false); @@ -385,7 +385,7 @@ // yet a typo was made in doing the #defines and it was caught // only in some test far removed from here... Better safe than sorry. TEST_F(QuicVersionsTest, CheckVersionNumbersForTypos) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); EXPECT_EQ(QUIC_VERSION_43, 43); EXPECT_EQ(QUIC_VERSION_46, 46); @@ -396,7 +396,7 @@ } TEST_F(QuicVersionsTest, AlpnForVersion) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); ParsedQuicVersion parsed_version_q048 = ParsedQuicVersion(PROTOCOL_QUIC_CRYPTO, QUIC_VERSION_48); @@ -419,7 +419,7 @@ } TEST_F(QuicVersionsTest, QuicEnableVersion) { - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); ParsedQuicVersion parsed_version_q099 = ParsedQuicVersion(PROTOCOL_QUIC_CRYPTO, QUIC_VERSION_99); @@ -464,7 +464,7 @@ QuicVersionReservedForNegotiation().transport_version); // QUIC_VERSION_RESERVED_FOR_NEGOTIATION MUST NOT be added to // kSupportedTransportVersions. - for (size_t i = 0; i < QUIC_ARRAYSIZE(kSupportedTransportVersions); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(kSupportedTransportVersions); ++i) { EXPECT_NE(QUIC_VERSION_RESERVED_FOR_NEGOTIATION, kSupportedTransportVersions[i]); }
diff --git a/quic/core/tls_handshaker.cc b/quic/core/tls_handshaker.cc index f937325..eccf275 100644 --- a/quic/core/tls_handshaker.cc +++ b/quic/core/tls_handshaker.cc
@@ -8,8 +8,8 @@ #include "third_party/boringssl/src/include/openssl/ssl.h" #include "net/third_party/quiche/src/quic/core/quic_crypto_stream.h" #include "net/third_party/quiche/src/quic/core/tls_client_handshaker.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic {
diff --git a/quic/core/tls_handshaker_test.cc b/quic/core/tls_handshaker_test.cc index 8d35e66..a6aa29a 100644 --- a/quic/core/tls_handshaker_test.cc +++ b/quic/core/tls_handshaker_test.cc
@@ -10,7 +10,6 @@ #include "net/third_party/quiche/src/quic/core/quic_utils.h" #include "net/third_party/quiche/src/quic/core/tls_client_handshaker.h" #include "net/third_party/quiche/src/quic/core/tls_server_handshaker.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" @@ -18,6 +17,7 @@ #include "net/third_party/quiche/src/quic/test_tools/mock_quic_session_visitor.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/tools/fake_proof_verifier.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" namespace quic { @@ -497,7 +497,7 @@ server_stream_->WriteCryptoData( ENCRYPTION_INITIAL, quiche::QuicheStringPiece(bogus_handshake_message, - QUIC_ARRAYSIZE(bogus_handshake_message))); + QUICHE_ARRAYSIZE(bogus_handshake_message))); server_stream_->SendCryptoMessagesToPeer(client_stream_); EXPECT_FALSE(client_stream_->handshake_confirmed()); @@ -515,7 +515,7 @@ client_stream_->WriteCryptoData( ENCRYPTION_INITIAL, quiche::QuicheStringPiece(bogus_handshake_message, - QUIC_ARRAYSIZE(bogus_handshake_message))); + QUICHE_ARRAYSIZE(bogus_handshake_message))); client_stream_->SendCryptoMessagesToPeer(server_stream_); EXPECT_FALSE(server_stream_->handshake_confirmed());
diff --git a/quic/platform/api/quic_arraysize.h b/quic/platform/api/quic_arraysize.h deleted file mode 100644 index eaa2a92..0000000 --- a/quic/platform/api/quic_arraysize.h +++ /dev/null
@@ -1,12 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef QUICHE_QUIC_PLATFORM_API_QUIC_ARRAYSIZE_H_ -#define QUICHE_QUIC_PLATFORM_API_QUIC_ARRAYSIZE_H_ - -#include "net/quic/platform/impl/quic_arraysize_impl.h" - -#define QUIC_ARRAYSIZE(array) QUIC_ARRAYSIZE_IMPL(array) - -#endif // QUICHE_QUIC_PLATFORM_API_QUIC_ARRAYSIZE_H_
diff --git a/quic/platform/api/quic_hostname_utils_test.cc b/quic/platform/api/quic_hostname_utils_test.cc index 2c6573b..eba97c4 100644 --- a/quic/platform/api/quic_hostname_utils_test.cc +++ b/quic/platform/api/quic_hostname_utils_test.cc
@@ -6,8 +6,8 @@ #include <string> -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -78,7 +78,7 @@ }; // clang-format on - for (size_t i = 0; i < QUIC_ARRAYSIZE(tests); ++i) { + for (size_t i = 0; i < QUICHE_ARRAYSIZE(tests); ++i) { EXPECT_EQ(std::string(tests[i].expected), QuicHostnameUtils::NormalizeHostname(tests[i].input)); }
diff --git a/quic/quic_transport/quic_transport_client_session_test.cc b/quic/quic_transport/quic_transport_client_session_test.cc index a1f9e28..613ef17 100644 --- a/quic/quic_transport/quic_transport_client_session_test.cc +++ b/quic/quic_transport/quic_transport_client_session_test.cc
@@ -12,7 +12,6 @@ #include "net/third_party/quiche/src/quic/core/quic_server_id.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_test.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" @@ -20,6 +19,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_stream_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_transport_test_tools.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -113,7 +113,7 @@ const std::string client_indication = DataInStream(client_indication_stream); const std::string expected_client_indication{ kTestOriginClientIndication, - QUIC_ARRAYSIZE(kTestOriginClientIndication) - 1}; + QUICHE_ARRAYSIZE(kTestOriginClientIndication) - 1}; EXPECT_EQ(client_indication, expected_client_indication); } @@ -138,7 +138,7 @@ const std::string client_indication = DataInStream(client_indication_stream); const std::string expected_client_indication{ kTestOriginClientIndication, - QUIC_ARRAYSIZE(kTestOriginClientIndication) - 1}; + QUICHE_ARRAYSIZE(kTestOriginClientIndication) - 1}; EXPECT_EQ(client_indication, expected_client_indication); }
diff --git a/quic/test_tools/fuzzing/quic_framer_process_data_packet_fuzzer.cc b/quic/test_tools/fuzzing/quic_framer_process_data_packet_fuzzer.cc index 21d4ed6..9b5d64d 100644 --- a/quic/test_tools/fuzzing/quic_framer_process_data_packet_fuzzer.cc +++ b/quic/test_tools/fuzzing/quic_framer_process_data_packet_fuzzer.cc
@@ -16,9 +16,9 @@ #include "net/third_party/quiche/src/quic/core/quic_time.h" #include "net/third_party/quiche/src/quic/core/quic_types.h" #include "net/third_party/quiche/src/quic/core/quic_versions.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/test_tools/quic_framer_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" using quic::DiversificationNonce; using quic::EncryptionLevel; @@ -66,7 +66,7 @@ return ParsedQuicVersion( quic::PROTOCOL_QUIC_CRYPTO, transport_versions[provider->ConsumeIntegralInRange<uint8_t>( - 0, QUIC_ARRAYSIZE(transport_versions) - 1)]); + 0, QUICHE_ARRAYSIZE(transport_versions) - 1)]); } // QuicSelfContainedPacketHeader is a QuicPacketHeader with built-in stroage for
diff --git a/quic/test_tools/quic_test_utils.cc b/quic/test_tools/quic_test_utils.cc index cf2569f..dca7697 100644 --- a/quic/test_tools/quic_test_utils.cc +++ b/quic/test_tools/quic_test_utils.cc
@@ -21,12 +21,12 @@ #include "net/third_party/quiche/src/quic/core/quic_framer.h" #include "net/third_party/quiche/src/quic/core/quic_packet_creator.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/test_tools/crypto_test_utils.h" #include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h" #include "net/third_party/quiche/src/quic/test_tools/quic_connection_peer.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_endian.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/spdy/core/spdy_frame_builder.h" @@ -165,7 +165,7 @@ char buffer[SHA_DIGEST_LENGTH]; SHA1(reinterpret_cast<const uint8_t*>(data.data()), data.size(), reinterpret_cast<uint8_t*>(buffer)); - return std::string(buffer, QUIC_ARRAYSIZE(buffer)); + return std::string(buffer, QUICHE_ARRAYSIZE(buffer)); } bool ClearControlFrame(const QuicFrame& frame) { @@ -835,7 +835,7 @@ // all flags have been flipped to true. return; } - static_assert(QUIC_ARRAYSIZE(kSupportedTransportVersions) == 6u, + static_assert(QUICHE_ARRAYSIZE(kSupportedTransportVersions) == 6u, "Supported versions out of sync"); SetQuicReloadableFlag(quic_disable_version_q050, false); SetQuicReloadableFlag(quic_disable_version_q049, false);
diff --git a/quic/tools/quic_server_test.cc b/quic/tools/quic_server_test.cc index 8c89443..6852e98 100644 --- a/quic/tools/quic_server_test.cc +++ b/quic/tools/quic_server_test.cc
@@ -8,7 +8,6 @@ #include "net/third_party/quiche/src/quic/core/quic_epoll_alarm_factory.h" #include "net/third_party/quiche/src/quic/core/quic_epoll_connection_helper.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_flags.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_port_utils.h" @@ -20,6 +19,7 @@ #include "net/third_party/quiche/src/quic/test_tools/quic_server_peer.h" #include "net/third_party/quiche/src/quic/tools/quic_memory_cache_backend.h" #include "net/third_party/quiche/src/quic/tools/quic_simple_crypto_server_stream_helper.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" namespace quic { namespace test { @@ -136,9 +136,9 @@ ASSERT_LT(0, fd); char buf[1024]; - memset(buf, 0, QUIC_ARRAYSIZE(buf)); + memset(buf, 0, QUICHE_ARRAYSIZE(buf)); sockaddr_storage storage = server_address_.generic_address(); - int rc = sendto(fd, buf, QUIC_ARRAYSIZE(buf), 0, + int rc = sendto(fd, buf, QUICHE_ARRAYSIZE(buf), 0, reinterpret_cast<sockaddr*>(&storage), sizeof(storage)); if (rc < 0) { QUIC_DLOG(INFO) << errno << " " << strerror(errno); @@ -202,7 +202,7 @@ }; // clang-format on QuicReceivedPacket encrypted_valid_packet( - reinterpret_cast<char*>(valid_packet), QUIC_ARRAYSIZE(valid_packet), + reinterpret_cast<char*>(valid_packet), QUICHE_ARRAYSIZE(valid_packet), QuicTime::Zero(), false); EXPECT_CALL(dispatcher_, ProcessPacket(_, _, _)).Times(1);
diff --git a/quic/tools/quic_simple_server_stream_test.cc b/quic/tools/quic_simple_server_stream_test.cc index b06b752..fccf6f8 100644 --- a/quic/tools/quic_simple_server_stream_test.cc +++ b/quic/tools/quic_simple_server_stream_test.cc
@@ -11,7 +11,6 @@ #include "net/third_party/quiche/src/quic/core/http/http_encoder.h" #include "net/third_party/quiche/src/quic/core/http/spdy_utils.h" #include "net/third_party/quiche/src/quic/core/quic_utils.h" -#include "net/third_party/quiche/src/quic/platform/api/quic_arraysize.h" #include "net/third_party/quiche/src/quic/platform/api/quic_expect_bug.h" #include "net/third_party/quiche/src/quic/platform/api/quic_ptr_util.h" #include "net/third_party/quiche/src/quic/platform/api/quic_socket_address.h" @@ -25,6 +24,7 @@ #include "net/third_party/quiche/src/quic/tools/quic_backend_response.h" #include "net/third_party/quiche/src/quic/tools/quic_memory_cache_backend.h" #include "net/third_party/quiche/src/quic/tools/quic_simple_server_session.h" +#include "net/third_party/quiche/src/common/platform/api/quiche_arraysize.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" using testing::_; @@ -685,7 +685,7 @@ 0x54, 0x54, 0x50, 0x2f, // TTP/ 0x31, 0x2e, 0x31, // 1.1 }; - quiche::QuicheStringPiece data(arr, QUIC_ARRAYSIZE(arr)); + quiche::QuicheStringPiece data(arr, QUICHE_ARRAYSIZE(arr)); QuicStreamFrame frame(stream_->id(), true, 0, data); // Verify that we don't crash when we get a invalid headers in stream frame. stream_->OnStreamFrame(frame);