Add ShouldUpdateExpectedConnectionIdLength to QuicFramer
ShouldUpdateExpectedConnectionIdLength allows clients of QuicDispatcher like Quartc to have the QuicFramer owned by the QuicDispatcher dynamically change its expected connection ID length based on received long header packets. This will allow quartc to migrate to 0-length connection IDs.
gfe-relnote: refactor-only, no behavior change, not flag protected
PiperOrigin-RevId: 237882443
Change-Id: If7a49b092e1ff29fec740a18bbb7c5b78d749d62
diff --git a/quic/quartc/quartc_dispatcher.cc b/quic/quartc/quartc_dispatcher.cc
index 8070203..4c35c54 100644
--- a/quic/quartc/quartc_dispatcher.cc
+++ b/quic/quartc/quartc_dispatcher.cc
@@ -21,18 +21,23 @@
std::unique_ptr<QuicAlarmFactory> alarm_factory,
std::unique_ptr<QuartcPacketWriter> packet_writer,
Delegate* delegate)
- : QuicDispatcher(config.get(),
- crypto_config.get(),
- version_manager,
- std::move(helper),
- std::move(session_helper),
- std::move(alarm_factory),
- kQuicDefaultConnectionIdLength),
+ : QuicDispatcher(
+ config.get(),
+ crypto_config.get(),
+ version_manager,
+ std::move(helper),
+ std::move(session_helper),
+ std::move(alarm_factory),
+ QuicUtils::CreateZeroConnectionId(
+ version_manager->GetSupportedVersions()[0].transport_version)
+ .length()),
owned_quic_config_(std::move(config)),
owned_crypto_config_(std::move(crypto_config)),
crypto_config_(crypto_config_serialized),
delegate_(delegate),
packet_writer_(packet_writer.get()) {
+ // Allow incoming packets to set our expected connection ID length.
+ SetShouldUpdateExpectedConnectionIdLength(true);
// QuicDispatcher takes ownership of the writer.
QuicDispatcher::InitializeWithWriter(packet_writer.release());
// NB: This must happen *after* InitializeWithWriter. It can call us back
@@ -50,6 +55,8 @@
const QuicSocketAddress& client_address,
QuicStringPiece alpn,
const ParsedQuicVersion& version) {
+ // Make our expected connection ID non-mutable since we have a connection.
+ SetShouldUpdateExpectedConnectionIdLength(false);
std::unique_ptr<QuicConnection> connection = CreateQuicConnection(
connection_id, client_address, helper(), alarm_factory(), writer(),
Perspective::IS_SERVER, ParsedQuicVersionVector{version});
