Move MockHttpDecoderVisitor from http_decoder_test.cc to quic_test_utils.h. This CL moves MockHttpDecoderVisitor to a test utility file in preparation for inclusion in metadata_manager_test.cc. PiperOrigin-RevId: 466129146
diff --git a/quiche/quic/core/http/http_decoder_test.cc b/quiche/quic/core/http/http_decoder_test.cc index a6c13a1..3ea97ca 100644 --- a/quiche/quic/core/http/http_decoder_test.cc +++ b/quiche/quic/core/http/http_decoder_test.cc
@@ -38,54 +38,6 @@ namespace { -class MockHttpDecoderVisitor : public HttpDecoder::Visitor { - public: - ~MockHttpDecoderVisitor() override = default; - - // Called if an error is detected. - MOCK_METHOD(void, OnError, (HttpDecoder*), (override)); - - MOCK_METHOD(bool, OnMaxPushIdFrame, (), (override)); - MOCK_METHOD(bool, OnGoAwayFrame, (const GoAwayFrame& frame), (override)); - MOCK_METHOD(bool, OnSettingsFrameStart, (QuicByteCount header_length), - (override)); - MOCK_METHOD(bool, OnSettingsFrame, (const SettingsFrame& frame), (override)); - - MOCK_METHOD(bool, OnDataFrameStart, - (QuicByteCount header_length, QuicByteCount payload_length), - (override)); - MOCK_METHOD(bool, OnDataFramePayload, (absl::string_view payload), - (override)); - MOCK_METHOD(bool, OnDataFrameEnd, (), (override)); - - MOCK_METHOD(bool, OnHeadersFrameStart, - (QuicByteCount header_length, QuicByteCount payload_length), - (override)); - MOCK_METHOD(bool, OnHeadersFramePayload, (absl::string_view payload), - (override)); - MOCK_METHOD(bool, OnHeadersFrameEnd, (), (override)); - - MOCK_METHOD(bool, OnPriorityUpdateFrameStart, (QuicByteCount header_length), - (override)); - MOCK_METHOD(bool, OnPriorityUpdateFrame, (const PriorityUpdateFrame& frame), - (override)); - - MOCK_METHOD(bool, OnAcceptChFrameStart, (QuicByteCount header_length), - (override)); - MOCK_METHOD(bool, OnAcceptChFrame, (const AcceptChFrame& frame), (override)); - MOCK_METHOD(void, OnWebTransportStreamFrameType, - (QuicByteCount header_length, WebTransportSessionId session_id), - (override)); - - MOCK_METHOD(bool, OnUnknownFrameStart, - (uint64_t frame_type, QuicByteCount header_length, - QuicByteCount payload_length), - (override)); - MOCK_METHOD(bool, OnUnknownFramePayload, (absl::string_view payload), - (override)); - MOCK_METHOD(bool, OnUnknownFrameEnd, (), (override)); -}; - class HttpDecoderTest : public QuicTest { public: HttpDecoderTest() : decoder_(&visitor_) {
diff --git a/quiche/quic/test_tools/quic_test_utils.h b/quiche/quic/test_tools/quic_test_utils.h index 66f2c60..5e1397c 100644 --- a/quiche/quic/test_tools/quic_test_utils.h +++ b/quiche/quic/test_tools/quic_test_utils.h
@@ -20,6 +20,7 @@ #include "quiche/quic/core/congestion_control/loss_detection_interface.h" #include "quiche/quic/core/congestion_control/send_algorithm_interface.h" #include "quiche/quic/core/crypto/transport_parameters.h" +#include "quiche/quic/core/http/http_decoder.h" #include "quiche/quic/core/http/quic_client_push_promise_index.h" #include "quiche/quic/core/http/quic_server_session_base.h" #include "quiche/quic/core/http/quic_spdy_session.h" @@ -1441,6 +1442,54 @@ (std::unique_ptr<QuicPathValidationContext>), (override)); }; +class MockHttpDecoderVisitor : public HttpDecoder::Visitor { + public: + ~MockHttpDecoderVisitor() override = default; + + // Called if an error is detected. + MOCK_METHOD(void, OnError, (HttpDecoder*), (override)); + + MOCK_METHOD(bool, OnMaxPushIdFrame, (), (override)); + MOCK_METHOD(bool, OnGoAwayFrame, (const GoAwayFrame& frame), (override)); + MOCK_METHOD(bool, OnSettingsFrameStart, (QuicByteCount header_length), + (override)); + MOCK_METHOD(bool, OnSettingsFrame, (const SettingsFrame& frame), (override)); + + MOCK_METHOD(bool, OnDataFrameStart, + (QuicByteCount header_length, QuicByteCount payload_length), + (override)); + MOCK_METHOD(bool, OnDataFramePayload, (absl::string_view payload), + (override)); + MOCK_METHOD(bool, OnDataFrameEnd, (), (override)); + + MOCK_METHOD(bool, OnHeadersFrameStart, + (QuicByteCount header_length, QuicByteCount payload_length), + (override)); + MOCK_METHOD(bool, OnHeadersFramePayload, (absl::string_view payload), + (override)); + MOCK_METHOD(bool, OnHeadersFrameEnd, (), (override)); + + MOCK_METHOD(bool, OnPriorityUpdateFrameStart, (QuicByteCount header_length), + (override)); + MOCK_METHOD(bool, OnPriorityUpdateFrame, (const PriorityUpdateFrame& frame), + (override)); + + MOCK_METHOD(bool, OnAcceptChFrameStart, (QuicByteCount header_length), + (override)); + MOCK_METHOD(bool, OnAcceptChFrame, (const AcceptChFrame& frame), (override)); + MOCK_METHOD(void, OnWebTransportStreamFrameType, + (QuicByteCount header_length, WebTransportSessionId session_id), + (override)); + + MOCK_METHOD(bool, OnUnknownFrameStart, + (uint64_t frame_type, QuicByteCount header_length, + QuicByteCount payload_length), + (override)); + MOCK_METHOD(bool, OnUnknownFramePayload, (absl::string_view payload), + (override)); + MOCK_METHOD(bool, OnUnknownFrameEnd, (), (override)); +}; + class QuicCryptoClientStreamPeer { public: QuicCryptoClientStreamPeer() = delete;