commit 498559895801a16347b42ef790b9080757d768cf
author wub <wub@google.com> Wed May 01 14:16:26 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed May 01 21:20:59 2019 -0700
tree ac29fdf7d08dc756959305339d21ce6a96eea634
parent 711bd180182438c31607c52eacbbf153343d0521

gfe-relnote: (n/a) Change SetQuicFlag to take the flag variable directly instead of a pointer to it. Refactor for Envoy integration, no behavior change.

This is needed for Envoy integration because the current syntax(SetQuicFlag(&FLAG_foo)) requires FLAG_foo is a valid c++ identifier, which is not the case in Envoy.

PiperOrigin-RevId: 246196929
Change-Id: I7d56b23f0fa51fcdd17acc0837508710316a6826

quic/core/quic_framer_test.cc

diff --git a/quic/core/quic_framer_test.cc b/quic/core/quic_framer_test.cc
index 0437118..a717168 100644
--- a/quic/core/quic_framer_test.cc
+++ b/quic/core/quic_framer_test.cc
@@ -430,7 +430,7 @@
 
 ParsedQuicVersionVector AllSupportedVersionsIncludingTls() {
   QuicFlagSaver flags;
-  SetQuicFlag(&FLAGS_quic_supports_tls_handshake, true);
+  SetQuicFlag(FLAGS_quic_supports_tls_handshake, true);
   return AllSupportedVersions();
 }
 
@@ -445,7 +445,7 @@
                 start_,
                 Perspective::IS_SERVER,
                 kQuicDefaultConnectionIdLength) {
-    SetQuicFlag(&FLAGS_quic_supports_tls_handshake, true);
+    SetQuicFlag(FLAGS_quic_supports_tls_handshake, true);
     framer_.set_version(version_);
     if (framer_.version().KnowsWhichDecrypterToUse()) {
       framer_.InstallDecrypter(ENCRYPTION_INITIAL,