commit 3f7bcbe4dce2d2cf957f6e0a6808ca492ad39c45
author fayang <fayang@google.com> Mon Feb 10 11:08:47 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Feb 10 11:09:20 2020 -0800
tree a2d959c05ff0e6abde08c72d456ae0c11272ce8d
parent 84259eb9a4190d506e6fb2f1b217def428b49980

gfe-relnote: In QUIC, split HandshakerDelegateInterface::OnNewKeysAvailable to OnNewDecryptionKeyAvailable and OnNewEncryptionKeyAvailable. Refactoring only, no behavior change, not protected.

PiperOrigin-RevId: 294260261
Change-Id: Iaa1e251970b555434833432098af11fbb0d28ebc

quic/core/quic_crypto_server_handshaker.cc

diff --git a/quic/core/quic_crypto_server_handshaker.cc b/quic/core/quic_crypto_server_handshaker.cc
index 4b2a7fa..2f1f061 100644
--- a/quic/core/quic_crypto_server_handshaker.cc
+++ b/quic/core/quic_crypto_server_handshaker.cc
@@ -200,12 +200,14 @@
   // write key.
   //
   // NOTE: the SHLO will be encrypted with the new server write key.
-  delegate_->OnNewKeysAvailable(
+  delegate_->OnNewEncryptionKeyAvailable(
+      ENCRYPTION_ZERO_RTT,
+      std::move(crypto_negotiated_params_->initial_crypters.encrypter));
+  delegate_->OnNewDecryptionKeyAvailable(
       ENCRYPTION_ZERO_RTT,
       std::move(crypto_negotiated_params_->initial_crypters.decrypter),
       /*set_alternative_decrypter=*/false,
-      /*latch_once_used=*/false,
-      std::move(crypto_negotiated_params_->initial_crypters.encrypter));
+      /*latch_once_used=*/false);
   delegate_->SetDefaultEncryptionLevel(ENCRYPTION_ZERO_RTT);
   delegate_->DiscardOldDecryptionKey(ENCRYPTION_INITIAL);
   session()->connection()->SetDiversificationNonce(*diversification_nonce);
@@ -213,12 +215,14 @@
   session()->connection()->set_fully_pad_crypto_handshake_packets(
       crypto_config_->pad_shlo());
   SendHandshakeMessage(*reply);
-  delegate_->OnNewKeysAvailable(
+  delegate_->OnNewEncryptionKeyAvailable(
+      ENCRYPTION_FORWARD_SECURE,
+      std::move(crypto_negotiated_params_->forward_secure_crypters.encrypter));
+  delegate_->OnNewDecryptionKeyAvailable(
       ENCRYPTION_FORWARD_SECURE,
       std::move(crypto_negotiated_params_->forward_secure_crypters.decrypter),
       /*set_alternative_decrypter=*/true,
-      /*latch_once_used=*/false,
-      std::move(crypto_negotiated_params_->forward_secure_crypters.encrypter));
+      /*latch_once_used=*/false);
   encryption_established_ = true;
   one_rtt_keys_available_ = true;
   delegate_->SetDefaultEncryptionLevel(ENCRYPTION_FORWARD_SECURE);