commit 3a364d8be909976d09276d1be9efb1d210ba3b14
author nharper <nharper@google.com> Thu May 07 13:31:27 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Thu May 07 13:32:05 2020 -0700
tree 19adb7e7bc3acea8278f9e80eed4d50124451f8e
parent 780461d7e12166e6a268c77251403468ae07f86b

Check for nullptr in TlsServerHandshaker

Add nullptr check, not flag protected

PiperOrigin-RevId: 310426354
Change-Id: I7a6d88377a1a551a66f3f9ce51fea682c30b4b0a

quic/core/tls_server_handshaker.cc

diff --git a/quic/core/tls_server_handshaker.cc b/quic/core/tls_server_handshaker.cc
index 229e568..c8fbda5 100644
--- a/quic/core/tls_server_handshaker.cc
+++ b/quic/core/tls_server_handshaker.cc
@@ -502,7 +502,7 @@
       proof_source_->GetCertChain(session()->connection()->self_address(),
                                   session()->connection()->peer_address(),
                                   hostname_);
-  if (chain->certs.empty()) {
+  if (!chain || chain->certs.empty()) {
     QUIC_LOG(ERROR) << "No certs provided for host '" << hostname_ << "'";
     return SSL_TLSEXT_ERR_ALERT_FATAL;
   }