commit 38c190b7c7111fb0c6321db9e0840290edea8186
author QUICHE team <quiche-dev@google.com> Wed May 08 09:12:01 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed May 08 13:47:14 2019 -0700
tree 58b138c157f8dc6cd6286b3b6a2ba92f0b793238
parent 87c39c1ba976f007fdcc8f2f4e02231c3217eb01

Add arguments to ProofVerifier::VerifyCertChain for stapled OCSP response and SignedCertificateTimestampList.

gfe-relnote: n/a - protected by existing disabled flag --quic_supports_tls_handshake
PiperOrigin-RevId: 247224979
Change-Id: I5ff6668c186eabf117b1605c86b65b0938ff3c38

quic/core/tls_handshaker_test.cc

diff --git a/quic/core/tls_handshaker_test.cc b/quic/core/tls_handshaker_test.cc
index f0b8e84..e710d7b 100644
--- a/quic/core/tls_handshaker_test.cc
+++ b/quic/core/tls_handshaker_test.cc
@@ -47,17 +47,20 @@
   QuicAsyncStatus VerifyCertChain(
       const std::string& hostname,
       const std::vector<std::string>& certs,
+      const std::string& ocsp_response,
+      const std::string& cert_sct,
       const ProofVerifyContext* context,
       std::string* error_details,
       std::unique_ptr<ProofVerifyDetails>* details,
       std::unique_ptr<ProofVerifierCallback> callback) override {
     if (!active_) {
-      return verifier_->VerifyCertChain(hostname, certs, context, error_details,
+      return verifier_->VerifyCertChain(hostname, certs, ocsp_response,
+                                        cert_sct, context, error_details,
                                         details, std::move(callback));
     }
     pending_ops_.push_back(QuicMakeUnique<VerifyChainPendingOp>(
-        hostname, certs, context, error_details, details, std::move(callback),
-        verifier_.get()));
+        hostname, certs, ocsp_response, cert_sct, context, error_details,
+        details, std::move(callback), verifier_.get()));
     return QUIC_PENDING;
   }
 
@@ -92,6 +95,8 @@
    public:
     VerifyChainPendingOp(const std::string& hostname,
                          const std::vector<std::string>& certs,
+                         const std::string& ocsp_response,
+                         const std::string& cert_sct,
                          const ProofVerifyContext* context,
                          std::string* error_details,
                          std::unique_ptr<ProofVerifyDetails>* details,
@@ -99,6 +104,8 @@
                          ProofVerifier* delegate)
         : hostname_(hostname),
           certs_(certs),
+          ocsp_response_(ocsp_response),
+          cert_sct_(cert_sct),
           context_(context),
           error_details_(error_details),
           details_(details),
@@ -111,7 +118,8 @@
       // runs the original callback after asserting that the verification ran
       // synchronously.
       QuicAsyncStatus status = delegate_->VerifyCertChain(
-          hostname_, certs_, context_, error_details_, details_,
+          hostname_, certs_, ocsp_response_, cert_sct_, context_,
+          error_details_, details_,
           QuicMakeUnique<FailingProofVerifierCallback>());
       ASSERT_NE(status, QUIC_PENDING);
       callback_->Run(status == QUIC_SUCCESS, *error_details_, details_);
@@ -120,6 +128,8 @@
    private:
     std::string hostname_;
     std::vector<std::string> certs_;
+    std::string ocsp_response_;
+    std::string cert_sct_;
     const ProofVerifyContext* context_;
     std::string* error_details_;
     std::unique_ptr<ProofVerifyDetails>* details_;