commit 36c47281b4ea4bd08b6da2eb8b7781027ddc2190
author bnc <bnc@google.com> Fri Jun 21 05:17:59 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Jun 21 13:04:46 2019 -0700
tree 2cc8f4b5dbdd0e32e9461148a582aaa55d51165f
parent 5f88b0c8a14b589a721449d84075024ad25b8c63

Refine QuicSpdyStream::UsesPendingStreams() behavior.

This is so that VersionHasStreamType(), which is an HTTP/3 concept, can be
removed from QuicStream, which lives in the transport layer.

gfe-relnote: n/a, no functional change.
PiperOrigin-RevId: 254379801
Change-Id: I6634dc77e85673166628b5912788cc8a41db2b57

quic/core/http/quic_spdy_session.cc

diff --git a/quic/core/http/quic_spdy_session.cc b/quic/core/http/quic_spdy_session.cc
index b4849ab..55ceb2a 100644
--- a/quic/core/http/quic_spdy_session.cc
+++ b/quic/core/http/quic_spdy_session.cc
@@ -577,8 +577,10 @@
 }
 
 bool QuicSpdySession::UsesPendingStreams() const {
-  DCHECK(VersionHasStreamType(connection()->transport_version()));
-  return true;
+  // QuicSpdySession supports PendingStreams, therefore this method should
+  // eventually just return true.  However, pending streams can only be used if
+  // unidirectional stream type is supported.
+  return VersionHasStreamType(connection()->transport_version());
 }
 
 size_t QuicSpdySession::WriteHeadersOnHeadersStreamImpl(

quic/core/quic_session.cc

diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index bb2a7b9..19b219d 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -200,8 +200,7 @@
     return;
   }
 
-  if (VersionHasStreamType(connection()->transport_version()) &&
-      UsesPendingStreams() &&
+  if (UsesPendingStreams() &&
       QuicUtils::GetStreamType(stream_id, perspective(),
                                IsIncomingStream(stream_id)) ==
           READ_UNIDIRECTIONAL &&
@@ -370,8 +369,7 @@
     visitor_->OnRstStreamReceived(frame);
   }
 
-  if (VersionHasStreamType(connection()->transport_version()) &&
-      UsesPendingStreams() &&
+  if (UsesPendingStreams() &&
       QuicUtils::GetStreamType(stream_id, perspective(),
                                IsIncomingStream(stream_id)) ==
           READ_UNIDIRECTIONAL &&