Change large header size in EndToEndTest.WayTooLongRequestHeaders. Much smaller headers are enough to trigger the behavior this test is exercising. Large headers are causing test timeouts under different scenarios: * TLS + HPACK (b/157248143) * QPACK only on tsan bots on Chromium (b/169262950) PiperOrigin-RevId: 336935923 Change-Id: Idd76963a8e008b459111bd2245d02d446c097fe7
diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc index 6145a79..43d95a3 100644 --- a/quic/core/http/end_to_end_test.cc +++ b/quic/core/http/end_to_end_test.cc
@@ -3920,21 +3920,17 @@ EXPECT_FALSE(QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer)); } +// A single large header value causes a different error than the total size of +// headers exceeding a smaller limit, tested at EndToEndTest.LargeHeaders. TEST_P(EndToEndTest, WayTooLongRequestHeaders) { ASSERT_TRUE(Initialize()); - if (version_.UsesTls() && !version_.UsesHttp3()) { - // In T050, it took relatively long time for HPACK to compress the header - // while server will detect blackhole on NST message. - // TODO(b/157248143): remove this when the HPACK compression issue is - // understood. - return; - } + SpdyHeaderBlock headers; headers[":method"] = "GET"; headers[":path"] = "/foo"; headers[":scheme"] = "https"; headers[":authority"] = server_hostname_; - headers["key"] = std::string(64 * 1024 * 1024, 'a'); + headers["key"] = std::string(2 * 1024 * 1024, 'a'); client_->SendMessage(headers, ""); client_->WaitForResponse();