commit 30045be320b5a72bd4a18e43e74c1a50a6a7f0c1
author haoyuewang <haoyuewang@google.com> Fri Apr 08 12:57:08 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Apr 08 12:57:49 2022 -0700
tree 7c27ebf5a0bd8ef4ebfba0378cee62db9317a1dc
parent d0152cad77cb5c1b57ff2cd3180b8abbc092f638

Remove connection_option RVCM such that IETF QUIC connection migration is default on.

We need more stats from AFE teams to verify the corresponding flag but it is good to exercise this flag early in the GFE canary.

Protected by FLAGS_quic_reloadable_flag_quic_remove_connection_migration_connection_option_v2.

PiperOrigin-RevId: 440432966

quiche/quic/core/quic_connection_test.cc

diff --git a/quiche/quic/core/quic_connection_test.cc b/quiche/quic/core/quic_connection_test.cc
index d7b722c..cce10e7 100644
--- a/quiche/quic/core/quic_connection_test.cc
+++ b/quiche/quic/core/quic_connection_test.cc
@@ -1306,7 +1306,7 @@
     if (perspective == Perspective::IS_SERVER) {
       QuicConfig config;
       if (!GetQuicReloadableFlag(
-              quic_remove_connection_migration_connection_option)) {
+              quic_remove_connection_migration_connection_option_v2)) {
         QuicTagVector connection_options;
         connection_options.push_back(kRVCM);
         config.SetInitialReceivedConnectionOptions(connection_options);
@@ -14116,7 +14116,7 @@
 TEST_P(QuicConnectionTest,
        PathValidationFailedOnClientDueToLackOfServerConnectionId) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
     connection_.SetFromConfig(config);
@@ -14144,7 +14144,7 @@
 TEST_P(QuicConnectionTest,
        PathValidationFailedOnClientDueToLackOfClientConnectionIdTheSecondTime) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     config.SetConnectionOptionsToSend({kRVCM});
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
@@ -14235,7 +14235,7 @@
 
 TEST_P(QuicConnectionTest, ServerConnectionIdRetiredUponPathValidationFailure) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     config.SetConnectionOptionsToSend({kRVCM});
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
@@ -14285,7 +14285,7 @@
 TEST_P(QuicConnectionTest,
        MigratePathDirectlyFailedDueToLackOfServerConnectionId) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     config.SetConnectionOptionsToSend({kRVCM});
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
@@ -14308,7 +14308,7 @@
 TEST_P(QuicConnectionTest,
        MigratePathDirectlyFailedDueToLackOfClientConnectionIdTheSecondTime) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     config.SetConnectionOptionsToSend({kRVCM});
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
@@ -14627,7 +14627,7 @@
 
 TEST_P(QuicConnectionTest, ServerRetireSelfIssuedConnectionId) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     config.SetConnectionOptionsToSend({kRVCM});
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
@@ -15076,7 +15076,7 @@
 
 TEST_P(QuicConnectionTest, AckElicitingFrames) {
   if (!GetQuicReloadableFlag(
-          quic_remove_connection_migration_connection_option)) {
+          quic_remove_connection_migration_connection_option_v2)) {
     QuicConfig config;
     config.SetConnectionOptionsToSend({kRVCM});
     EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));