Remove connection close-related QUIC_BUGs.
Remove QUIC_BUG(quic_bug_10360_3) from QuicSpdySession::SendHttp3GoAway(),
and QUIC_BUG(quic_send_multiple_connection_closes) from
QuicConnection::SendConnectionClosePacket().
Among other changes, this CL reverts parts of cl/437010467.
PiperOrigin-RevId: 442601892
diff --git a/quiche/quic/core/quic_connection_test.cc b/quiche/quic/core/quic_connection_test.cc
index 50ae2f1..2770f5a 100644
--- a/quiche/quic/core/quic_connection_test.cc
+++ b/quiche/quic/core/quic_connection_test.cc
@@ -15747,16 +15747,16 @@
SendStreamDataToPeer(1, "foo", 0, NO_FIN, nullptr);
ASSERT_TRUE(connection_.BlackholeDetectionInProgress());
- // Verify BeforeConnectionCloseSent gets called twice while OnConnectionClosed
- // is called once.
+ // Verify that BeforeConnectionCloseSent() gets called twice,
+ // while OnConnectionClosed() is called only once.
EXPECT_CALL(visitor_, BeforeConnectionCloseSent()).Times(2);
EXPECT_CALL(visitor_, OnConnectionClosed(_, _));
// Send connection close w/o closing connection.
QuicConnectionPeer::SendConnectionClosePacket(
&connection_, INTERNAL_ERROR, QUIC_INTERNAL_ERROR, "internal error");
- // Fire blackhole detection alarm.
- EXPECT_QUIC_BUG(connection_.GetBlackholeDetectorAlarm()->Fire(),
- "Already sent connection close");
+ // Fire blackhole detection alarm. This will invoke
+ // SendConnectionClosePacket() a second time.
+ connection_.GetBlackholeDetectorAlarm()->Fire();
}
// Regression test for b/157895910.
