gfe-relnote: Flag protect the new MaxPushId logic in quic_spdy_session.cc to simplify Chrome merge. This code is already protected by disabled v99, but this new --gfe2_reloadable_flag_quic_send_max_push_id_with_settings flag disables this new behavior in Chrome tests until they can be modifie.
PiperOrigin-RevId: 283807627
Change-Id: I34c9dd9656a931ad9ef45bbce572a910f94487bd
diff --git a/quic/core/http/quic_spdy_session.cc b/quic/core/http/quic_spdy_session.cc
index a34d580..3a3441b 100644
--- a/quic/core/http/quic_spdy_session.cc
+++ b/quic/core/http/quic_spdy_session.cc
@@ -597,12 +597,13 @@
}
QuicConnection::ScopedPacketFlusher flusher(connection());
send_control_stream_->MaybeSendSettingsFrame();
- qpack_decoder_send_stream_->MaybeSendStreamType();
- qpack_encoder_send_stream_->MaybeSendStreamType();
- if (perspective() == Perspective::IS_CLIENT && !http3_max_push_id_sent_) {
+ if (GetQuicReloadableFlag(quic_send_max_push_id_with_settings) &&
+ perspective() == Perspective::IS_CLIENT && !http3_max_push_id_sent_) {
SendMaxPushId();
http3_max_push_id_sent_ = true;
}
+ qpack_decoder_send_stream_->MaybeSendStreamType();
+ qpack_encoder_send_stream_->MaybeSendStreamType();
}
QpackEncoder* QuicSpdySession::qpack_encoder() {
diff --git a/quic/core/http/quic_spdy_stream_test.cc b/quic/core/http/quic_spdy_stream_test.cc
index 42e9954..f834865 100644
--- a/quic/core/http/quic_spdy_stream_test.cc
+++ b/quic/core/http/quic_spdy_stream_test.cc
@@ -1274,6 +1274,7 @@
TEST_P(QuicSpdyStreamTest, ClientWritesPriority) {
SetQuicFlag(FLAGS_quic_allow_http3_priority, true);
+ SetQuicReloadableFlag(quic_send_max_push_id_with_settings, true);
InitializeWithPerspective(kShouldProcessData, Perspective::IS_CLIENT);
if (UsesHttp3()) {
