Stop tracking http response size and latency from QuicConnectionStats. Not protected.
The http response size and latency in QuicConnectionStats are used to get the average response latency for loss detection tuning. They have been replaced by response sizes and latencies filtered in internal code.
PiperOrigin-RevId: 324068534
Change-Id: I9f474fe34c483b742188a25fd3e3e1896b526786
diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc
index 8125724..1bb6f1c 100644
--- a/quic/core/http/end_to_end_test.cc
+++ b/quic/core/http/end_to_end_test.cc
@@ -2634,11 +2634,9 @@
public:
TestAckListener() {}
- ResponseStats OnPacketAcked(
- int acked_bytes,
- QuicTime::Delta /*delta_largest_observed*/) override {
+ void OnPacketAcked(int acked_bytes,
+ QuicTime::Delta /*delta_largest_observed*/) override {
total_bytes_acked_ += acked_bytes;
- return ResponseStats();
}
void OnPacketRetransmitted(int /*retransmitted_bytes*/) override {}
diff --git a/quic/core/http/quic_headers_stream.cc b/quic/core/http/quic_headers_stream.cc
index 406a66c..8157dae 100644
--- a/quic/core/http/quic_headers_stream.cc
+++ b/quic/core/http/quic_headers_stream.cc
@@ -91,11 +91,7 @@
return false;
}
if (header.ack_listener != nullptr && header_length > 0) {
- auto response_stats =
- header.ack_listener->OnPacketAcked(header_length, ack_delay_time);
- if (!response_stats.IsEmpty()) {
- spdy_session_->RecordServerResponse(response_stats);
- }
+ header.ack_listener->OnPacketAcked(header_length, ack_delay_time);
}
header.unacked_length -= header_length;
acked_offset += header_length;
diff --git a/quic/core/http/quic_spdy_session.cc b/quic/core/http/quic_spdy_session.cc
index 11ad810..2948371 100644
--- a/quic/core/http/quic_spdy_session.cc
+++ b/quic/core/http/quic_spdy_session.cc
@@ -1409,16 +1409,6 @@
quiche::QuicheStrCat(type, " stream is received twice."));
}
-void QuicSpdySession::RecordServerResponse(ResponseStats response_stats) {
- DCHECK_EQ(perspective(), Perspective::IS_SERVER);
- QuicConnectionStats& stats = connection()->mutable_stats();
-
- ++stats.num_responses;
- stats.total_response_size += response_stats.response_size;
- stats.total_response_time =
- stats.total_response_time + response_stats.response_time;
-}
-
// static
void QuicSpdySession::LogHeaderCompressionRatioHistogram(
bool using_qpack,
diff --git a/quic/core/http/quic_spdy_session.h b/quic/core/http/quic_spdy_session.h
index cb3b986..7e56b27 100644
--- a/quic/core/http/quic_spdy_session.h
+++ b/quic/core/http/quic_spdy_session.h
@@ -387,9 +387,6 @@
// Decode SETTINGS from |cached_state| and apply it to the session.
bool ResumeApplicationState(ApplicationState* cached_state) override;
- // (Server only) Records the response time of a completed request.
- void RecordServerResponse(ResponseStats response_stats);
-
protected:
// Override CreateIncomingStream(), CreateOutgoingBidirectionalStream() and
// CreateOutgoingUnidirectionalStream() with QuicSpdyStream return type to
diff --git a/quic/core/http/quic_spdy_stream.cc b/quic/core/http/quic_spdy_stream.cc
index 01d6b11..4c979c1 100644
--- a/quic/core/http/quic_spdy_stream.cc
+++ b/quic/core/http/quic_spdy_stream.cc
@@ -919,11 +919,8 @@
DCHECK_LE(newly_acked_header_length, *newly_acked_length);
unacked_frame_headers_offsets_.Difference(offset, offset + data_length);
if (ack_listener_ != nullptr && new_data_acked) {
- auto response_stats = ack_listener_->OnPacketAcked(
+ ack_listener_->OnPacketAcked(
*newly_acked_length - newly_acked_header_length, ack_delay_time);
- if (!response_stats.IsEmpty()) {
- spdy_session_->RecordServerResponse(response_stats);
- }
}
return new_data_acked;
}
