commit 1f6aca8291a79b2f0741f80b799a5b9603ff7f50
author dschinazi <dschinazi@google.com> Fri Dec 04 13:20:08 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Dec 04 13:20:47 2020 -0800
tree 4d2bd7946a14139cf4532478658ab72398eef373
parent 330a1eec8132c5a11f43b3f1a09ee48540dfa425

Clean up dead QUIC transport parameter code

Now that we've deprecated T050 and draft27, we can remove features that were only used by those versions. This CL does not change any behavior.

PiperOrigin-RevId: 345743398
Change-Id: Ic36e043cf258568ea22b0e4bac3808a82d4998b4

quic/core/http/quic_spdy_session_test.cc

diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc
index 4eb0997..91f0a58 100644
--- a/quic/core/http/quic_spdy_session_test.cc
+++ b/quic/core/http/quic_spdy_session_test.cc
@@ -101,7 +101,7 @@
         kInitialStreamFlowControlWindowForTest);
     session()->config()->SetInitialSessionFlowControlWindowToSend(
         kInitialSessionFlowControlWindowForTest);
-    if (session()->version().AuthenticatesHandshakeConnectionIds()) {
+    if (session()->version().UsesTls()) {
       if (session()->perspective() == Perspective::IS_CLIENT) {
         session()->config()->SetOriginalConnectionIdToSend(
             session()->connection()->connection_id());
@@ -111,9 +111,6 @@
         session()->config()->SetInitialSourceConnectionIdToSend(
             session()->connection()->client_connection_id());
       }
-    }
-    if (session()->connection()->version().handshake_protocol ==
-        PROTOCOL_TLS1_3) {
       TransportParameters transport_parameters;
       EXPECT_TRUE(
           session()->config()->FillTransportParameters(&transport_parameters));
@@ -500,9 +497,9 @@
       EXPECT_CALL(*writer_, WritePacket(_, _, _, _, _))
           .WillOnce(Return(WriteResult(WRITE_STATUS_OK, 0)));
     }
-    // HANDSHAKE_DONE frame sent by the server.
-    if (connection_->version().HasHandshakeDone() &&
+    if (connection_->version().UsesTls() &&
         connection_->perspective() == Perspective::IS_SERVER) {
+      // HANDSHAKE_DONE frame.
       EXPECT_CALL(*connection_, SendControlFrame(_))
           .WillOnce(Invoke(&ClearControlFrame));
     }