Deprecate --gfe2_reloadable_flag_http2_skip_querying_entry_buffer_error.
gfe-relnote: deprecate gfe2_reloadable_flag_http2_skip_querying_entry_buffer_error.
PiperOrigin-RevId: 305025104
Change-Id: I3b4d186925a49d4d759f79fce8f0bca6cd141dd5
diff --git a/http2/hpack/decoder/hpack_decoder.cc b/http2/hpack/decoder/hpack_decoder.cc
index 1013292..b879511 100644
--- a/http2/hpack/decoder/hpack_decoder.cc
+++ b/http2/hpack/decoder/hpack_decoder.cc
@@ -16,9 +16,7 @@
: decoder_state_(listener),
entry_buffer_(&decoder_state_, max_string_size),
block_decoder_(&entry_buffer_),
- error_(HpackDecodingError::kOk),
- http2_skip_querying_entry_buffer_error_(
- GetHttp2ReloadableFlag(http2_skip_querying_entry_buffer_error)) {}
+ error_(HpackDecodingError::kOk) {}
HpackDecoder::~HpackDecoder() = default;
@@ -108,21 +106,7 @@
if (decoder_state_.error() != HpackDecodingError::kOk) {
HTTP2_DVLOG(2) << "Error detected in decoder_state_";
HTTP2_CODE_COUNT_N(decompress_failure_3, 10, 23);
- HTTP2_CODE_COUNT_N(http2_skip_querying_entry_buffer_error, 1, 3);
error_ = decoder_state_.error();
- } else if (entry_buffer_.error_detected()) {
- // This should never happen, because if an error had occured in
- // |entry_buffer_|, it would have notified its listener, |decoder_state_|.
- if (http2_skip_querying_entry_buffer_error_) {
- HTTP2_CODE_COUNT_N(http2_skip_querying_entry_buffer_error, 2, 3);
- } else {
- HTTP2_DVLOG(2) << "Error detected in entry_buffer_";
- HTTP2_CODE_COUNT_N(decompress_failure_3, 9, 23);
- HTTP2_CODE_COUNT_N(http2_skip_querying_entry_buffer_error, 3, 3);
- // Since this code path should never be executed, error code does not
- // matter as long as it is not HpackDecodingError::kOk.
- error_ = HpackDecodingError::kIndexVarintError;
- }
}
return error_ != HpackDecodingError::kOk;
diff --git a/http2/hpack/decoder/hpack_decoder.h b/http2/hpack/decoder/hpack_decoder.h
index 6e63604..efe334d 100644
--- a/http2/hpack/decoder/hpack_decoder.h
+++ b/http2/hpack/decoder/hpack_decoder.h
@@ -121,9 +121,6 @@
// Error code if an error has occurred, HpackDecodingError::kOk otherwise.
HpackDecodingError error_;
-
- // Latched value of reloadable_flag_http2_skip_querying_entry_buffer_error.
- const bool http2_skip_querying_entry_buffer_error_;
};
} // namespace http2
