commit 1e41d2196d72bf7b3c532a620e075818d25e6ce7
author dschinazi <dschinazi@google.com> Tue Mar 31 15:55:25 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 31 15:55:53 2020 -0700
tree d1b82d50bb50c61b3f57a37ef1a5d04e6d967213
parent ff6af51fdd2fb76cd1cca2d576fcda24108e27a4

Fix DebugDFatalIfMarkingClosedStreamWriteBlocked test

This test was attempting to run faster by only running with the first version, and that was actually causing a gap in test coverage, which was uncovered by reordering versions. This CL fixes the coverage gap and makes sure the test passes for all versions.

gfe-relnote: n/a, test-only
PiperOrigin-RevId: 304064435
Change-Id: I5c00fef9b48ca6f8c360fc7377133b34ff3c6d45

quic/core/http/quic_spdy_session_test.cc

diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc
index 1c448a7..164e6a1 100644
--- a/quic/core/http/quic_spdy_session_test.cc
+++ b/quic/core/http/quic_spdy_session_test.cc
@@ -641,10 +641,9 @@
 
 TEST_P(QuicSpdySessionTestServer,
        DebugDFatalIfMarkingClosedStreamWriteBlocked) {
-  // EXPECT_QUIC_BUG tests are expensive so only run one instance of them.
-  if (GetParam() != AllSupportedVersions()[0]) {
-    return;
-  }
+  CompleteHandshake();
+  EXPECT_CALL(*writer_, WritePacket(_, _, _, _, _))
+      .WillRepeatedly(Return(WriteResult(WRITE_STATUS_OK, 0)));
 
   TestStream* stream2 = session_.CreateOutgoingBidirectionalStream();
   QuicStreamId closed_stream_id = stream2->id();