Fix DebugDFatalIfMarkingClosedStreamWriteBlocked test This test was attempting to run faster by only running with the first version, and that was actually causing a gap in test coverage, which was uncovered by reordering versions. This CL fixes the coverage gap and makes sure the test passes for all versions. gfe-relnote: n/a, test-only PiperOrigin-RevId: 304064435 Change-Id: I5c00fef9b48ca6f8c360fc7377133b34ff3c6d45
diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc index 1c448a7..164e6a1 100644 --- a/quic/core/http/quic_spdy_session_test.cc +++ b/quic/core/http/quic_spdy_session_test.cc
@@ -641,10 +641,9 @@ TEST_P(QuicSpdySessionTestServer, DebugDFatalIfMarkingClosedStreamWriteBlocked) { - // EXPECT_QUIC_BUG tests are expensive so only run one instance of them. - if (GetParam() != AllSupportedVersions()[0]) { - return; - } + CompleteHandshake(); + EXPECT_CALL(*writer_, WritePacket(_, _, _, _, _)) + .WillRepeatedly(Return(WriteResult(WRITE_STATUS_OK, 0))); TestStream* stream2 = session_.CreateOutgoingBidirectionalStream(); QuicStreamId closed_stream_id = stream2->id();
diff --git a/quic/core/quic_session_test.cc b/quic/core/quic_session_test.cc index 36e0b53..443af09 100644 --- a/quic/core/quic_session_test.cc +++ b/quic/core/quic_session_test.cc
@@ -870,11 +870,6 @@ } TEST_P(QuicSessionTestServer, DebugDFatalIfMarkingClosedStreamWriteBlocked) { - // EXPECT_QUIC_BUG tests are expensive so only run one instance of them. - if (GetParam() != AllSupportedVersions()[0]) { - return; - } - TestStream* stream2 = session_.CreateOutgoingBidirectionalStream(); QuicStreamId closed_stream_id = stream2->id(); // Close the stream.