Fix QUIC warnings in preparation for enabling them
gfe-relnote: n/a, compilation-only change
PiperOrigin-RevId: 253893322
Change-Id: I15917a1c5b325922850086277cfad5e3b4da20a4
diff --git a/quic/core/quic_ietf_framer_test.cc b/quic/core/quic_ietf_framer_test.cc
index f30fc99..e00ced6 100644
--- a/quic/core/quic_ietf_framer_test.cc
+++ b/quic/core/quic_ietf_framer_test.cc
@@ -91,116 +91,131 @@
void OnPacket() override {}
- void OnPublicResetPacket(const QuicPublicResetPacket& packet) override {}
+ void OnPublicResetPacket(const QuicPublicResetPacket& /*packet*/) override {}
void OnVersionNegotiationPacket(
- const QuicVersionNegotiationPacket& packet) override {}
+ const QuicVersionNegotiationPacket& /*packet*/) override {}
- void OnRetryPacket(QuicConnectionId original_connection_id,
- QuicConnectionId new_connection_id,
- QuicStringPiece retry_token) override {}
+ void OnRetryPacket(QuicConnectionId /*original_connection_id*/,
+ QuicConnectionId /*new_connection_id*/,
+ QuicStringPiece /*retry_token*/) override {}
- bool OnProtocolVersionMismatch(ParsedQuicVersion received_version,
- PacketHeaderFormat form) override {
+ bool OnProtocolVersionMismatch(ParsedQuicVersion /*received_version*/,
+ PacketHeaderFormat /*form*/) override {
return true;
}
- bool OnUnauthenticatedPublicHeader(const QuicPacketHeader& header) override {
+ bool OnUnauthenticatedPublicHeader(
+ const QuicPacketHeader& /*header*/) override {
return true;
}
- bool OnUnauthenticatedHeader(const QuicPacketHeader& header) override {
+ bool OnUnauthenticatedHeader(const QuicPacketHeader& /*header*/) override {
return true;
}
- void OnDecryptedPacket(EncryptionLevel level) override {}
+ void OnDecryptedPacket(EncryptionLevel /*level*/) override {}
- bool OnPacketHeader(const QuicPacketHeader& header) override { return true; }
-
- void OnCoalescedPacket(const QuicEncryptedPacket& packet) override {}
-
- bool OnStreamFrame(const QuicStreamFrame& frame) override { return true; }
-
- bool OnCryptoFrame(const QuicCryptoFrame& frame) override { return true; }
-
- bool OnAckFrameStart(QuicPacketNumber largest_acked,
- QuicTime::Delta ack_delay_time) override {
+ bool OnPacketHeader(const QuicPacketHeader& /*header*/) override {
return true;
}
- bool OnAckRange(QuicPacketNumber start, QuicPacketNumber end) override {
+ void OnCoalescedPacket(const QuicEncryptedPacket& /*packet*/) override {}
+
+ bool OnStreamFrame(const QuicStreamFrame& /*frame*/) override { return true; }
+
+ bool OnCryptoFrame(const QuicCryptoFrame& /*frame*/) override { return true; }
+
+ bool OnAckFrameStart(QuicPacketNumber /*largest_acked*/,
+ QuicTime::Delta /*ack_delay_time*/) override {
return true;
}
- bool OnAckTimestamp(QuicPacketNumber packet_number,
- QuicTime timestamp) override {
+ bool OnAckRange(QuicPacketNumber /*start*/,
+ QuicPacketNumber /*end*/) override {
return true;
}
- bool OnAckFrameEnd(QuicPacketNumber start) override { return true; }
-
- bool OnStopWaitingFrame(const QuicStopWaitingFrame& frame) override {
+ bool OnAckTimestamp(QuicPacketNumber /*packet_number*/,
+ QuicTime /*timestamp*/) override {
return true;
}
- bool OnPaddingFrame(const QuicPaddingFrame& frame) override { return true; }
+ bool OnAckFrameEnd(QuicPacketNumber /*start*/) override { return true; }
- bool OnPingFrame(const QuicPingFrame& frame) override { return true; }
+ bool OnStopWaitingFrame(const QuicStopWaitingFrame& /*frame*/) override {
+ return true;
+ }
- bool OnMessageFrame(const QuicMessageFrame& frame) override { return true; }
+ bool OnPaddingFrame(const QuicPaddingFrame& /*frame*/) override {
+ return true;
+ }
+
+ bool OnPingFrame(const QuicPingFrame& /*frame*/) override { return true; }
+
+ bool OnMessageFrame(const QuicMessageFrame& /*frame*/) override {
+ return true;
+ }
void OnPacketComplete() override {}
- bool OnRstStreamFrame(const QuicRstStreamFrame& frame) override {
+ bool OnRstStreamFrame(const QuicRstStreamFrame& /*frame*/) override {
return true;
}
- bool OnConnectionCloseFrame(const QuicConnectionCloseFrame& frame) override {
+ bool OnConnectionCloseFrame(
+ const QuicConnectionCloseFrame& /*frame*/) override {
return true;
}
- bool OnStopSendingFrame(const QuicStopSendingFrame& frame) override {
+ bool OnStopSendingFrame(const QuicStopSendingFrame& /*frame*/) override {
return true;
}
- bool OnPathChallengeFrame(const QuicPathChallengeFrame& frame) override {
+ bool OnPathChallengeFrame(const QuicPathChallengeFrame& /*frame*/) override {
return true;
}
- bool OnPathResponseFrame(const QuicPathResponseFrame& frame) override {
+ bool OnPathResponseFrame(const QuicPathResponseFrame& /*frame*/) override {
return true;
}
- bool OnGoAwayFrame(const QuicGoAwayFrame& frame) override { return true; }
+ bool OnGoAwayFrame(const QuicGoAwayFrame& /*frame*/) override { return true; }
- bool OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame) override {
+ bool OnWindowUpdateFrame(const QuicWindowUpdateFrame& /*frame*/) override {
return true;
}
- bool OnBlockedFrame(const QuicBlockedFrame& frame) override { return true; }
+ bool OnBlockedFrame(const QuicBlockedFrame& /*frame*/) override {
+ return true;
+ }
- bool OnNewConnectionIdFrame(const QuicNewConnectionIdFrame& frame) override {
+ bool OnNewConnectionIdFrame(
+ const QuicNewConnectionIdFrame& /*frame*/) override {
return true;
}
bool OnRetireConnectionIdFrame(
- const QuicRetireConnectionIdFrame& frame) override {
+ const QuicRetireConnectionIdFrame& /*frame*/) override {
return true;
}
- bool OnNewTokenFrame(const QuicNewTokenFrame& frame) override { return true; }
+ bool OnNewTokenFrame(const QuicNewTokenFrame& /*frame*/) override {
+ return true;
+ }
- bool IsValidStatelessResetToken(QuicUint128 token) const override {
+ bool IsValidStatelessResetToken(QuicUint128 /*token*/) const override {
return true;
}
void OnAuthenticatedIetfStatelessResetPacket(
- const QuicIetfStatelessResetPacket& packet) override {}
+ const QuicIetfStatelessResetPacket& /*packet*/) override {}
- bool OnMaxStreamsFrame(const QuicMaxStreamsFrame& frame) override {
+ bool OnMaxStreamsFrame(const QuicMaxStreamsFrame& /*frame*/) override {
return true;
}
- bool OnStreamsBlockedFrame(const QuicStreamsBlockedFrame& frame) override {
+ bool OnStreamsBlockedFrame(
+ const QuicStreamsBlockedFrame& /*frame*/) override {
return true;
}
};
@@ -289,7 +304,7 @@
// - did the things the reader read match what the writer wrote?
// Returns true if it all worked false if not.
bool TryAckFrame(char* packet_buffer,
- size_t packet_buffer_size,
+ size_t /*packet_buffer_size*/,
struct ack_frame* frame) {
QuicAckFrame transmit_frame = InitAckFrame(frame->ranges);
if (frame->is_ack_ecn) {
