Fix QUIC warnings in preparation for enabling them
gfe-relnote: n/a, compilation-only change
PiperOrigin-RevId: 253893322
Change-Id: I15917a1c5b325922850086277cfad5e3b4da20a4
diff --git a/quic/core/qpack/fuzzer/qpack_encoder_stream_receiver_fuzzer.cc b/quic/core/qpack/fuzzer/qpack_encoder_stream_receiver_fuzzer.cc
index 9991d9a..9b5fe11 100644
--- a/quic/core/qpack/fuzzer/qpack_encoder_stream_receiver_fuzzer.cc
+++ b/quic/core/qpack/fuzzer/qpack_encoder_stream_receiver_fuzzer.cc
@@ -22,14 +22,14 @@
NoOpDelegate() : error_detected_(false) {}
~NoOpDelegate() override = default;
- void OnInsertWithNameReference(bool is_static,
- uint64_t name_index,
- QuicStringPiece value) override {}
- void OnInsertWithoutNameReference(QuicStringPiece name,
- QuicStringPiece value) override {}
- void OnDuplicate(uint64_t index) override {}
- void OnSetDynamicTableCapacity(uint64_t capacity) override {}
- void OnErrorDetected(QuicStringPiece error_message) override {
+ void OnInsertWithNameReference(bool /*is_static*/,
+ uint64_t /*name_index*/,
+ QuicStringPiece /*value*/) override {}
+ void OnInsertWithoutNameReference(QuicStringPiece /*name*/,
+ QuicStringPiece /*value*/) override {}
+ void OnDuplicate(uint64_t /*index*/) override {}
+ void OnSetDynamicTableCapacity(uint64_t /*capacity*/) override {}
+ void OnErrorDetected(QuicStringPiece /*error_message*/) override {
error_detected_ = true;
}
diff --git a/quic/core/qpack/qpack_decoder_test_utils.cc b/quic/core/qpack/qpack_decoder_test_utils.cc
index d19ae4a..d00e528 100644
--- a/quic/core/qpack/qpack_decoder_test_utils.cc
+++ b/quic/core/qpack/qpack_decoder_test_utils.cc
@@ -14,10 +14,10 @@
namespace test {
void NoopEncoderStreamErrorDelegate::OnEncoderStreamError(
- QuicStringPiece error_message) {}
+ QuicStringPiece /*error_message*/) {}
void NoopDecoderStreamSenderDelegate::WriteDecoderStreamData(
- QuicStringPiece data) {}
+ QuicStringPiece /*data*/) {}
TestHeadersHandler::TestHeadersHandler()
: decoding_completed_(false), decoding_error_detected_(false) {}
@@ -38,7 +38,7 @@
}
void TestHeadersHandler::OnDecodingErrorDetected(
- QuicStringPiece error_message) {
+ QuicStringPiece /*error_message*/) {
ASSERT_FALSE(decoding_completed_);
ASSERT_FALSE(decoding_error_detected_);
diff --git a/quic/core/qpack/qpack_decoder_test_utils.h b/quic/core/qpack/qpack_decoder_test_utils.h
index 55761b6..7cc684c 100644
--- a/quic/core/qpack/qpack_decoder_test_utils.h
+++ b/quic/core/qpack/qpack_decoder_test_utils.h
@@ -96,9 +96,10 @@
public:
~NoOpHeadersHandler() override = default;
- void OnHeaderDecoded(QuicStringPiece name, QuicStringPiece value) override {}
+ void OnHeaderDecoded(QuicStringPiece /*name*/,
+ QuicStringPiece /*value*/) override {}
void OnDecodingCompleted() override {}
- void OnDecodingErrorDetected(QuicStringPiece error_message) override {}
+ void OnDecodingErrorDetected(QuicStringPiece /*error_message*/) override {}
};
void QpackDecode(
diff --git a/quic/core/qpack/qpack_encoder.cc b/quic/core/qpack/qpack_encoder.cc
index 09c4286..2c1e453 100644
--- a/quic/core/qpack/qpack_encoder.cc
+++ b/quic/core/qpack/qpack_encoder.cc
@@ -35,15 +35,15 @@
decoder_stream_receiver_.Decode(data);
}
-void QpackEncoder::OnInsertCountIncrement(uint64_t increment) {
+void QpackEncoder::OnInsertCountIncrement(uint64_t /*increment*/) {
// TODO(bnc): Implement dynamic table management for encoding.
}
-void QpackEncoder::OnHeaderAcknowledgement(QuicStreamId stream_id) {
+void QpackEncoder::OnHeaderAcknowledgement(QuicStreamId /*stream_id*/) {
// TODO(bnc): Implement dynamic table management for encoding.
}
-void QpackEncoder::OnStreamCancellation(QuicStreamId stream_id) {
+void QpackEncoder::OnStreamCancellation(QuicStreamId /*stream_id*/) {
// TODO(bnc): Implement dynamic table management for encoding.
}
diff --git a/quic/core/qpack/qpack_encoder_test_utils.cc b/quic/core/qpack/qpack_encoder_test_utils.cc
index dd1ccb3..a58b0ae 100644
--- a/quic/core/qpack/qpack_encoder_test_utils.cc
+++ b/quic/core/qpack/qpack_encoder_test_utils.cc
@@ -10,10 +10,10 @@
namespace test {
void NoopDecoderStreamErrorDelegate::OnDecoderStreamError(
- QuicStringPiece error_message) {}
+ QuicStringPiece /*error_message*/) {}
void NoopEncoderStreamSenderDelegate::WriteEncoderStreamData(
- QuicStringPiece data) {}
+ QuicStringPiece /*data*/) {}
std::string QpackEncode(
QpackEncoder::DecoderStreamErrorDelegate* decoder_stream_error_delegate,
diff --git a/quic/core/qpack/qpack_instruction_encoder.cc b/quic/core/qpack/qpack_instruction_encoder.cc
index 3ae38f6..0da9567 100644
--- a/quic/core/qpack/qpack_instruction_encoder.cc
+++ b/quic/core/qpack/qpack_instruction_encoder.cc
@@ -107,7 +107,7 @@
state_ = State::kStartField;
}
-size_t QpackInstructionEncoder::DoVarintStart(size_t max_encoded_bytes,
+size_t QpackInstructionEncoder::DoVarintStart(size_t /*max_encoded_bytes*/,
std::string* output) {
DCHECK(field_->type == QpackInstructionFieldType::kVarint ||
field_->type == QpackInstructionFieldType::kVarint2 ||
diff --git a/quic/core/qpack/qpack_receive_stream.cc b/quic/core/qpack/qpack_receive_stream.cc
index 1cf2060..f0c4a3d 100644
--- a/quic/core/qpack/qpack_receive_stream.cc
+++ b/quic/core/qpack/qpack_receive_stream.cc
@@ -10,7 +10,7 @@
QpackReceiveStream::QpackReceiveStream(PendingStream* pending)
: QuicStream(pending, READ_UNIDIRECTIONAL, /*is_static=*/true) {}
-void QpackReceiveStream::OnStreamReset(const QuicRstStreamFrame& frame) {
+void QpackReceiveStream::OnStreamReset(const QuicRstStreamFrame& /*frame*/) {
// TODO(renjietang) Change the error code to H/3 specific
// HTTP_CLOSED_CRITICAL_STREAM.
session()->connection()->CloseConnection(
diff --git a/quic/core/qpack/qpack_send_stream.cc b/quic/core/qpack/qpack_send_stream.cc
index 620ab2b..75b9c57 100644
--- a/quic/core/qpack/qpack_send_stream.cc
+++ b/quic/core/qpack/qpack_send_stream.cc
@@ -15,7 +15,7 @@
stream_type_(stream_type),
stream_type_sent_(false) {}
-void QpackSendStream::OnStreamReset(const QuicRstStreamFrame& frame) {
+void QpackSendStream::OnStreamReset(const QuicRstStreamFrame& /*frame*/) {
// TODO(renjietang) Change the error code to H/3 specific
// HTTP_CLOSED_CRITICAL_STREAM.
session()->connection()->CloseConnection(
