Fix QUIC warnings in preparation for enabling them
gfe-relnote: n/a, compilation-only change
PiperOrigin-RevId: 253893322
Change-Id: I15917a1c5b325922850086277cfad5e3b4da20a4
diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc
index a64b289..b3aaf20 100644
--- a/quic/core/http/end_to_end_test.cc
+++ b/quic/core/http/end_to_end_test.cc
@@ -3328,12 +3328,14 @@
size_t num_ping_frames() const { return num_ping_frames_; }
- void OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame,
- const QuicTime& receive_time) override {
+ void OnWindowUpdateFrame(const QuicWindowUpdateFrame& /*frame*/,
+ const QuicTime& /*receive_time*/) override {
++num_window_update_frames_;
}
- void OnPingFrame(const QuicPingFrame& frame) override { ++num_ping_frames_; }
+ void OnPingFrame(const QuicPingFrame& /*frame*/) override {
+ ++num_ping_frames_;
+ }
private:
size_t num_window_update_frames_;
diff --git a/quic/core/http/quic_client_promised_info_test.cc b/quic/core/http/quic_client_promised_info_test.cc
index 24d4821..fcc85ba 100644
--- a/quic/core/http/quic_client_promised_info_test.cc
+++ b/quic/core/http/quic_client_promised_info_test.cc
@@ -46,7 +46,7 @@
delete;
~MockQuicSpdyClientSession() override {}
- bool IsAuthorized(const std::string& authority) override {
+ bool IsAuthorized(const std::string& /*authority*/) override {
return authorized_;
}
diff --git a/quic/core/http/quic_receive_control_stream.cc b/quic/core/http/quic_receive_control_stream.cc
index 91f65c8..986c4e4 100644
--- a/quic/core/http/quic_receive_control_stream.cc
+++ b/quic/core/http/quic_receive_control_stream.cc
@@ -18,28 +18,28 @@
HttpDecoderVisitor(const HttpDecoderVisitor&) = delete;
HttpDecoderVisitor& operator=(const HttpDecoderVisitor&) = delete;
- void OnError(HttpDecoder* decoder) override {
+ void OnError(HttpDecoder* /*decoder*/) override {
stream_->session()->connection()->CloseConnection(
QUIC_HTTP_DECODER_ERROR, "Http decoder internal error",
ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
}
- bool OnPriorityFrame(const PriorityFrame& frame) override {
+ bool OnPriorityFrame(const PriorityFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Priority");
return false;
}
- bool OnCancelPushFrame(const CancelPushFrame& frame) override {
+ bool OnCancelPushFrame(const CancelPushFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Cancel Push");
return false;
}
- bool OnMaxPushIdFrame(const MaxPushIdFrame& frame) override {
+ bool OnMaxPushIdFrame(const MaxPushIdFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Max Push Id");
return false;
}
- bool OnGoAwayFrame(const GoAwayFrame& frame) override {
+ bool OnGoAwayFrame(const GoAwayFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Goaway");
return false;
}
@@ -52,17 +52,17 @@
return stream_->OnSettingsFrame(frame);
}
- bool OnDuplicatePushFrame(const DuplicatePushFrame& frame) override {
+ bool OnDuplicatePushFrame(const DuplicatePushFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Duplicate Push");
return false;
}
- bool OnDataFrameStart(Http3FrameLengths frame_lengths) override {
+ bool OnDataFrameStart(Http3FrameLengths /*frame_lengths*/) override {
CloseConnectionOnWrongFrame("Data");
return false;
}
- bool OnDataFramePayload(QuicStringPiece payload) override {
+ bool OnDataFramePayload(QuicStringPiece /*payload*/) override {
CloseConnectionOnWrongFrame("Data");
return false;
}
@@ -72,12 +72,12 @@
return false;
}
- bool OnHeadersFrameStart(Http3FrameLengths frame_length) override {
+ bool OnHeadersFrameStart(Http3FrameLengths /*frame_length*/) override {
CloseConnectionOnWrongFrame("Headers");
return false;
}
- bool OnHeadersFramePayload(QuicStringPiece payload) override {
+ bool OnHeadersFramePayload(QuicStringPiece /*payload*/) override {
CloseConnectionOnWrongFrame("Headers");
return false;
}
@@ -87,12 +87,12 @@
return false;
}
- bool OnPushPromiseFrameStart(PushId push_id) override {
+ bool OnPushPromiseFrameStart(PushId /*push_id*/) override {
CloseConnectionOnWrongFrame("Push Promise");
return false;
}
- bool OnPushPromiseFramePayload(QuicStringPiece payload) override {
+ bool OnPushPromiseFramePayload(QuicStringPiece /*payload*/) override {
CloseConnectionOnWrongFrame("Push Promise");
return false;
}
@@ -124,7 +124,8 @@
QuicReceiveControlStream::~QuicReceiveControlStream() {}
-void QuicReceiveControlStream::OnStreamReset(const QuicRstStreamFrame& frame) {
+void QuicReceiveControlStream::OnStreamReset(
+ const QuicRstStreamFrame& /*frame*/) {
// TODO(renjietang) Change the error code to H/3 specific
// HTTP_CLOSED_CRITICAL_STREAM.
session()->connection()->CloseConnection(
diff --git a/quic/core/http/quic_send_control_stream.cc b/quic/core/http/quic_send_control_stream.cc
index 8002b0c..941c6c0 100644
--- a/quic/core/http/quic_send_control_stream.cc
+++ b/quic/core/http/quic_send_control_stream.cc
@@ -14,7 +14,7 @@
: QuicStream(id, session, /*is_static = */ true, WRITE_UNIDIRECTIONAL),
settings_sent_(false) {}
-void QuicSendControlStream::OnStreamReset(const QuicRstStreamFrame& frame) {
+void QuicSendControlStream::OnStreamReset(const QuicRstStreamFrame& /*frame*/) {
// TODO(renjietang) Change the error code to H/3 specific
// HTTP_CLOSED_CRITICAL_STREAM.
session()->connection()->CloseConnection(
diff --git a/quic/core/http/quic_spdy_client_session.cc b/quic/core/http/quic_spdy_client_session.cc
index ee81dcf..50ed00d 100644
--- a/quic/core/http/quic_spdy_client_session.cc
+++ b/quic/core/http/quic_spdy_client_session.cc
@@ -176,7 +176,7 @@
this);
}
-bool QuicSpdyClientSession::IsAuthorized(const std::string& authority) {
+bool QuicSpdyClientSession::IsAuthorized(const std::string& /*authority*/) {
return true;
}
diff --git a/quic/core/http/quic_spdy_client_session_base.cc b/quic/core/http/quic_spdy_client_session_base.cc
index 93f6880..fe7e21c 100644
--- a/quic/core/http/quic_spdy_client_session_base.cc
+++ b/quic/core/http/quic_spdy_client_session_base.cc
@@ -186,7 +186,8 @@
headers_stream()->MaybeReleaseSequencerBuffer();
}
-void QuicSpdyClientSessionBase::OnPushStreamTimedOut(QuicStreamId stream_id) {}
+void QuicSpdyClientSessionBase::OnPushStreamTimedOut(
+ QuicStreamId /*stream_id*/) {}
void QuicSpdyClientSessionBase::ResetPromised(
QuicStreamId id,
diff --git a/quic/core/http/quic_spdy_session.cc b/quic/core/http/quic_spdy_session.cc
index 5004557..fbe8407 100644
--- a/quic/core/http/quic_spdy_session.cc
+++ b/quic/core/http/quic_spdy_session.cc
@@ -106,19 +106,19 @@
header_list_.Clear();
}
- void OnStreamFrameData(SpdyStreamId stream_id,
- const char* data,
- size_t len) override {
+ void OnStreamFrameData(SpdyStreamId /*stream_id*/,
+ const char* /*data*/,
+ size_t /*len*/) override {
CloseConnection("SPDY DATA frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
- void OnStreamEnd(SpdyStreamId stream_id) override {
+ void OnStreamEnd(SpdyStreamId /*stream_id*/) override {
// The framer invokes OnStreamEnd after processing a frame that had the fin
// bit set.
}
- void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
+ void OnStreamPadding(SpdyStreamId /*stream_id*/, size_t /*len*/) override {
CloseConnection("SPDY frame padding received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
@@ -138,14 +138,15 @@
code);
}
- void OnDataFrameHeader(SpdyStreamId stream_id,
- size_t length,
- bool fin) override {
+ void OnDataFrameHeader(SpdyStreamId /*stream_id*/,
+ size_t /*length*/,
+ bool /*fin*/) override {
CloseConnection("SPDY DATA frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
- void OnRstStream(SpdyStreamId stream_id, SpdyErrorCode error_code) override {
+ void OnRstStream(SpdyStreamId /*stream_id*/,
+ SpdyErrorCode /*error_code*/) override {
CloseConnection("SPDY RST_STREAM frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
@@ -185,13 +186,13 @@
void OnSettingsEnd() override {}
- void OnPing(SpdyPingId unique_id, bool is_ack) override {
+ void OnPing(SpdyPingId /*unique_id*/, bool /*is_ack*/) override {
CloseConnection("SPDY PING frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
- void OnGoAway(SpdyStreamId last_accepted_stream_id,
- SpdyErrorCode error_code) override {
+ void OnGoAway(SpdyStreamId /*last_accepted_stream_id*/,
+ SpdyErrorCode /*error_code*/) override {
CloseConnection("SPDY GOAWAY frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
@@ -202,7 +203,7 @@
SpdyStreamId /*parent_stream_id*/,
bool /*exclusive*/,
bool fin,
- bool end) override {
+ bool /*end*/) override {
if (!session_->IsConnected()) {
return;
}
@@ -220,14 +221,15 @@
session_->OnHeaders(stream_id, has_priority, priority, fin);
}
- void OnWindowUpdate(SpdyStreamId stream_id, int delta_window_size) override {
+ void OnWindowUpdate(SpdyStreamId /*stream_id*/,
+ int /*delta_window_size*/) override {
CloseConnection("SPDY WINDOW_UPDATE frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
}
void OnPushPromise(SpdyStreamId stream_id,
SpdyStreamId promised_stream_id,
- bool end) override {
+ bool /*end*/) override {
if (!session_->supports_push_promise()) {
CloseConnection("PUSH_PROMISE not supported.",
QUIC_INVALID_HEADERS_STREAM_DATA);
@@ -239,12 +241,12 @@
session_->OnPushPromise(stream_id, promised_stream_id);
}
- void OnContinuation(SpdyStreamId stream_id, bool end) override {}
+ void OnContinuation(SpdyStreamId /*stream_id*/, bool /*end*/) override {}
void OnPriority(SpdyStreamId stream_id,
- SpdyStreamId parent_id,
+ SpdyStreamId /*parent_id*/,
int weight,
- bool exclusive) override {
+ bool /*exclusive*/) override {
if (session_->connection()->transport_version() <= QUIC_VERSION_39) {
CloseConnection("SPDY PRIORITY frame received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
@@ -259,15 +261,16 @@
session_->OnPriority(stream_id, priority);
}
- bool OnUnknownFrame(SpdyStreamId stream_id, uint8_t frame_type) override {
+ bool OnUnknownFrame(SpdyStreamId /*stream_id*/,
+ uint8_t /*frame_type*/) override {
CloseConnection("Unknown frame type received.",
QUIC_INVALID_HEADERS_STREAM_DATA);
return false;
}
// SpdyFramerDebugVisitorInterface implementation
- void OnSendCompressedFrame(SpdyStreamId stream_id,
- SpdyFrameType type,
+ void OnSendCompressedFrame(SpdyStreamId /*stream_id*/,
+ SpdyFrameType /*type*/,
size_t payload_len,
size_t frame_len) override {
if (payload_len == 0) {
@@ -278,8 +281,8 @@
QUIC_DVLOG(1) << "Net.QuicHpackCompressionPercentage: " << compression_pct;
}
- void OnReceiveCompressedFrame(SpdyStreamId stream_id,
- SpdyFrameType type,
+ void OnReceiveCompressedFrame(SpdyStreamId /*stream_id*/,
+ SpdyFrameType /*type*/,
size_t frame_len) override {
if (session_->IsConnected()) {
session_->OnCompressedFrameSize(frame_len);
@@ -396,28 +399,28 @@
set_max_decode_buffer_size_bytes(2 * max_inbound_header_list_size_);
}
-void QuicSpdySession::OnDecoderStreamError(QuicStringPiece error_message) {
+void QuicSpdySession::OnDecoderStreamError(QuicStringPiece /*error_message*/) {
DCHECK(VersionUsesQpack(connection()->transport_version()));
// TODO(112770235): Signal connection error on decoder stream errors.
QUIC_NOTREACHED();
}
-void QuicSpdySession::WriteEncoderStreamData(QuicStringPiece data) {
+void QuicSpdySession::WriteEncoderStreamData(QuicStringPiece /*data*/) {
DCHECK(VersionUsesQpack(connection()->transport_version()));
// TODO(112770235): Send encoder stream data on encoder stream.
QUIC_NOTREACHED();
}
-void QuicSpdySession::OnEncoderStreamError(QuicStringPiece error_message) {
+void QuicSpdySession::OnEncoderStreamError(QuicStringPiece /*error_message*/) {
DCHECK(VersionUsesQpack(connection()->transport_version()));
// TODO(112770235): Signal connection error on encoder stream errors.
QUIC_NOTREACHED();
}
-void QuicSpdySession::WriteDecoderStreamData(QuicStringPiece data) {
+void QuicSpdySession::WriteDecoderStreamData(QuicStringPiece /*data*/) {
DCHECK(VersionUsesQpack(connection()->transport_version()));
// TODO(112770235): Send decoder stream data on decoder stream.
@@ -614,10 +617,11 @@
return frame.size();
}
-void QuicSpdySession::OnPromiseHeaderList(QuicStreamId stream_id,
- QuicStreamId promised_stream_id,
- size_t frame_len,
- const QuicHeaderList& header_list) {
+void QuicSpdySession::OnPromiseHeaderList(
+ QuicStreamId /*stream_id*/,
+ QuicStreamId /*promised_stream_id*/,
+ size_t /*frame_len*/,
+ const QuicHeaderList& /*header_list*/) {
std::string error =
"OnPromiseHeaderList should be overridden in client code.";
QUIC_BUG << error;
diff --git a/quic/core/http/quic_spdy_stream.cc b/quic/core/http/quic_spdy_stream.cc
index fa43d54..6c1f2ad 100644
--- a/quic/core/http/quic_spdy_stream.cc
+++ b/quic/core/http/quic_spdy_stream.cc
@@ -39,43 +39,43 @@
HttpDecoderVisitor(const HttpDecoderVisitor&) = delete;
HttpDecoderVisitor& operator=(const HttpDecoderVisitor&) = delete;
- void OnError(HttpDecoder* decoder) override {
+ void OnError(HttpDecoder* /*decoder*/) override {
stream_->session()->connection()->CloseConnection(
QUIC_HTTP_DECODER_ERROR, "Http decoder internal error",
ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
}
- bool OnPriorityFrame(const PriorityFrame& frame) override {
+ bool OnPriorityFrame(const PriorityFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Priority");
return false;
}
- bool OnCancelPushFrame(const CancelPushFrame& frame) override {
+ bool OnCancelPushFrame(const CancelPushFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Cancel Push");
return false;
}
- bool OnMaxPushIdFrame(const MaxPushIdFrame& frame) override {
+ bool OnMaxPushIdFrame(const MaxPushIdFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Max Push Id");
return false;
}
- bool OnGoAwayFrame(const GoAwayFrame& frame) override {
+ bool OnGoAwayFrame(const GoAwayFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Goaway");
return false;
}
- bool OnSettingsFrameStart(Http3FrameLengths frame_lengths) override {
+ bool OnSettingsFrameStart(Http3FrameLengths /*frame_lengths*/) override {
CloseConnectionOnWrongFrame("Settings");
return false;
}
- bool OnSettingsFrame(const SettingsFrame& frame) override {
+ bool OnSettingsFrame(const SettingsFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Settings");
return false;
}
- bool OnDuplicatePushFrame(const DuplicatePushFrame& frame) override {
+ bool OnDuplicatePushFrame(const DuplicatePushFrame& /*frame*/) override {
CloseConnectionOnWrongFrame("Duplicate Push");
return false;
}
@@ -119,7 +119,7 @@
return stream_->OnHeadersFrameEnd();
}
- bool OnPushPromiseFrameStart(PushId push_id) override {
+ bool OnPushPromiseFrameStart(PushId /*push_id*/) override {
CloseConnectionOnWrongFrame("Push Promise");
return false;
}
diff --git a/quic/core/http/quic_spdy_stream.h b/quic/core/http/quic_spdy_stream.h
index caff21b..c0431f1 100644
--- a/quic/core/http/quic_spdy_stream.h
+++ b/quic/core/http/quic_spdy_stream.h
@@ -51,8 +51,8 @@
virtual void OnClose(QuicSpdyStream* stream) = 0;
// Allows subclasses to override and do work.
- virtual void OnPromiseHeadersComplete(QuicStreamId promised_id,
- size_t frame_len) {}
+ virtual void OnPromiseHeadersComplete(QuicStreamId /*promised_id*/,
+ size_t /*frame_len*/) {}
protected:
virtual ~Visitor() {}
diff --git a/quic/core/http/quic_spdy_stream_test.cc b/quic/core/http/quic_spdy_stream_test.cc
index 66100bb..64e45b9 100644
--- a/quic/core/http/quic_spdy_stream_test.cc
+++ b/quic/core/http/quic_spdy_stream_test.cc
@@ -78,7 +78,7 @@
size_t WriteHeadersImpl(spdy::SpdyHeaderBlock header_block,
bool fin,
QuicReferenceCountedPointer<QuicAckListenerInterface>
- ack_listener) override {
+ /*ack_listener*/) override {
saved_headers_ = std::move(header_block);
WriteHeadersMock(fin);
if (VersionUsesQpack(transport_version())) {
