commit 15042969d6bb22cc878e443acbe16501d7b3875e
author fayang <fayang@google.com> Wed Jul 01 12:14:29 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Jul 01 12:15:16 2020 -0700
tree f908e0f9a16d7ebf19a780cb46c557cdb0696f7f
parent 1c41a1dd37684890d0070642f55ce88d9b19ba32

In quic, determine a serialized packet fate before it gets serialized, and use the fate to determine whether add full padding later. protected by gfe2_reloadable_flag_quic_determine_serialized_packet_fate_early.

PiperOrigin-RevId: 319272370
Change-Id: I43b3b823d50cd5f9c1b8c7d946eb1319706ee41e

quic/core/quic_packet_creator.h

diff --git a/quic/core/quic_packet_creator.h b/quic/core/quic_packet_creator.h
index c579e42..e5a73c3 100644
--- a/quic/core/quic_packet_creator.h
+++ b/quic/core/quic_packet_creator.h
@@ -58,6 +58,13 @@
     // Called when there is data to be sent. Retrieves updated ACK frame from
     // the delegate.
     virtual const QuicFrames MaybeBundleAckOpportunistically() = 0;
+
+    // Returns the packet fate for serialized packets which will be handed over
+    // to delegate via OnSerializedPacket(). Called when a packet is about to be
+    // serialized.
+    virtual SerializedPacketFate GetSerializedPacketFate(
+        bool is_mtu_discovery,
+        EncryptionLevel encryption_level) = 0;
   };
 
   // Interface which gets callbacks from the QuicPacketCreator at interesting
@@ -442,6 +449,10 @@
     disable_padding_override_ = should_disable_padding;
   }
 
+  bool determine_serialized_packet_fate_early() const {
+    return determine_serialized_packet_fate_early_;
+  }
+
  private:
   friend class test::QuicPacketCreatorPeer;
 
@@ -628,6 +639,8 @@
       GetQuicReloadableFlag(quic_fix_min_crypto_frame_size);
 
   // When true, this will override the padding generation code to disable it.
+  // TODO(fayang): remove this when deprecating
+  // quic_determine_serialized_packet_fate_early.
   bool disable_padding_override_ = false;
 
   const bool update_packet_size_ =
@@ -635,6 +648,9 @@
 
   const bool fix_extra_padding_bytes_ =
       GetQuicReloadableFlag(quic_fix_extra_padding_bytes);
+
+  const bool determine_serialized_packet_fate_early_ =
+      GetQuicReloadableFlag(quic_determine_serialized_packet_fate_early);
 };
 
 }  // namespace quic