commit 07a2b0784bcb03638b7728c610b1aef5a4e86b03
author wub <wub@google.com> Thu Oct 24 11:23:20 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Oct 24 11:24:00 2019 -0700
tree 8e1ee7ff975116d221c37bb712ec44cd230f2e8b
parent b38e635502035083ead0d64e26026ee724238c65

Fix 26 ClangTidy - Readability findings in //depot/google3/third_party/quic/.

These fixes are automatically created by various analysis tools, but their application in this CL has been manually triggered.  See go/code-findings-fixes.

* redundant get() call on smart pointer (11 times)
* using decl 'Perspective' is unused
* using decl 'SETTINGS_MAX_HEADER_LIST_SIZE' is unused (2 times)
* using decl 'AtLeast' is unused
* using decl 'SpdySettingsIR' is unused
* using decl 'Pair' is unused
* using decl 'UnorderedElementsAre' is unused
* using decl 'Values' is unused
* using decl 'Combine' is unused
* using decl 'Invoke' is unused
* lambda capture 'this' is not used (4 times)
* using decl 'QuicSocketAddress' is unused

PiperOrigin-RevId: 276529025
Change-Id: Icee20b5bab6c9d8cc6c95b74594469257e791cb0

quic/qbone/platform/netlink_test.cc

diff --git a/quic/qbone/platform/netlink_test.cc b/quic/qbone/platform/netlink_test.cc
index 7bd5f6b..04ce68c 100644
--- a/quic/qbone/platform/netlink_test.cc
+++ b/quic/qbone/platform/netlink_test.cc
@@ -45,7 +45,7 @@
     InSequence s;
 
     EXPECT_CALL(mock_kernel_, sendmsg(kSocketFd, _, _))
-        .WillOnce(Invoke([this, type, flags, send_callback](
+        .WillOnce(Invoke([type, flags, send_callback](
                              Unused, const struct msghdr* msg, int) {
           EXPECT_EQ(sizeof(struct sockaddr_nl), msg->msg_namelen);
           auto* nl_addr =
@@ -251,7 +251,7 @@
 
   ExpectNetlinkPacket(
       RTM_GETLINK, NLM_F_ROOT | NLM_F_MATCH | NLM_F_REQUEST,
-      [this, &hwaddr, &bcaddr](void* buf, size_t len, int seq) {
+      [&hwaddr, &bcaddr](void* buf, size_t len, int seq) {
         int ret = 0;
 
         struct nlmsghdr* netlink_message =
@@ -291,7 +291,7 @@
 
   ExpectNetlinkPacket(
       RTM_GETADDR, NLM_F_ROOT | NLM_F_MATCH | NLM_F_REQUEST,
-      [this, &addresses](void* buf, size_t len, int seq) {
+      [&addresses](void* buf, size_t len, int seq) {
         int ret = 0;
 
         struct nlmsghdr* nlm = nullptr;