Fix 26 ClangTidy - Readability findings in //depot/google3/third_party/quic/.
These fixes are automatically created by various analysis tools, but their application in this CL has been manually triggered. See go/code-findings-fixes.
* redundant get() call on smart pointer (11 times)
* using decl 'Perspective' is unused
* using decl 'SETTINGS_MAX_HEADER_LIST_SIZE' is unused (2 times)
* using decl 'AtLeast' is unused
* using decl 'SpdySettingsIR' is unused
* using decl 'Pair' is unused
* using decl 'UnorderedElementsAre' is unused
* using decl 'Values' is unused
* using decl 'Combine' is unused
* using decl 'Invoke' is unused
* lambda capture 'this' is not used (4 times)
* using decl 'QuicSocketAddress' is unused
PiperOrigin-RevId: 276529025
Change-Id: Icee20b5bab6c9d8cc6c95b74594469257e791cb0
diff --git a/quic/core/quic_framer.cc b/quic/core/quic_framer.cc
index 2d4d4a5..b219042 100644
--- a/quic/core/quic_framer.cc
+++ b/quic/core/quic_framer.cc
@@ -1904,7 +1904,7 @@
std::unique_ptr<CryptoHandshakeMessage> reset(
CryptoFramer::ParseMessage(reader->ReadRemainingPayload()));
- if (!reset.get()) {
+ if (!reset) {
set_detailed_error("Unable to read reset message.");
RecordDroppedPacketReason(DroppedPacketReason::INVALID_PUBLIC_RESET_PACKET);
return RaiseError(QUIC_INVALID_PUBLIC_RST_PACKET);