Remove OnApplicationClose upcalls, update OnConnectionClose as needed.
Replaces the OnApplicationClose visitor upcalls with OnConnectionClose. The IETF removes the separate Application Close frame from QUIC, modifying the Connection Close frame to have two flavors; one for Application-initiated reasons, the other for Transport reasons. These were formerly the Application- and Connection- closes.
gfe-relnote: N/A this is only for IETF QUIC (version 99).
PiperOrigin-RevId: 243856589
Change-Id: Ie048aa2a8641f7e3f84b6cd7e4fc6ce61d5683e7
diff --git a/quic/core/quic_framer_test.cc b/quic/core/quic_framer_test.cc
index 4cb837e..2ffe54e 100644
--- a/quic/core/quic_framer_test.cc
+++ b/quic/core/quic_framer_test.cc
@@ -315,15 +315,6 @@
return true;
}
- // TODO(fkastenholz): Remove when IETF QUIC is completely converted to
- // doing Connection Close.
- bool OnApplicationCloseFrame(const QuicConnectionCloseFrame& frame) override {
- // OnApplicationCloseFrame receives a QuicConnectionCloseFrame as part of
- // migration to IETF QUIC's new model.
- connection_close_frame_ = frame;
- return true;
- }
-
bool OnStopSendingFrame(const QuicStopSendingFrame& frame) override {
stop_sending_frame_ = frame;
return true;
@@ -4452,6 +4443,7 @@
CheckFramingBoundaries(fragments, QUIC_INVALID_CONNECTION_CLOSE_DATA);
}
+// Test the CONNECTION_CLOSE/Application variant.
TEST_P(QuicFramerTest, ApplicationCloseFrame) {
if (framer_.transport_version() != QUIC_VERSION_99) {
// This frame does not exist in versions other than 99.
@@ -4509,7 +4501,7 @@
ASSERT_EQ(0u, visitor_.ack_frames_.size());
- CheckFramingBoundaries(packet99, QUIC_INVALID_APPLICATION_CLOSE_DATA);
+ CheckFramingBoundaries(packet99, QUIC_INVALID_CONNECTION_CLOSE_DATA);
}
TEST_P(QuicFramerTest, GoAwayFrame) {
