)]}' { "log": [ { "commit": "5f41064f20a12fe4ecc50c076bf6743da15739f9", "tree": "46ffd38541abf18c9d593ca0a56717602f4091d6", "parents": [ "75c002fa7dcf52dc50c801888f777879e24fb1d2" ], "author": { "name": "ramosalex", "email": "ramosalex@google.com", "time": "Thu Mar 28 14:20:33 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 28 14:21:28 2024 -0700" }, "message": "Add new metrics to measure throughput in QBONE.\n\nHistorically, QBONE relies on metrics exported by the GFE and QUIC to measure throughput in bytes and packets:\n\n* `/gfe/gfe2/http/bytes_in` for throughput in bytes to prod.\n* `/gfe/gfe2/http/bytes_out` for throughput in bytes from prod.\n* `/gfe/gfe2/spdy4_over_quic/packets_quic_read` for throughput in packets to prod.\n* `/gfe/gfe2/spdy4_over_quic/connection_packet_writer_total_packets_sent` for throughput in packets from prod.\n\nThe initial motivation for this CL was to add a `traffic_class` dimension to the above methods, but as that involved modified non-QBONE code I decided to implement new QBONE-specific metrics. Each of the metrics in this CL have two dimensions:\n\n* `direction`: TO_PROD or FROM_PROD\n* `traffic_class`: A string that represents the traffic class of the packets.\n\nA follow up CL will change the dashboard to use these metrics instead of the old ones once this is fully rolled out.\n\nPiperOrigin-RevId: 620055645\n" }, { "commit": "75c002fa7dcf52dc50c801888f777879e24fb1d2", "tree": "11c32d8c29cf2da7415aca0843cc647c6cd1dbe9", "parents": [ "7640b5cd7defafe56c69068daabe4e173b53bbbf" ], "author": { "name": "diannahu", "email": "diannahu@google.com", "time": "Thu Mar 28 07:19:05 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 28 07:20:12 2024 -0700" }, "message": "Latch in SpdyHeadersIR the feature flag that updates SpdyHeadersIR::size().\n\nWe observed a b/331280235 coredump with the following Http2WriteQueue member:\n ...\n pending_frames_bytes_ \u003d 18446744073709551614,\n ...\n\nFrom this value, we found that different values of\n--gfe2_reloadable_flag_http2_add_hpack_overhead_bytes at various size() call\nsites could lead to inconsistent size estimate values, which would lead to\nissues when attempting to write.\n\nThe new regression test would have failed using the initial version of this\nflag: http://sponge2/ae76de9d-6a60-4031-bc9b-12a95ec6ae47 (failed).\n\nThis CL deprecates --gfe2_reloadable_flag_http2_add_hpack_overhead_bytes and\nrenames the flag with the new behavivor to latch in SpdyHeadersIR.\n\nThis CL also changes some Http2WriteQueue member types from size_t to ssize_t.\n\nProtected by FLAGS_gfe2_reloadable_flag_http2_add_hpack_overhead_bytes2.\n\nPiperOrigin-RevId: 619920782\n" }, { "commit": "7640b5cd7defafe56c69068daabe4e173b53bbbf", "tree": "2d09d0f9176764ade7990dfeb23eb33f8fab2e41", "parents": [ "aa0b2ec36fa95c55a51c063b01359eb594ef2425" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Tue Mar 26 12:35:57 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 12:36:55 2024 -0700" }, "message": "Turn ConnectionStateOnSentPacket into an opaque class.\n\nThis will be useful when experimenting with alternative internal representations of ConnectionStateOnSentPacket fields.\n\nPiperOrigin-RevId: 619277286\n" }, { "commit": "aa0b2ec36fa95c55a51c063b01359eb594ef2425", "tree": "2fc83cd9b939fe40eb5bcad4bcd16e68f0731ee7", "parents": [ "2be1e8077fabdbf056dcea6b207b6501752aefb7" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Tue Mar 26 11:31:30 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 11:32:34 2024 -0700" }, "message": "Turn bbr2 probe rtt params into flags for easier configuration.\n\nThis should be a noop change to existing code.\n\nProtected by QUIC presubmit tests.\n\nPiperOrigin-RevId: 619257962\n" }, { "commit": "2be1e8077fabdbf056dcea6b207b6501752aefb7", "tree": "a764e8aa8ebcd305b6e40f974739b6e66d17241f", "parents": [ "cfc749e71c9b618ef49691cb4b08290ebe6cbe6f" ], "author": { "name": "elburrito", "email": "elburrito@google.com", "time": "Tue Mar 26 09:47:32 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 09:48:24 2024 -0700" }, "message": "Add java_package annotations to QUICHE and Anonymous Tokens protos for compilation in Java.\n\nPiperOrigin-RevId: 619221591\n" }, { "commit": "cfc749e71c9b618ef49691cb4b08290ebe6cbe6f", "tree": "ce5a82b6e15a48e5add6811875f7a425d8524a4d", "parents": [ "e3bb80b112c40442145d4df708a0a21f6f9aa944" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Tue Mar 26 09:27:45 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 09:28:49 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in quiche/oblivious_http tests\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL is not expected to introduce any changes in functionality other than now verifying that the call to absl::HexStringToBytes was successful.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 619215781\n" }, { "commit": "e3bb80b112c40442145d4df708a0a21f6f9aa944", "tree": "80d4e6fb39e625beadcc05982081d88da8298116", "parents": [ "35e36904df0bb8accb9b966333ca9fd53c2366d5" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Tue Mar 26 09:06:25 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 09:07:23 2024 -0700" }, "message": "Option for rejecting isolated carriage returns in header values.\n\nPiperOrigin-RevId: 619209119\n" }, { "commit": "35e36904df0bb8accb9b966333ca9fd53c2366d5", "tree": "766dfd3193de85c46ac7d59d972c7ef72f9bb0fd", "parents": [ "08990e5915e05eb526acfe7a47a8273f5ae63f0b" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Tue Mar 26 08:40:28 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 08:41:20 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in remaining spdy/ tests\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL is not expected to introduce any changes in functionality other than now verifying that the call to absl::HexStringToBytes was successful.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 619201898\n" }, { "commit": "08990e5915e05eb526acfe7a47a8273f5ae63f0b", "tree": "fa03706ffa6113b2ae366378c56e3e81a9c6b919", "parents": [ "5b7b61e56f2dbc3ade039f4d447b988cbde112c2" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Tue Mar 26 06:35:28 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 26 06:36:31 2024 -0700" }, "message": "Avoid dynamically allocating memory within QuicFramer::RemoveHeaderProtection\n\nPiperOrigin-RevId: 619170558\n" }, { "commit": "5b7b61e56f2dbc3ade039f4d447b988cbde112c2", "tree": "3ec4dedb972a0f63f552b66d003914cca396b112", "parents": [ "f7a30402f7c051ff7c4f7cb59704318cd04db926" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Mon Mar 25 21:02:38 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 25 21:04:20 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in http2/ tests and example program\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL is not expected to introduce any changes in functionality other than now verifying that the call to absl::HexStringToBytes was successful.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 619051987\n" }, { "commit": "f7a30402f7c051ff7c4f7cb59704318cd04db926", "tree": "34d882b7ce7d70c003254e4b3850e458d0148fb9", "parents": [ "17b9f37ea501b1aff6541cd59be841e77de964ec" ], "author": { "name": "elburrito", "email": "elburrito@google.com", "time": "Mon Mar 25 10:15:27 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 25 10:17:12 2024 -0700" }, "message": "BlindSignAuth: Remove support for RSA-BSSA tokens, all future tokens must be Privacy Pass. No clients are making requests for RSA-BSSA tokens.\nAlso cleans up references to public_metadata_info.\n\nPiperOrigin-RevId: 618881333\n" }, { "commit": "17b9f37ea501b1aff6541cd59be841e77de964ec", "tree": "a9e9cd3b45f28b137125bb7bfdbf851f4b3e8456", "parents": [ "5a5081c2cfeea7d7a68558fec74121be2abbca9a" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Sat Mar 23 10:14:17 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Mar 23 10:15:14 2024 -0700" }, "message": "Fix 15 ProtobufTransformer findings:\n* Upgrade to the latest edition (15 times)\n\n* See go/editions for more information about this migration.\n* Based on blaze dependency analysis, these protos were found to only used in languages known to support editions.* If this proto is later required in a language that doesn\u0027t support editions yet, a pure rollback is safe and recommended.\n\nSee go/protobuf-edition-zero-lsc for more information on why you\u0027ve received this change and why it is important.\n\nThis CL looks good? Just LGTM and Approve it!\nThis CL doesn’t look good? This is what you can do:\n* Revert this CL, by replying \"REVERT: \u003cprovide reason\u003e\"\n* File a bug under go/protobuf-transformer-issue for category ProtobufTransformer if there\u0027s an issue with the CL content.\n* File a bug under go/rosie-bug if there\u0027s an issue with how the CL was managed.\n* For all other issues such as the formatting of the CL, please file a bug under\ngo/clrobot-bug.\n* Revert this CL and not get a CL that cleans up these paths in the future by\nreplying \"BLOCKLIST: \u003cprovide reason\u003e\". This is not reversible! We recommend to\nopt out the respective paths in your CL Robot configuration instead:\ngo/clrobot-opt-out.\n\nThis CL was generated by CL Robot - a tool that cleans up code findings\n(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by\nfollowing go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug\nat go/clrobot-bug.\n\n#codehealth\n\nTested:\n Local presubmit tests passed.\nPiperOrigin-RevId: 618466227\n" }, { "commit": "5a5081c2cfeea7d7a68558fec74121be2abbca9a", "tree": "abceab038c2f5c1987cb068c710a636883a14cde", "parents": [ "d17e28d50b09f548431aa58794c14ea5876521a9" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Thu Mar 21 09:51:24 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 21 09:52:29 2024 -0700" }, "message": "No public description\n\nPiperOrigin-RevId: 617875632\n" }, { "commit": "d17e28d50b09f548431aa58794c14ea5876521a9", "tree": "c03c8597fca9eadda9b8c9932d55d434d5838799", "parents": [ "6767ab5a6a07eedd1303887fd2ce65516951524e" ], "author": { "name": "bnc", "email": "bnc@google.com", "time": "Thu Mar 21 07:23:24 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 21 07:24:17 2024 -0700" }, "message": "Remove obsolete http2 and spdy test-only flags.\n\nThese flags date back to when //third_party/spdy and third_party/http2 had their\nown platformized flag implementations. They are not used any longer.\n\nFour quic_testonly flags (restart and reloadable, default true and default\nfalse) are kept so that flag implementations can be tested.\n\nReloadable flags are deprecated and restart flags are deleted, following the\nmost recent guidelines.\n\nPiperOrigin-RevId: 617834878\n" }, { "commit": "6767ab5a6a07eedd1303887fd2ce65516951524e", "tree": "ec7991b43b2d305748686b34c6e2a16385b53f8a", "parents": [ "81431cae0b27a1e67c38946e394ce61296d8070f" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Wed Mar 20 22:20:34 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 20 22:21:31 2024 -0700" }, "message": "Deprecate --gfe2_reloadable_flag_quic_disable_version_q050\nand remove QUIC_VERSION_50. This leaves Q046 as the only\ngQUIC version supported by QUICHE!\n\nPiperOrigin-RevId: 617727660\n" }, { "commit": "81431cae0b27a1e67c38946e394ce61296d8070f", "tree": "6baf9583af1bbb25c3756622aadf6494f9498fc2", "parents": [ "19e696497106ec21fda04f95ebaa52d3d3c36047" ], "author": { "name": "dschinazi", "email": "dschinazi@google.com", "time": "Wed Mar 20 20:27:54 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 20 20:28:58 2024 -0700" }, "message": "Update comment now that RFC is published\n\nPiperOrigin-RevId: 617708461\n" }, { "commit": "19e696497106ec21fda04f95ebaa52d3d3c36047", "tree": "e1063c1726f289748286b629cdca0a5c9fc4248f", "parents": [ "a484a561d3d36beca0d4dc9f5d4a2c083be03e1f" ], "author": { "name": "bnc", "email": "bnc@google.com", "time": "Wed Mar 20 10:32:13 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 20 10:33:37 2024 -0700" }, "message": "Fix QuicToyClient::SendRequestsAndPrintResponses() in release mode.\n\nQUICHE_DCHECK() does not evaluate its argument in release mode.\n\nPiperOrigin-RevId: 617557773\n" }, { "commit": "a484a561d3d36beca0d4dc9f5d4a2c083be03e1f", "tree": "9b5d012c90c74af02d030c0a398c3777e4fe1757", "parents": [ "deff8b6e1f3303cee75569a6637c6e14ed320bcb" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Tue Mar 19 17:22:54 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 19 17:24:18 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in test programs and remaining quic/ tests\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL isn\u0027t expected to change the behavior of any code used in production.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 617342915\n" }, { "commit": "deff8b6e1f3303cee75569a6637c6e14ed320bcb", "tree": "ef655997e91acc9abe50a259311da8d335d5eb98", "parents": [ "10053f8f199aa6d6ad7727b3112db9e62884bb8c" ], "author": { "name": "ramosalex", "email": "ramosalex@google.com", "time": "Tue Mar 19 09:56:21 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 19 09:57:12 2024 -0700" }, "message": "Add QoS dimension to packet processor result metrics.\n\nPiperOrigin-RevId: 617205961\n" }, { "commit": "10053f8f199aa6d6ad7727b3112db9e62884bb8c", "tree": "a3cbbc6754ed30392b9baeaebe187c17686680ae", "parents": [ "940131f1b54be9d7b05d2b13376936265db7c863" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Tue Mar 19 09:17:14 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 19 09:18:04 2024 -0700" }, "message": "Updates the callback struct in line with the latest version of nghttp2.\n\nPiperOrigin-RevId: 617193731\n" }, { "commit": "940131f1b54be9d7b05d2b13376936265db7c863", "tree": "9fa49f8e76081dbe5ae336fd13568eb5fe21bf0e", "parents": [ "0108b67fe836b20cebf94e00a7afe3a1e4724899" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Tue Mar 19 08:41:05 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 19 08:42:04 2024 -0700" }, "message": "Add a 3rd flag count for quic_enable_http3_metadata_decoding.\n\nProtected by FLAGS_quic_reloadable_flag_quic_enable_http3_metadata_decoding.\n\nPiperOrigin-RevId: 617183882\n" }, { "commit": "0108b67fe836b20cebf94e00a7afe3a1e4724899", "tree": "c686b442c75598d40cc5f9cf34b928427ed076ac", "parents": [ "a3bc1ffed7da5f84f7fe7e97d397c85be0800c3c" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Mon Mar 18 12:20:36 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 18 12:21:51 2024 -0700" }, "message": "Automated g4 rollback of changelist 616801281.\n\n*** Reason for rollback ***\n\nBreaks Envoy\n\n*** Original change description ***\n\nUpdate ParseQuicTag to only use hex decoding if valid\n\nParseQuicTag was using absl::HexStringToBytes to unconditionally decode strings when they were 8 bytes long, but for strings with non-hexidecimal characters the return value of calling absl::HexStringToBytes is unspecified. This CL updates ParseQuicTag to only use the output of absl::HexStringToBytes when the call returns success.\n\nThis also moves the code away from using the deprecated version of absl::HexStringToBytes, allowing the Chrome...\n\n***\n\nPiperOrigin-RevId: 616910027\n" }, { "commit": "a3bc1ffed7da5f84f7fe7e97d397c85be0800c3c", "tree": "63c4cc74d6e882755e1136126b540fe9dab3e710", "parents": [ "30534678683f4172406c1bc98e69729cd8d0e4ff" ], "author": { "name": "wub", "email": "wub@google.com", "time": "Mon Mar 18 08:59:04 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 18 09:00:23 2024 -0700" }, "message": "Deprecate --gfe2_reloadable_flag_quic_bbr2_fix_spurious_loss_bytes_counting.\n\nPiperOrigin-RevId: 616843446\n" }, { "commit": "30534678683f4172406c1bc98e69729cd8d0e4ff", "tree": "31066a06181a5f80d2e069b2a9761bb1ed143b1d", "parents": [ "9f8738892edd83219d2f83fdd73c7c14d5dbb80d" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Mon Mar 18 05:56:25 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 18 05:58:12 2024 -0700" }, "message": "Update ParseQuicTag to only use hex decoding if valid\n\nParseQuicTag was using absl::HexStringToBytes to unconditionally decode strings when they were 8 bytes long, but for strings with non-hexidecimal characters the return value of calling absl::HexStringToBytes is unspecified. This CL updates ParseQuicTag to only use the output of absl::HexStringToBytes when the call returns success.\n\nThis also moves the code away from using the deprecated version of absl::HexStringToBytes, allowing the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 616801281\n" }, { "commit": "9f8738892edd83219d2f83fdd73c7c14d5dbb80d", "tree": "d168ff84b60d4b38b0ab6010e0397ebf307af9eb", "parents": [ "282e6ab3adfb1698a880a2e230938b8e9cfe4cce" ], "author": { "name": "asedeno", "email": "asedeno@google.com", "time": "Sat Mar 16 22:45:38 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Mar 16 22:46:40 2024 -0700" }, "message": "Add missing includes to metadata_decoder.h and metadata_decoder.cc\n\nPiperOrigin-RevId: 616526575\n" }, { "commit": "282e6ab3adfb1698a880a2e230938b8e9cfe4cce", "tree": "4ff29c209ec746709963b53cc8fc6d39cc01bf77", "parents": [ "76e947cce6516952769c6e2a65bbc91ca9e41c93" ], "author": { "name": "bnc", "email": "bnc@google.com", "time": "Fri Mar 15 14:09:03 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 15 14:10:13 2024 -0700" }, "message": "Only export flags with `export_to_quiche` set to true publicly.\n\nPiperOrigin-RevId: 616238523\n" }, { "commit": "76e947cce6516952769c6e2a65bbc91ca9e41c93", "tree": "52c1ef35f5931a0e1b5c3313d62dfd886a0d5790", "parents": [ "ce1f07e8d39fd3594a96ffed65204cc51fd57e38" ], "author": { "name": "danzh", "email": "danzh@google.com", "time": "Fri Mar 15 10:52:32 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 15 10:53:44 2024 -0700" }, "message": "Add FLAG_COUNT for flag --gfe2_reloadable_flag_quic_no_write_control_frame_upon_connection_close.\n\nPiperOrigin-RevId: 616181290\n" }, { "commit": "ce1f07e8d39fd3594a96ffed65204cc51fd57e38", "tree": "67f8e718c590f73fd153418cc24eb5055eaa176b", "parents": [ "70bc4dfde98dd4feb7de4ce4b68b220e8cdfee9b" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Wed Mar 13 18:23:24 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 13 18:24:14 2024 -0700" }, "message": "Incrementally process HTTP/3 METADATA frames instead of buffering the full payload.\n\nPiperOrigin-RevId: 615608615\n" }, { "commit": "70bc4dfde98dd4feb7de4ce4b68b220e8cdfee9b", "tree": "3c15364c04855284744ebcb70522bc6b50cd14e1", "parents": [ "aecd0d636f9d8234f080422cc07d9a34c7175e43" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Wed Mar 13 15:59:51 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 13 16:01:01 2024 -0700" }, "message": "Return false from QuicSpdyStream::OnMetadataFrameEnd if the\nstream has been reset.\n\nPiperOrigin-RevId: 615572236\n" }, { "commit": "aecd0d636f9d8234f080422cc07d9a34c7175e43", "tree": "073d5988b82288e859b9169aab3dcad5927e8892", "parents": [ "bb62bf31cf5678a28b6e1b4636f557cdbfadc378" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Wed Mar 13 07:59:15 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 13 08:00:28 2024 -0700" }, "message": "Update MOQT to draft-03 wire image. Does not add ANNOUNCE_CANCEL because it does not have a code point.\n\nNot in production\n\nPiperOrigin-RevId: 615417995\n" }, { "commit": "bb62bf31cf5678a28b6e1b4636f557cdbfadc378", "tree": "0c9103dd8c3bdeac7f08a430a17655b61b913cb2", "parents": [ "cc9724b902e0e3392434ea3f985a50c27d99fed4" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Wed Mar 13 07:55:28 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 13 07:56:29 2024 -0700" }, "message": "Rename kGenericError to kInternalError.\n\nnon-wire-image change to MoQT for draft-03\n\nNot in production.\n\nPiperOrigin-RevId: 615416989\n" }, { "commit": "cc9724b902e0e3392434ea3f985a50c27d99fed4", "tree": "a3846ae409cd19f5d24b9c20154aae1d552b43fa", "parents": [ "022a94e4024ea413fb86cd7bc177f4ce50721e1c" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Wed Mar 13 06:29:45 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 13 06:30:49 2024 -0700" }, "message": "Fix standalone QUICHE build.\n\nThis removes the use of ABSL_DIE_IF_NULL. I have thought more carefully about it, and realized that we probably shouldn\u0027t be using it (or anything in absl/log) since the we already swap out Abseil logging for embedder-specific logging on some platforms, and die_if_null would always use Abseil logging.\n\nAlso add a missing Bazel dep, and remove some unused includes that the linter complains about.\n\nPiperOrigin-RevId: 615393182\n" }, { "commit": "022a94e4024ea413fb86cd7bc177f4ce50721e1c", "tree": "6299ed8749bfa35633b8731878b0ddf2ea52a6d1", "parents": [ "8b44376ac8cabe2fc980041358d2c5a2b5c597e4" ], "author": { "name": "wub", "email": "wub@google.com", "time": "Tue Mar 12 18:44:31 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 18:45:43 2024 -0700" }, "message": "Add lifetime tracking debug utility to QUICHE.\n\nPiperOrigin-RevId: 615244192\n" }, { "commit": "8b44376ac8cabe2fc980041358d2c5a2b5c597e4", "tree": "fdd12b782edcc560ff55729632d6807c220232af", "parents": [ "c9a14477aae0774a41579581a8bf98ffd271e05c" ], "author": { "name": "danzh", "email": "danzh@google.com", "time": "Tue Mar 12 17:14:24 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 17:15:33 2024 -0700" }, "message": "Change ClientProofSource::GetCertAndKey() to return shared_ptr\u003cCertAndKey\u003e instead of a raw pointer of CertAndKey.\n\nThis is to future prevent the caller from accessing the return value after the proof source implementation has destroyed it.\n\nInterface change only.\n\nPiperOrigin-RevId: 615222541\n" }, { "commit": "c9a14477aae0774a41579581a8bf98ffd271e05c", "tree": "82620e71ec596b0e5b5bbbcf626629a9954fe745", "parents": [ "bbc1207e179b9405e94c279dd8b7be0aad684f6b" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Tue Mar 12 16:12:00 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 16:12:52 2024 -0700" }, "message": "Adds a way to notify the `Http2Adapter` when the underlying codec decides not to send a frame.\n\nThis will help prevent a potential leak of `SelfDeletingMetadataSource` objects.\n\nProtected by not protected; does not affect the GFE binary.\n\nPiperOrigin-RevId: 615204887\n" }, { "commit": "bbc1207e179b9405e94c279dd8b7be0aad684f6b", "tree": "7fa9ee5ef3a5ffa8e3d0961c62f2358e46ef7707", "parents": [ "d831c72dd3b405f6243ecd3ff5d7fb0fc38a8935" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Tue Mar 12 15:39:19 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 15:40:40 2024 -0700" }, "message": "SUBSCRIBE_ERROR after OBJECT is a protocol violation.\n\nNot a wire change, but part of the draft-03 update.\n\nNot in production.\n\nPiperOrigin-RevId: 615195367\n" }, { "commit": "d831c72dd3b405f6243ecd3ff5d7fb0fc38a8935", "tree": "0116b2c8deecfeaa7787491192f97d4f2be7d193", "parents": [ "b171496d2a71e19c9c70044b65002aeb3329789f" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Tue Mar 12 12:39:13 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 12:40:09 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in quic/core/crypto tests\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL is not expected to introduce any changes in functionality other than now verifying that the call to absl::HexStringToBytes was successful.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 615136921\n" }, { "commit": "b171496d2a71e19c9c70044b65002aeb3329789f", "tree": "6d0668cd7279701e5df514a7a22ee95c62af747d", "parents": [ "79520e395340034cb6f678a93cdfb4e1deb65f0c" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Tue Mar 12 08:31:03 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 12 08:32:06 2024 -0700" }, "message": "Fix MoqtSessionTests with unitialized peer_role_.\n\nThis should never happen except in tests, because the SETUP always arrives to set the role. But this CL adds a default value, just in case future changes disrupt the checks around SETUP arriving first and containing Role.\n\nAlso fixed an old initialized value problem where the varint for the Role parameter isn\u0027t correctly formatted, but we don\u0027t exit.\n\nPiperOrigin-RevId: 615050498\n" }, { "commit": "79520e395340034cb6f678a93cdfb4e1deb65f0c", "tree": "a4f873f7c27eaec6a0d880d9b30cddfaf47e30ff", "parents": [ "66966d9d07a8c7a00ed53a0ec87635e4552bbd5d" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Mon Mar 11 18:08:13 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 18:09:06 2024 -0700" }, "message": "Enforce rules about ROLE parameter.\n\npart of draft-03 update, but no wire image change.\n\nNot in production.\n\nPiperOrigin-RevId: 614858830\n" }, { "commit": "66966d9d07a8c7a00ed53a0ec87635e4552bbd5d", "tree": "5a60f7be804f03050115ff327bd817c06d1faa8f", "parents": [ "e8a887ba6e714527543e00fec419581cc40f42d8" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Mon Mar 11 15:21:20 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 15:22:57 2024 -0700" }, "message": "Make MoqtForwardingPreference a track property.\n\nPart of draft-03 update, but not part of the wire image.\n\nNot in production.\n\nPiperOrigin-RevId: 614812113\n" }, { "commit": "e8a887ba6e714527543e00fec419581cc40f42d8", "tree": "d777cb581a639be24aca24d5c8a2d44d1b0319db", "parents": [ "465d154154ff184acf343c5aaa0e011603cf2da5" ], "author": { "name": "elburrito", "email": "elburrito@google.com", "time": "Mon Mar 11 13:06:48 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 13:07:57 2024 -0700" }, "message": "BlindSignAuth: Refactoring to support future Android BlindSignMessageInterface impl.\n\n- Rename BlindSignHttpInterface to BlindSignMessageInterface\n- Change BSA::GetTokens oauth_token parameter to std::optional\u003cstd::string\u003e, since Android BSA callers will not have an OAuth token to pass in\n- Change BlindSignMessageInterface::DoRequest authorization_header to std::optional\u003cstd::string\u003e\n- Stop setting oauth_token field in AuthAndSignRequest (field is unused for IP Protection and will be deprecated)\n\nPiperOrigin-RevId: 614767846\n" }, { "commit": "465d154154ff184acf343c5aaa0e011603cf2da5", "tree": "9e59164f130f9435039231052cbb1a4447e80eec", "parents": [ "cfc83c387a5680afddb01c5aa00f6381fdc117b7" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Mon Mar 11 10:54:06 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 10:55:19 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in quic/core/http tests\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL is not expected to introduce any changes in functionality other than now verifying that the call to absl::HexStringToBytes was successful.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 614722292\n" }, { "commit": "cfc83c387a5680afddb01c5aa00f6381fdc117b7", "tree": "2516e75daf931fa63f6549e57a25894ad7e36044", "parents": [ "2337058d22637344f6b3e772426420dcef9e543d" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Mon Mar 11 10:38:37 2024 -0700" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 11 10:40:10 2024 -0700" }, "message": "Replace deprecated version of absl::HexStringToBytes in quic/core/qpack tests\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in std::string. This CL is not expected to introduce any changes in functionality other than now verifying that the call to absl::HexStringToBytes was successful.\n\nThis allows the Chrome build of QUICHE to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 614716628\n" }, { "commit": "2337058d22637344f6b3e772426420dcef9e543d", "tree": "edd0132d0085a7b433272392554a8645404b0f62", "parents": [ "75b46d3bc336362073dcbb49ff6087b9e5bbb91c" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Fri Mar 08 15:06:11 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 08 15:07:47 2024 -0800" }, "message": "Retry Poll when system clock is faster than QuicClock\n\n`poll` and `WSAPoll` use the system clock, which may run faster (skew from) the\n`clock_` used in the event loop. In this case, no error is reported but the\nevent loop should retry until the timeout is met.\n\nThis is more prevalent on Windows (~1% of my tests) and especially in a VM\nlike Lexan (~33% of tests).\n\nPiperOrigin-RevId: 614056093\n" }, { "commit": "75b46d3bc336362073dcbb49ff6087b9e5bbb91c", "tree": "6680240ad7f7e1d29de0102579254033dc20f305", "parents": [ "aed3464080ff6f40b3381412aaef9035c0394a9b" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Fri Mar 08 13:47:39 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 08 13:48:33 2024 -0800" }, "message": "New code path does not initialize subscribe_id.\n\nNot in production.\n\nPiperOrigin-RevId: 614034075\n" }, { "commit": "aed3464080ff6f40b3381412aaef9035c0394a9b", "tree": "8006b4776c76a4e11f5ac0924016663d9b9ea44e", "parents": [ "82ff95e24f4ac3c6142fcbabdead86b666b6f4e2" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Fri Mar 08 07:41:06 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 08 07:42:35 2024 -0800" }, "message": "Send and handle MoQT datagrams when required.\n\ndraft-03 requires objects with this preference to be sent via datagram, not on a stream.\n\nNot in production.\n\nPiperOrigin-RevId: 613930667\n" }, { "commit": "82ff95e24f4ac3c6142fcbabdead86b666b6f4e2", "tree": "d3338ed289a425a7e864c205230bc99cd682eaa7", "parents": [ "8d236ed5a9f054278cf3a4096ae561775372b6db" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Wed Mar 06 16:04:50 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 16:05:58 2024 -0800" }, "message": "Disables Cookie header field crumbling in OgHttp2Session by default.\n\nAddresses https://github.com/envoyproxy/envoy/issues/32611.\n\nPiperOrigin-RevId: 613371306\n" }, { "commit": "8d236ed5a9f054278cf3a4096ae561775372b6db", "tree": "b71fb731a32fb6eb971c5f791c81c73a9556f12d", "parents": [ "19593d7f501548adc5420296b25c92a6b48b5c68" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Wed Mar 06 15:07:45 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 15:08:45 2024 -0800" }, "message": "No public description\n\nPiperOrigin-RevId: 613354729\n" }, { "commit": "19593d7f501548adc5420296b25c92a6b48b5c68", "tree": "6c19b8e110774365e1a96f80d404a02b2c1bbdce", "parents": [ "c186a5131074f152e4d6dc2838929b161903caae" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Wed Mar 06 14:59:39 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 15:00:52 2024 -0800" }, "message": "No public description\n\nPiperOrigin-RevId: 613351943\n" }, { "commit": "c186a5131074f152e4d6dc2838929b161903caae", "tree": "71846f57168da1194a4c23485742e8bce7ae7661", "parents": [ "f373496dcb10255c35acaa96a0ba64904f10f926" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Wed Mar 06 13:54:28 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 13:55:41 2024 -0800" }, "message": "Adds the ability to skip `Cookie` crumbling in `HpackEncoder`.\n\nThis is preparation for fixing the issue described in https://github.com/envoyproxy/envoy/issues/32611.\n\nProtected by new code path, not yet enabled in the GFE binary.\n\nPiperOrigin-RevId: 613330788\n" }, { "commit": "f373496dcb10255c35acaa96a0ba64904f10f926", "tree": "093c9bb6b345bd69befc99a3cad8bf0264590c3d", "parents": [ "b36587781c9532e3b0715ea522cca57dec561854" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Wed Mar 06 10:07:26 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 10:08:11 2024 -0800" }, "message": "Clean up some unused QUICHE flag imports in third_party/http2.\n\nPiperOrigin-RevId: 613256758\n" }, { "commit": "b36587781c9532e3b0715ea522cca57dec561854", "tree": "a7a96af81b7dc5a13933d30411f8fc28ce9c0d08", "parents": [ "6f0b1d204da73155e21c683650dbebe05a36d781" ], "author": { "name": "bnc", "email": "bnc@google.com", "time": "Wed Mar 06 08:01:30 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 08:02:29 2024 -0800" }, "message": "Remove unused `module` argument from flag implementation.\n\nNOT generated via copybara\n\nPiperOrigin-RevId: 613216980\n" }, { "commit": "6f0b1d204da73155e21c683650dbebe05a36d781", "tree": "d61fae5a69be4986354468697ff716a1910ef65d", "parents": [ "55f76a361d2af3c231097c7000f92328f4ac5b6d" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Tue Mar 05 13:51:19 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 05 13:52:49 2024 -0800" }, "message": "Uses absl::StrSplit in DecomposeRepresentations rather than a hand-rolled while loop.\n\nProtected by refactoring, no functional change expected; not protected.\n\nPiperOrigin-RevId: 612957831\n" }, { "commit": "55f76a361d2af3c231097c7000f92328f4ac5b6d", "tree": "f1dbc59e2ae29957d947e75876330667d719b3be", "parents": [ "bbec3560154a5a92a101fe353e80951a3732a12e" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Tue Mar 05 12:38:30 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 05 12:40:04 2024 -0800" }, "message": "Refactoring to simplify future changes.\n\n* extracts PassthroughHeadersHandler::Reset()\n* sets the frame_contains_fin_ bit in OnHeaders()\n\nPiperOrigin-RevId: 612934770\n" }, { "commit": "bbec3560154a5a92a101fe353e80951a3732a12e", "tree": "0ded49ddb399c716eaec96c33a7a871b546dc172", "parents": [ "770a8a36f6047902a6a5acf8bfa785ba60674c06" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Tue Mar 05 08:09:09 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 05 08:10:16 2024 -0800" }, "message": "Introduce MoQT demo ingestion server that writes incoming streams into a directory.\n\nIt is possible to test this server against the demo chat client by running a command among the lines of `moqt_ingestion_server /tmp/outdir --alsologtostderr --allow_invalid_track_namespaces --tracks\u003d`.\n\nPiperOrigin-RevId: 612845930\n" }, { "commit": "770a8a36f6047902a6a5acf8bfa785ba60674c06", "tree": "1bfd059f4328446145aef72df4c4ad5548d5d840", "parents": [ "1bf8322a2aad50c5fcfef3aad537d1f2a9377154" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Mon Mar 04 14:07:00 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 14:07:55 2024 -0800" }, "message": "Switch moqt_messages.h types to use std::string instead of absl::string_view\n\nThe immediate goal here is to fix a use-after-free caused by the fact that MoqtSession::active_subscriptions_ contains a bunch of MoqtSubscription objects that have views to potentially deleted track names (`blaze test -c dbg --config\u003dasan //third_party/quic/moqt/...` will reproduce those).\n\nThe long-term goal is to make moqt_messages.h types safer to use, as they\u0027re really prone to UAFs right now.\n\nPiperOrigin-RevId: 612578165\n" }, { "commit": "1bf8322a2aad50c5fcfef3aad537d1f2a9377154", "tree": "4b59f7b789ab297bec7bc19244451871c1b73ec8", "parents": [ "e4df954af4ec3f32e4d6b396315ee895d9b43788" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Mon Mar 04 13:37:40 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 13:39:24 2024 -0800" }, "message": "Replace deprecated version of absl::HexStringToBytes\n\nReplaces the deprecated version of absl::HexStringToBytes that returns std::string with the version that returns bool and populates a passed in string with the bytes. This CL is not expected to introduce any changes in functionality other than now verifying that absl::HexStringToBytes works successfully.\n\nThis allows the Chrome build of the library to build without the `-Wno-deprecated-declarations` clang flag.\n\nPiperOrigin-RevId: 612568046\n" }, { "commit": "e4df954af4ec3f32e4d6b396315ee895d9b43788", "tree": "6779e6a5eb1b59ad761b57034d90efa02fe2d279", "parents": [ "feb096a5bd7d2ec9b7ddc9da81c99afc5c3eac60" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Mon Mar 04 11:53:17 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 11:54:06 2024 -0800" }, "message": "Actually set MoqtSession::control_stream_ on the server side.\n\nPiperOrigin-RevId: 612530962\n" }, { "commit": "feb096a5bd7d2ec9b7ddc9da81c99afc5c3eac60", "tree": "9654366edbdf8efb84d236572325d809342f0ca7", "parents": [ "f357216793272a9fa5462539d02c809c06df0406" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Mon Mar 04 11:34:01 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 11:35:20 2024 -0800" }, "message": "Redo the way callbacks are integrated into MoQT server.\n\nCurrently there is a bit of a chicken-and-egg problem with getting a session pointer into callbacks since the session needs to know the callbacks in advance; solve this by letting the callbacks be changed later on.\n\nPiperOrigin-RevId: 612524151\n" }, { "commit": "f357216793272a9fa5462539d02c809c06df0406", "tree": "ba42f01135a8d55aff0fd05aa7365c5c623af90b", "parents": [ "3373df94b3713d4e3ef69ee54ba6e7b6aaaebcc0" ], "author": { "name": "wangsteve", "email": "wangsteve@google.com", "time": "Mon Mar 04 08:26:00 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 04 08:26:55 2024 -0800" }, "message": "Move quiche_feature_flags to actual file in Piper.\n\nThis breaks the dependency on all the genrule implementation details.\n\nI\u0027ve added a new test that will fail whenever a new QUICHE flag is\nadded, and prompt the CL author to update this file.\n\nThe update command as provided in the METADATA check is:\n```\n$ blaze build gfe/gfe2:quiche_feature_flags_list \u0026\u0026 cp blaze-genfiles/gfe/gfe2/quiche_feature_flags_list.h third_party/quiche/common/\n```\n\nI\u0027ve confirmed that this leads to a significant reduction in the size of the envoy build dependency graph:\n\n```\n$ wc -l deps_envoy*\n # cl/\n 25581 deps_envoy_2024-02.txt\n 38946 deps_envoy_less-quiche.txt\n 25337 deps_envoy_more-quiche.txt\n```\n\nAs such, this eliminates around 98% of the additional transitive\ndependencies introduced by cl/605634099.\n\nPiperOrigin-RevId: 612458693\n" }, { "commit": "3373df94b3713d4e3ef69ee54ba6e7b6aaaebcc0", "tree": "1b04ccdc998178c872c532a36d9c7bba1386bce7", "parents": [ "37c2bbe3ad4ae22543b69f4beaf5b7d9bf513dcb" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Thu Feb 29 13:38:38 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 13:39:21 2024 -0800" }, "message": "Add work-around for unused private fields in quic/masque\n\nThis will allow us to remove `-Wno-unused-private-field` [1] from the Chrome build of Quiche.\n\n[1] https://source.chromium.org/chromium/chromium/src/+/main:net/third_party/quiche/BUILD.gn;l\u003d38;drc\u003dc0a300abd30958ef38c80bf3826a2f7a644f24da\n\nPiperOrigin-RevId: 611580795\n" }, { "commit": "37c2bbe3ad4ae22543b69f4beaf5b7d9bf513dcb", "tree": "826cac220753cbcf2b9725831345b50fe55f4d07", "parents": [ "c6a366bc5ee56f32d26857a17e233568cdd9ae49" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Thu Feb 29 11:38:12 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 11:40:08 2024 -0800" }, "message": "Add a new MetadataVisitor class to QuicSpdyStream.\nIf registered, an instance of this new class will receive decoded HTTP/3\nMETADATA frames. If not, registered, HTTP/3 METADATA frames will be delivered\nas unknown HTTP/3 frames, which is current behavior.\n\nThis is motivated by implements HTTP/3 METADATA handling in Envoy. Without\nthis new visitor, we need to hook into the EnvoyQuicSession\u0027s OnUnknownFrame\nmethods. But this is really annoying because we receive frames on the Stream,\nbounce them (at the QUICHE layer) over the the Session which parses them into\nHeaders and then need to bounce them back over to the Stream. This is awkward.\nBy using this new Visitor, the Stream itself can handle METADATA.\n\nProtected by FLAGS_quic_reloadable_flag_quic_enable_http3_metadata_decoding.\n\nPiperOrigin-RevId: 611542297\n" }, { "commit": "c6a366bc5ee56f32d26857a17e233568cdd9ae49", "tree": "365d278a9f9c62414c762c517e721222acecc467", "parents": [ "9e42729500679d45d1ede11fb504ab8e1e6584aa" ], "author": { "name": "wangsteve", "email": "wangsteve@google.com", "time": "Thu Feb 29 08:23:22 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 08:24:16 2024 -0800" }, "message": "No public description\n\nPiperOrigin-RevId: 611479163\n" }, { "commit": "9e42729500679d45d1ede11fb504ab8e1e6584aa", "tree": "06730a0e242fcd722a353a1479750f24e1d9a6a2", "parents": [ "02047e04d076d36226e92847a94acf33544f10d6" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Thu Feb 29 07:56:44 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 07:57:34 2024 -0800" }, "message": "Refactors error handling in PassthroughHeadersHandler.\n\nProtected by refactoring, no functional change expected.\n\nPiperOrigin-RevId: 611471355\n" }, { "commit": "02047e04d076d36226e92847a94acf33544f10d6", "tree": "f1d8b675a705f941541a0e46575ceb1054b878f4", "parents": [ "b0c5f28fbc3e3b13190f9a8cfb228a086eeca9ca" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Tue Feb 27 19:39:15 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 27 19:40:05 2024 -0800" }, "message": "Deprecate --gfe2_restart_flag_quic_allow_control_frames_while_procesing.\n\nPiperOrigin-RevId: 610952734\n" }, { "commit": "b0c5f28fbc3e3b13190f9a8cfb228a086eeca9ca", "tree": "82710f5d5deb2cc2e380d4fbb0cd14f6920a2fd6", "parents": [ "6fed96483ed2f0fd9567211f50df8beef43ac140" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Tue Feb 27 12:26:10 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 27 12:28:02 2024 -0800" }, "message": "Remove unused locals and trivial assignments from StructuredHeaderParser\n\nPiperOrigin-RevId: 610836631\n" }, { "commit": "6fed96483ed2f0fd9567211f50df8beef43ac140", "tree": "4007731f8af9b5506f17e5f03b8b9008581bd28d", "parents": [ "901b1d3b51bd0de5e8b48253a9136a7d40b41aad" ], "author": { "name": "awillia", "email": "awillia@google.com", "time": "Mon Feb 26 14:45:31 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 26 14:46:36 2024 -0800" }, "message": "Fix issues with Hpack EXPECT_DEATH test on Android + ChromeOS\n\nCertain build configurations of Chrome discard messages streamed to CHECK, so using EXPECT_DEATH with a regex won\u0027t always work. To account for this, this CL adds a new `EXPECT_QUICHE_DEATH` macro similar to the existing `EXPECT_QUCHE_DEBUG_DEATH` macro that we will override the implementation of in Chrome to use `EXPECT_CHECK_DEATH`.\n\nAlso, adds my name to allowed_authors in copy.bara.sky so this will be associated with me on Github. :)\n\nPiperOrigin-RevId: 610533493\n" }, { "commit": "901b1d3b51bd0de5e8b48253a9136a7d40b41aad", "tree": "894249b38e3faa41d7dd6367befbbffe515bb908", "parents": [ "a4c007178d479e7cc301a2bae284f41c87039448" ], "author": { "name": "wub", "email": "wub@google.com", "time": "Mon Feb 26 13:35:21 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 26 13:36:33 2024 -0800" }, "message": "Skip a QUIC_BUG in QuicConnection::SendAllPendingAcks when connection is closed.\n\nPiperOrigin-RevId: 610511462\n" }, { "commit": "a4c007178d479e7cc301a2bae284f41c87039448", "tree": "b7018e12f0de5adddae9dda005e0da9254b8e727", "parents": [ "bfee54b267593daba534c3f1a73907b5517ac591" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Mon Feb 26 13:14:22 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 26 13:15:13 2024 -0800" }, "message": "Add [[maybe_unused]]\n\nQUICHE_LOG_IF is removed in some build.\n\nPiperOrigin-RevId: 610504919\n" }, { "commit": "bfee54b267593daba534c3f1a73907b5517ac591", "tree": "9cda184385ed6e7b1a18038c8857d0fa424831c2", "parents": [ "47b42132840c9c174d11df04ed4110d74e944533" ], "author": { "name": "diannahu", "email": "diannahu@google.com", "time": "Mon Feb 26 10:17:20 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 26 10:19:00 2024 -0800" }, "message": "Fix a potential Http2WriteQueue overflow scenario.\n\nThis CL addresses the overflow scenario described in cl/608648082 by adding two\nbytes of HPACK per-header overhead when estimating the serialized size in bytes\nof a HEADERS frame. In particular, the length of a header name will be expected\nto fit within 2 bytes (vs. 1 byte before), and the length of a header value\nwill be expected to fit within 3 bytes (vs. 2 bytes before).\n\nProtected by FLAGS_gfe2_reloadable_flag_http2_add_hpack_overhead_bytes.\n\nPiperOrigin-RevId: 610447560\n" }, { "commit": "47b42132840c9c174d11df04ed4110d74e944533", "tree": "29f237f391dc39416b3ae4cd6e080e80a8af65c0", "parents": [ "01a4e4eaaaf6ae195c126b2b3aa19168e4c7440f" ], "author": { "name": "danzh", "email": "danzh@google.com", "time": "Fri Feb 23 15:47:11 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 23 15:48:06 2024 -0800" }, "message": "Change ProcessAdditionalTransportParameters() to return a bool to indicate whether the handshake should continue or immediately fail.\n\nProcessAdditionalTransportParameters() never fail the handshake today. And all the existing implementations in production won\u0027t return false with this change.\n\nPiperOrigin-RevId: 609857934\n" }, { "commit": "01a4e4eaaaf6ae195c126b2b3aa19168e4c7440f", "tree": "21a258261de0b3bf9551870acfa0969c25c383ef", "parents": [ "8d2d31dd4fcef129919d3399c126c3349497c60f" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Fri Feb 23 13:20:43 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 23 13:22:18 2024 -0800" }, "message": "Add GFE_CODE_COUNT for ALPS use old codepoint\n\nTo better evaluate the percentage of how many clients are still using the old codepoint, we need to keep tracking the GFE count and stop supporting the\nold codepoint once the usage is low enough.\n\nPiperOrigin-RevId: 609819677\n" }, { "commit": "8d2d31dd4fcef129919d3399c126c3349497c60f", "tree": "ef10fc5218b096aefef1b3641d717127d2e8bc05", "parents": [ "500b59c422cc0abd353569653c1c66923cac8534" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Wed Feb 21 15:47:24 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 21 15:48:32 2024 -0800" }, "message": "Update MoQT chat client to use InteractiveCli when there is no output file.\n\nNot in production.\n\nPiperOrigin-RevId: 609148698\n" }, { "commit": "500b59c422cc0abd353569653c1c66923cac8534", "tree": "e6d56967ce419b19673836b0a796f2f63757f79c", "parents": [ "e3fcaaf983d98759e3c898f32e0a5db144cb6b0d" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Tue Feb 20 15:26:07 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 20 15:27:12 2024 -0800" }, "message": "Add logic to handle ANNOUNCE messages.\n\nAlso let the outgoing ANNOUNCE callbacks access the error code.\n\nPiperOrigin-RevId: 608760663\n" }, { "commit": "e3fcaaf983d98759e3c898f32e0a5db144cb6b0d", "tree": "642ba39e90da3697a6d282eca29ec55c79984b93", "parents": [ "599a830aa3673316a858d9a940fca6cbe6e20066" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Tue Feb 20 15:08:02 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 20 15:09:04 2024 -0800" }, "message": "Add InteractiveCli tool class, for use in MoQT chat client.\n\nPiperOrigin-RevId: 608754572\n" }, { "commit": "599a830aa3673316a858d9a940fca6cbe6e20066", "tree": "dd5f4c8e263308b8255a4b24f43c585f577a1ac5", "parents": [ "62c36bcfbc07a40aa8e593dd41e532d08adab7cb" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Tue Feb 20 13:40:03 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 20 13:40:58 2024 -0800" }, "message": "Improve UI by streaming MoQT chat messages to a file.\n\nIf output_file is an argument, it allows a somewhat friendlier interface where the tail command in a different window allows view of all the messages, while not interfering with typing in the main CLI window.\n\nI will integrate the interactive tool for a third mode.\n\nPiperOrigin-RevId: 608722885\n" }, { "commit": "62c36bcfbc07a40aa8e593dd41e532d08adab7cb", "tree": "76f7af09aeb0ef37dcb496e70d05efb510a5dc05", "parents": [ "3cab5621532078c07465d3b8ebd5472584e01464" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Tue Feb 20 11:48:44 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 20 11:50:42 2024 -0800" }, "message": "Always buffer control messages in MoQT.\n\nRight now, if we run out of flow control and buffer too many control messages, it will result in a fatal error.\n\nPiperOrigin-RevId: 608684846\n" }, { "commit": "3cab5621532078c07465d3b8ebd5472584e01464", "tree": "c9391a59dddffbf5660f901ec28028ab564a3571", "parents": [ "42dab6be059fbe2a3d98367e1d5ad19d887156d3" ], "author": { "name": "wub", "email": "wub@google.com", "time": "Tue Feb 20 08:30:32 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 20 08:31:40 2024 -0800" }, "message": "In QUIC client, use normalized server address to determine whether a packet is from unknown server.\n\nThe current code can fail if direct_peer_address_ is a dual stacked address and\nlast_received_packet_info_.source_address is a normal v4 address. This has been observed in GFE custom prober test.\n\nProtected by FLAGS_quic_test_peer_addr_change_after_normalize.\n\nPiperOrigin-RevId: 608614629\n" }, { "commit": "42dab6be059fbe2a3d98367e1d5ad19d887156d3", "tree": "eb57854ee05b1380dc718e28bd0fba6d02568ed8", "parents": [ "eb58cf09f4abfbd8388934464a85803c9cbb1a87" ], "author": { "name": "vasilvv", "email": "vasilvv@google.com", "time": "Sun Feb 18 08:47:27 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sun Feb 18 08:48:13 2024 -0800" }, "message": "Refactor the framer and some of the publishing pathway for MOQT.\n\nChanges to framer:\n- Use wire_serialization.h API where possible.\n- Remove unused SerializeObjectPayload method.\n- Change SerializeObject into SerializeObjectHeader; we never want to copy the object payload here, since it almost always should be passed directly into the underlying stream using Writev.\n- Simplify some code paths (in case of SerializeObjectHeader at cost of repetition) in order to make them easier to read and modify going forward.\n\nChanges to PublishObject:\n- Always require full payload; we didn\u0027t really provide a way to write the remaining payload, and that would require a different API we could add later.\n- Check that end_of_stream is always set for Object/Datagram.\n\nPiperOrigin-RevId: 608134589\n" }, { "commit": "eb58cf09f4abfbd8388934464a85803c9cbb1a87", "tree": "e0c585121bba068ea8c839036d24d0cf0dfa71a4", "parents": [ "a3634e542bb76485cc0b1394cf12a05d8cebb038" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Sat Feb 17 14:05:04 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 17 14:06:01 2024 -0800" }, "message": "Object handling in MoQT chat client.\n\nThreaded model was fatally flawed; now it works correctly.\n\nPiperOrigin-RevId: 608007963\n" }, { "commit": "a3634e542bb76485cc0b1394cf12a05d8cebb038", "tree": "a24b811e4abd848872154311c79d6376f4375a77", "parents": [ "6a5ee44813ee3ccd0a193fecf39685a497724f7b" ], "author": { "name": "wub", "email": "wub@google.com", "time": "Fri Feb 16 18:37:04 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 16 18:38:09 2024 -0800" }, "message": "In GFE simple clients, change the socket fd configurators to run before bind(), because some socket options(e.g. Enable AnyIp and DualStack) must be set before it.\n\nPiperOrigin-RevId: 607856194\n" }, { "commit": "6a5ee44813ee3ccd0a193fecf39685a497724f7b", "tree": "dbba636f0f54c12fcb7e4954427c91793da28f9f", "parents": [ "693a4890dc4bf7930aa58af7d38ecd690a9b4967" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Fri Feb 16 16:32:55 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 16 16:33:46 2024 -0800" }, "message": "Removes the `trailers_require_end_data` option from oghttp2.\n\nThis option is not set, and makes the code more confusing.\n\nMy hope is that the simplification helps us debug https://github.com/envoyproxy/envoy/issues/32371.\n\nPiperOrigin-RevId: 607833789\n" }, { "commit": "693a4890dc4bf7930aa58af7d38ecd690a9b4967", "tree": "bd8b286bc73da1faad6693fd6b79e251ffcfa184", "parents": [ "9e875938052443c7f51b25012093be59e20598ac" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Fri Feb 16 11:27:49 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 16 11:28:39 2024 -0800" }, "message": "Add find and clear methods to structured-header Dictionary type\n\n- Precedent in [`std::map::find`](https://en.cppreference.com/w/cpp/container/map/find)\n- Reimplement other indexing methods using `find`\n- Explicitly default move constructor and move-assign operator\n\nPiperOrigin-RevId: 607749355\n" }, { "commit": "9e875938052443c7f51b25012093be59e20598ac", "tree": "8324aed657f53bd45fde01b24ee71d11f4b9f9bb", "parents": [ "2958de853a8c3999f7d73242aa1d9cd9be9458c2" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Thu Feb 15 14:25:56 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 15 14:28:26 2024 -0800" }, "message": "Fixes handling of DATA frame padding in OgHttp2Session.\n\nMishandling of padding can lead to a flow control leak, potentially causing the kind of connection stalls observed in https://github.com/envoyproxy/envoy/issues/32401.\n\nThanks to eagle-eyed https://github.com/diannahu for the root cause!\n\nPiperOrigin-RevId: 607455607\n" }, { "commit": "2958de853a8c3999f7d73242aa1d9cd9be9458c2", "tree": "6e15f35e61c7f7c19187692114c08c9f83402a47", "parents": [ "0d58e5aeedf6ca33e58ab4a01887f5d028b5c5eb" ], "author": { "name": "birenroy", "email": "birenroy@google.com", "time": "Thu Feb 15 12:35:10 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 15 12:36:05 2024 -0800" }, "message": "Adds a test case demonstrating that OgHttp2Adapter does not consider DATA frame padding as \"consumed\".\n\nIn the test, this shows up as a lack of WINDOW_UPDATE frames in the adapter\u0027s response. This bug could be implicated in https://github.com/envoyproxy/envoy/issues/32401.\n\nPiperOrigin-RevId: 607420483\n" }, { "commit": "0d58e5aeedf6ca33e58ab4a01887f5d028b5c5eb", "tree": "dc47efdbd3418538ae06f090dbfd3d864c9b12b1", "parents": [ "efc574e1125251bc1c3195c0c183c843b4c0a1df" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Wed Feb 14 16:47:07 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 14 16:48:11 2024 -0800" }, "message": "Fix issues when building more Quiche tests for iOS and Windows\n\nAddresses additional build and test failures for tests run as part of net_unittests in Chromium for iOS and Windows.\n\nCalling WSAStartup in the connect tests avoids the following error in multiple tests on the win-rel bot:\n```\nERROR:quic_name_lookup.cc(36)] Failed to look up localhost: Either the application has not called WSAStartup, or WSAStartup failed.\n```\n\nUsing QUICHE_NO_EXPORT avoids errors like the following on win_chromium_compile_dbg_ng:\n```\nlld-link: error: undefined symbol: __declspec(dllimport) public: class absl::Status __thiscall quiche::BTreeScheduler\u003cint, int\u003e::Register(int, int const \u0026)\n```\n\nThe CustomStructWritesTooLittle test changes avoids an unused variable error on ios-simulator.\n\nPiperOrigin-RevId: 607146214\n" }, { "commit": "efc574e1125251bc1c3195c0c183c843b4c0a1df", "tree": "813cad26945ac87e4e55b5cc091047ea0e69a83b", "parents": [ "652a5992b4b99ba67e69c41125a7bb987e04319d" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Wed Feb 14 10:33:20 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 14 10:34:02 2024 -0800" }, "message": "Fix test flake in MoqtSubscribeWindows.\n\nSwitching to node_hash_map makes ordering non-deterministic.\n\nNot in production.\n\nPiperOrigin-RevId: 607032646\n" }, { "commit": "652a5992b4b99ba67e69c41125a7bb987e04319d", "tree": "9c1fbf63c03602d1c9b2a683becccd44c50ed49c", "parents": [ "4d465e4ba0cb70902755ebef7bc7629ea872df83" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Wed Feb 14 10:30:10 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 14 10:31:09 2024 -0800" }, "message": "Remove #ifdef MOQT_AUTH_INFO. Also eliminate an old reference to subscribe_request\n\nInterop is done, and the num_parameters field is restored.\n\nNot in production\n\nPiperOrigin-RevId: 607031454\n" }, { "commit": "4d465e4ba0cb70902755ebef7bc7629ea872df83", "tree": "b2347f5a0a6ff8bcc92c27565b779f1b62841d5b", "parents": [ "c251a6f093e4362676d58222b1677b346a504d5d" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Wed Feb 14 08:36:53 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 14 08:37:34 2024 -0800" }, "message": "Fix error in MoQT Relative Location encoding.\n\nNot in production\n\nPiperOrigin-RevId: 606996381\n" }, { "commit": "c251a6f093e4362676d58222b1677b346a504d5d", "tree": "4b2271637c8ccf3a7da1270ffb0bc2eb0c48ce8f", "parents": [ "4dfd80328760185c82ba32ec9e38c7612e0ee2c5" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Wed Feb 14 07:46:50 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 14 07:47:41 2024 -0800" }, "message": "Prospectively fix Chromium build\n\ncl/606821319 accidentally used some std::variant tools in Chromium code - this replaces them with ABSL equivalents. I have no idea how to test whether this actually fixes the Chromium build.\n\nPiperOrigin-RevId: 606982766\n" }, { "commit": "4dfd80328760185c82ba32ec9e38c7612e0ee2c5", "tree": "66852999659c58ad49aa1053b6edeaa2bc5a90b1", "parents": [ "2c1f10f46ce16d42fcf692d324799d859e8478cc" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Tue Feb 13 19:12:24 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 13 19:14:24 2024 -0800" }, "message": "No public description\n\nPiperOrigin-RevId: 606821319\n" }, { "commit": "2c1f10f46ce16d42fcf692d324799d859e8478cc", "tree": "0083786f0220b3f7940ba14dc1f275f83dd07773", "parents": [ "a411a265ceb5c7bbbcaacef88e1fd027adb05b2b" ], "author": { "name": "martinduke", "email": "martinduke@google.com", "time": "Tue Feb 13 10:23:41 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 13 10:24:29 2024 -0800" }, "message": "Process incoming Unsubscribes.\n\nNot in production.\n\nPiperOrigin-RevId: 606667410\n" }, { "commit": "a411a265ceb5c7bbbcaacef88e1fd027adb05b2b", "tree": "99eb0773ba9e99cabf41bedbf87ece0412c94ae4", "parents": [ "bb4f68479fd8fa4738339cdcc5782b04b985b72b" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Tue Feb 13 06:53:01 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 13 06:54:15 2024 -0800" }, "message": "Fix issues required to build additional Quiche tests for Chrome\n\nThis fixes build issues and test failures that occur when attempting to build the following test files as part of Chrome builds:\n\n - common/btree_scheduler_test.cc\n - common/print_elements_test.cc\n - common/wire_serialization_test.cc\n - http2/test_tools/hpack_example_test.cc\n - quic/core/deterministic_connection_id_generator_test.cc\n - quic/core/tls_server_handshaker_test.cc\n - quic/core/quic_generic_session_test.cc\n - quic/tools/connect_tunnel_test.cc\n - quic/tools/connect_udp_tunnel_test.cc\n\nNote that I\u0027ve only tested this on Linux, so more minor changes might be needed to get all the tests passing on all platforms.\n\nThis CL doesn\u0027t introduce any meaningful changes in functionality.\n\nPiperOrigin-RevId: 606606193\n" }, { "commit": "bb4f68479fd8fa4738339cdcc5782b04b985b72b", "tree": "92015cefae650080706eaaf87c2b056765698569", "parents": [ "54ed8cc9e099a6c08b75ca8ca33b24ef60c115b2" ], "author": { "name": "renjietang", "email": "renjietang@google.com", "time": "Mon Feb 12 14:25:06 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 12 14:26:18 2024 -0800" }, "message": "Add 2 counters for number of successful multi-port probes.\n\nPiperOrigin-RevId: 606365200\n" }, { "commit": "54ed8cc9e099a6c08b75ca8ca33b24ef60c115b2", "tree": "d43ff522d4c6dc1148f27bd25649d9265374d6f3", "parents": [ "6daac10d1e985c03d5976074cea8c7698905e2be" ], "author": { "name": "dschinazi", "email": "dschinazi@google.com", "time": "Mon Feb 12 14:10:01 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 12 14:11:15 2024 -0800" }, "message": "Remove unused connect-udp-version\n\nThis is no longer used now that we only support RFC 9298 and not earlier drafts.\n\nPiperOrigin-RevId: 606360801\n" }, { "commit": "6daac10d1e985c03d5976074cea8c7698905e2be", "tree": "0255eb883898c93786f630b230a3ae41ee8a6736", "parents": [ "1a93c102b4eacd6d659ea5ffae36f0636ebecdb3" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Fri Feb 09 07:47:57 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 09 07:48:47 2024 -0800" }, "message": "Fix flaky //third_party/quic/core/batch_writer:quic_batch_writer_test\n\n```\nblaze test //third_party/quic/core/batch_writer:quic_batch_writer_test --runs_per_test\u003d10000\n\n//third_party/quic/core/batch_writer:quic_batch_writer_test PASSED in 63.2s\n Stats over 10000 runs: max \u003d 63.2s, min \u003d 1.1s, avg \u003d 2.8s, dev \u003d 1.3s\n\nExecuted 1 out of 1 test: 1 test passes.\nINFO: Streaming build results to: http://sponge2/630c0dde-180e-49c0-ae94-1ec704e5154c\n```\nPiperOrigin-RevId: 605628040\n" }, { "commit": "1a93c102b4eacd6d659ea5ffae36f0636ebecdb3", "tree": "98bb96905249016dee8f76cdaf79291e85a18c7e", "parents": [ "5fbf96f9cac15c0d854dbf1fdc30d440b2b57922" ], "author": { "name": "QUICHE team", "email": "quiche-dev@google.com", "time": "Fri Feb 09 06:47:34 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 09 06:49:06 2024 -0800" }, "message": "Fix spelling\n\n#cleanup\n\nPiperOrigin-RevId: 605616986\n" }, { "commit": "5fbf96f9cac15c0d854dbf1fdc30d440b2b57922", "tree": "ed62e28335b54bb5d0dcdb683aa4bb19fbd49009", "parents": [ "96cc769bf64270feaceeb765cb6b25fc177b0749" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Fri Feb 09 06:46:53 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 09 06:47:45 2024 -0800" }, "message": "Add a comment to kBBRv2 which explains that it\u0027s essentially BBRv3\nand a TODO to rename it when the implementation is complete.\n\nPiperOrigin-RevId: 605616858\n" }, { "commit": "96cc769bf64270feaceeb765cb6b25fc177b0749", "tree": "a346172d59a45a18df724242d3286376d142c4e6", "parents": [ "81733f93ba2c1774249fbd69926d0e16b31acad8" ], "author": { "name": "danzh", "email": "danzh@google.com", "time": "Thu Feb 08 10:19:51 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 08 10:20:41 2024 -0800" }, "message": "Change QuicConnection::cipher_id() to get underlying cipher id differently.\n\nThe current implementation doesn\u0027t work if cipher_id() is called outside of ProcessUdpPacket() stack. The new implementation iterate through all decrypters at different encryption levels to get the cipher id.\n\nAlso renamed --gfe2_reloadable_flag_quic_limit_new_streams_per_loop to --gfe2_reloadable_flag_quic_limit_new_streams_per_loop_2.\n\nProtected by FLAGS_quic_reloadable_flag_quic_limit_new_streams_per_loop_2.\n\nPiperOrigin-RevId: 605355455\n" }, { "commit": "81733f93ba2c1774249fbd69926d0e16b31acad8", "tree": "fc7b003ab6b608ec097b6a0c69c17b584c1899f0", "parents": [ "5c9a537dc7c43cf03c2ea4364a715973d674d036" ], "author": { "name": "rch", "email": "rch@google.com", "time": "Thu Feb 08 09:50:51 2024 -0800" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 08 09:52:51 2024 -0800" }, "message": "Always disable the QPACK dyanmic table for Hyperloop connections.\n\nThis will obsolete the need for the protocol flag quic_server_disable_qpack_dynamic_table.\n\nProtected by FLAGS_gfe2_reloadable_flag_disable_qpack_dynamic_table_for_hyperloop\".\n\nPiperOrigin-RevId: 605346489\n" } ], "next": "5c9a537dc7c43cf03c2ea4364a715973d674d036" }