tree dac3046a58abb295343d5790a4f9590fc569983b
parent 674f07b3c1454aa807c0969ddebeab619a5e63e0
author QUICHE team <quiche-dev@google.com> 1637029264 -0800
committer Copybara-Service <copybara-worker@google.com> 1637029320 -0800

Let OgHttp2Session avoid visitor callbacks for data on unknown streams.

This CL performs a stream map check in OgHttp2Session::OnDataFrameHeader() and
OgHttp2Session::OnStreamFrameData(). If the stream is not in the map, then
OgHttp2Session will avoid invoking visitor_.OnBeginDataForStream() and
visitor_.OnDataForStream(), respectively. This behavior is in line with
Http2Dispatcher behavior [1, 2] and brings oghttp2 more in line with nghttp2.
Similarly, this CL also moves visitor_.OnEndStream() into an already-existing
stream map check. This behavior also allows
Http2FloodMitigationTest.UpstreamRstStreamStormOnDownstreamCloseRegressionTest
to pass, as hypothesized in http://b/201799377#comment8:

blaze test //third_party/envoy/src/test/integration:http2_flood_integration_test  --test_filter=*/Http2FloodMitigationTest.UpstreamRstStreamStormOnDownstreamCloseRegressionTest/* --test_arg=--vmodule=oghttp2_session=2 --test_arg="--" --test_arg="-l trace" --test_env="ENVOY_NGHTTP2_TRACE="

Before: http://sponge2/3ea792e7-d946-413e-83f3-d20e1f92741f
After: http://sponge2/f43bb7d8-4374-46a4-8804-3e2be1719442

[1] http://google3/gfe/gfe2/http2/http2_dispatcher.cc;l=974-987;rcl=406920946
[2] http://google3/gfe/gfe2/http2/http2_dispatcher.cc;l=1024-1032;rcl=406920946

PiperOrigin-RevId: 410129890