)]}'
{
  "commit": "f21c1adbb32768a7df863f1513e3d1050bd58a6f",
  "tree": "d0df12aba9ac2e3ba6fd2ed00d9964688942c55f",
  "parents": [
    "7d4f913c7d5a87fca15fc7d26dc343ee11ff7754"
  ],
  "author": {
    "name": "bnc",
    "email": "bnc@google.com",
    "time": "Thu Jun 20 20:09:50 2019 -0700"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Fri Jun 21 13:04:05 2019 -0700"
  },
  "message": "Make QpackEncoder interface not progressive.\n\nWhen the QPACK implementation was originally written, an\nHpackEncoder::ProgressiveEncoder interface was used for encoding.  However, the\nway it is used in QuicSpdyStream, it is clear now that encoding can be done in a\nsingle pass into a std::string object.  QuicStream::WriteOrBufferData() does not\nlend itself easily to notifying the QPACK encoder that it is ready to take more\ndata.  Instead it is more natural to encode the entire header block and buffer\nthat in QuicStreamSendBuffer.  Also note that this should not cost more memory\nthan doing progressive encoding, because the SpdyHeaderBlock object would need\nto be kept around if progressive encoding was used.\n\nThis CL introduces no functional change, it just changes the interface, and\nmoves the code that calls Next() from QuicSpdyStream into QpackEncoder.  A\nfollow-up CL will clean up QpackEncoder internals.\n\ngfe-relnote: n/a, QUIC v99-only change.\nPiperOrigin-RevId: 254323435\nChange-Id: Ic3d203ed9f019ad01dba61d407a6e73bde5d12d1\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0aa796ac0938314cd86d5b6526c8263cf9ad6438",
      "old_mode": 33188,
      "old_path": "quic/core/http/end_to_end_test.cc",
      "new_id": "93eceb0e5bd3f81457eab80e31bbbcbae22399c3",
      "new_mode": 33188,
      "new_path": "quic/core/http/end_to_end_test.cc"
    },
    {
      "type": "modify",
      "old_id": "02601baf3a8ef6e4acc9a142c33ade9dc2c55160",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_stream.cc",
      "new_id": "92138a491a1db1672655250d8502ab040297da76",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_stream.cc"
    },
    {
      "type": "modify",
      "old_id": "de1310852be8f81d09a2888c9bd0e10dff94563f",
      "old_mode": 33188,
      "old_path": "quic/core/http/quic_spdy_stream_test.cc",
      "new_id": "c62748737a1e8691ace81bc3f9356f5e6ec9af1a",
      "new_mode": 33188,
      "new_path": "quic/core/http/quic_spdy_stream_test.cc"
    },
    {
      "type": "modify",
      "old_id": "0d74c2eb7b10897ce50c74826e50eec8ed6d0348",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/fuzzer/qpack_round_trip_fuzzer.cc",
      "new_id": "a677ab4ab5c30b6497ec52615cde0f55d2b87817",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/fuzzer/qpack_round_trip_fuzzer.cc"
    },
    {
      "type": "modify",
      "old_id": "92bf0dcae878ce94724f25d9259b80f114313ea8",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/qpack_encoder.cc",
      "new_id": "67e409eb7c6e6c2bfb2c2fb0d3a5a6b5c387de89",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/qpack_encoder.cc"
    },
    {
      "type": "modify",
      "old_id": "a14d91baa7f06155ba9bc3aa5c266c420a60f1cd",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/qpack_encoder.h",
      "new_id": "7ed5808c3648dff5f9744fb651057dfd764247d9",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/qpack_encoder.h"
    },
    {
      "type": "modify",
      "old_id": "add6a742288a939608e9a48d5da45c45355b6f8d",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/qpack_encoder_test.cc",
      "new_id": "8633529e43d8b03437678019e785ac68eb3077ae",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/qpack_encoder_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a5fdbea967d33b6b0b86d6723d21e3286345be67",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/qpack_encoder_test_utils.cc",
      "new_id": "d91d3d13d5e1b71d781106610ce188e828c19b75",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/qpack_encoder_test_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "f897d45884e2d138fadb3167f8d129d3dc61a327",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/qpack_encoder_test_utils.h",
      "new_id": "b1103dae6c3a9738bf057586f4ea54e05038e482",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/qpack_encoder_test_utils.h"
    },
    {
      "type": "modify",
      "old_id": "4fc1a3854b26192d39596d6852e8bfc6ef1fcec3",
      "old_mode": 33188,
      "old_path": "quic/core/qpack/qpack_round_trip_test.cc",
      "new_id": "1e9de2d7651c59975c4eb0dc07a8c1532cac723c",
      "new_mode": 33188,
      "new_path": "quic/core/qpack/qpack_round_trip_test.cc"
    }
  ]
}